From patchwork Thu Jan 18 15:29:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 25436 Received: (qmail 100452 invoked by alias); 18 Jan 2018 15:29:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 100442 invoked by uid 89); 18 Jan 2018 15:29:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=OBV, obv, H*r:sk:static. X-HELO: mail-wr0-f195.google.com Received: from mail-wr0-f195.google.com (HELO mail-wr0-f195.google.com) (209.85.128.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Jan 2018 15:29:23 +0000 Received: by mail-wr0-f195.google.com with SMTP id z48so22972428wrz.6 for ; Thu, 18 Jan 2018 07:29:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=jjoAQGskwY68YA6rpQqncHwibIhF3tvr+xR51rYvqpU=; b=MoTmGtsXzHfswmXOFEhx1kEzlkYugiEgmEEV98VDNBKXEkBSGPbXyPHWdgtTGkf6O9 +p6PfRxh3gmyoWsq9u21OvxhJV/s7kTGuJpTwZEx/rxKuIpnwn0ZnsTmxeQmL66AchFN I+bySbHwJlZxWVUo0iiIGNbzPBMCC0cIQXhhvqGFZ+R4SM9gyvYo1wrLiyuRCBP1fNms oFAnsrHLWxD/R6fExt1KuCFN41Vwy7bgVNI9cfm9p4yT4jDl+Mp11Kl8GvFx3sXivksO BlSxG1Q7PkCxXBoLjar39+71i9CUtb4Atitd10DslXM0UGYEeInkzGJKWQJxkfSA7/fs x4RA== X-Gm-Message-State: AKwxytdubmPa1ArcRWrFPh5zflHF9bhq1ESEaufCWogafmW3BncRSUph O/0FwRyyaX0WlpMnaJOI6WAYMg== X-Google-Smtp-Source: ACJfBosTIq1mh171hYI1qactki8d9laNAiG/DRRpXKdD9HfVkckDbafBNodEo4E3bmTEYmiPy/Cjgg== X-Received: by 10.223.177.158 with SMTP id q30mr2695192wra.206.1516289360846; Thu, 18 Jan 2018 07:29:20 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id f142sm6754912wmf.38.2018.01.18.07.29.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 Jan 2018 07:29:20 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH OBV] Make abbrev_table::abbrevs private Date: Thu, 18 Jan 2018 15:29:16 +0000 Message-Id: <1516289356-7500-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes abbrev_table::abbrevs is only accessed within abbrev_table's methods, so it can be private. Add "m_" prefix. I'll pushed it in. gdb: 2018-01-18 Yao Qi * dwarf2read.c (abbrev_table) : Rename it to m_abbrevs. (abbrev_table::add_abbrev): Update. (abbrev_table::lookup_abbrev): Update. --- gdb/ChangeLog | 7 +++++++ gdb/dwarf2read.c | 14 ++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 926ee20..90dacd2 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2018-01-18 Yao Qi + * dwarf2read.c (abbrev_table) : Rename it to + m_abbrevs. + (abbrev_table::add_abbrev): Update. + (abbrev_table::lookup_abbrev): Update. + +2018-01-18 Yao Qi + * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read. 2018-01-17 Sergio Durigan Junior diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index d9fef59..4384f78 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -1503,9 +1503,9 @@ struct abbrev_table explicit abbrev_table (sect_offset off) : sect_off (off) { - abbrevs = + m_abbrevs = XOBNEWVEC (&abbrev_obstack, struct abbrev_info *, ABBREV_HASH_SIZE); - memset (abbrevs, 0, ABBREV_HASH_SIZE * sizeof (struct abbrev_info *)); + memset (m_abbrevs, 0, ABBREV_HASH_SIZE * sizeof (struct abbrev_info *)); } DISABLE_COPY_AND_ASSIGN (abbrev_table); @@ -1530,11 +1530,13 @@ struct abbrev_table /* Storage for the abbrev table. */ auto_obstack abbrev_obstack; +private: + /* Hash table of abbrevs. This is an array of size ABBREV_HASH_SIZE allocated in abbrev_obstack. It could be statically allocated, but the previous code didn't so we don't either. */ - struct abbrev_info **abbrevs; + struct abbrev_info **m_abbrevs; }; typedef std::unique_ptr abbrev_table_up; @@ -18000,8 +18002,8 @@ abbrev_table::add_abbrev (unsigned int abbrev_number, unsigned int hash_number; hash_number = abbrev_number % ABBREV_HASH_SIZE; - abbrev->next = abbrevs[hash_number]; - abbrevs[hash_number] = abbrev; + abbrev->next = m_abbrevs[hash_number]; + m_abbrevs[hash_number] = abbrev; } /* Look up an abbrev in the table. @@ -18014,7 +18016,7 @@ abbrev_table::lookup_abbrev (unsigned int abbrev_number) struct abbrev_info *abbrev; hash_number = abbrev_number % ABBREV_HASH_SIZE; - abbrev = abbrevs[hash_number]; + abbrev = m_abbrevs[hash_number]; while (abbrev) {