From patchwork Thu Jan 4 08:35:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 25204 Received: (qmail 3187 invoked by alias); 4 Jan 2018 08:36:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 3100 invoked by uid 89); 4 Jan 2018 08:36:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Five X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Jan 2018 08:35:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8023B1176E0 for ; Thu, 4 Jan 2018 03:35:57 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tRA3+iixWHNj for ; Thu, 4 Jan 2018 03:35:57 -0500 (EST) Received: from tron.gnat.com (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) by rock.gnat.com (Postfix) with ESMTP id 71514116E2E for ; Thu, 4 Jan 2018 03:35:57 -0500 (EST) Received: by tron.gnat.com (Postfix, from userid 4233) id 7020948A; Thu, 4 Jan 2018 03:35:57 -0500 (EST) From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [PATCH 1/3] Add gdb.ada/info_addr_mixed_case new testcase Date: Thu, 4 Jan 2018 03:35:51 -0500 Message-Id: <1515054953-81012-2-git-send-email-brobecker@adacore.com> In-Reply-To: <1515054953-81012-1-git-send-email-brobecker@adacore.com> References: <1515054953-81012-1-git-send-email-brobecker@adacore.com> This patch adds a new testcase to demonstrate a regression introduced by: commit b5ec771e60c1a0863e51eb491c85c674097e9e13 Date: Wed Nov 8 14:22:32 2017 +0000 Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching The purpose of the testcase is to verify that a user can use any casing for an Ada symbol name passed to the "info address" command. After the patch above was applied, GDB was no longer able to find the symbol: (gdb) info address My_Table No symbol "My_Table" in current context. gdb/testsuite/ChangeLog: PR gdb/22670 * gdb.ada/info_addr_mixed_case: New testcase. Tested on x86_64-linux, both before and after the patch. --- gdb/testsuite/ChangeLog | 5 +++ gdb/testsuite/gdb.ada/info_addr_mixed_case.exp | 42 ++++++++++++++++++++++ gdb/testsuite/gdb.ada/info_addr_mixed_case/foo.adb | 21 +++++++++++ gdb/testsuite/gdb.ada/info_addr_mixed_case/pck.adb | 24 +++++++++++++ gdb/testsuite/gdb.ada/info_addr_mixed_case/pck.ads | 35 ++++++++++++++++++ 5 files changed, 127 insertions(+) create mode 100644 gdb/testsuite/gdb.ada/info_addr_mixed_case.exp create mode 100644 gdb/testsuite/gdb.ada/info_addr_mixed_case/foo.adb create mode 100644 gdb/testsuite/gdb.ada/info_addr_mixed_case/pck.adb create mode 100644 gdb/testsuite/gdb.ada/info_addr_mixed_case/pck.ads diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 500dbdd..b1be7e3 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-01-04 Joel Brobecker + + PR gdb/22670 + * gdb.ada/info_addr_mixed_case: New testcase. + 2018-01-03 Xavier Roirand * gdb.ada/excep_handle.exp: New testcase. diff --git a/gdb/testsuite/gdb.ada/info_addr_mixed_case.exp b/gdb/testsuite/gdb.ada/info_addr_mixed_case.exp new file mode 100644 index 0000000..e9fce0d --- /dev/null +++ b/gdb/testsuite/gdb.ada/info_addr_mixed_case.exp @@ -0,0 +1,42 @@ +# Copyright 2018 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +load_lib "ada.exp" + +standard_ada_testfile foo + +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug ]] != "" } { + return -1 +} + +clean_restart ${testfile} + +set bp_location [gdb_get_line_number "START" ${testdir}/foo.adb] +if ![runto "foo.adb:$bp_location" ] then { + perror "Couldn't run ${testfile}" + return +} + +# The following test exercises the situation when uppercase letters +# are used in the name of the symbol passed to the "info address" +# command. This should not make a difference, as the language is +# Ada, and Ada is case-insensitive. + +# commit b5ec771e60c1a0863e51eb491c85c674097e9e13 (Introduce +# lookup_name_info and generalize Ada's FULL/WILD name matching) +# caused the following test to fail. KFAIL it while investigating... +setup_kfail gdb/22670 "*-*-*" +gdb_test "info address My_Table" \ + "Symbol \"pck\\.my_table\" is static storage at address $hex\\." diff --git a/gdb/testsuite/gdb.ada/info_addr_mixed_case/foo.adb b/gdb/testsuite/gdb.ada/info_addr_mixed_case/foo.adb new file mode 100644 index 0000000..0028fda --- /dev/null +++ b/gdb/testsuite/gdb.ada/info_addr_mixed_case/foo.adb @@ -0,0 +1,21 @@ +-- Copyright 2018 Free Software Foundation, Inc. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 3 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public License +-- along with this program. If not, see . + +with Pck; use Pck; + +procedure Foo is +begin + Do_Nothing (My_Table'Address); -- START +end Foo; diff --git a/gdb/testsuite/gdb.ada/info_addr_mixed_case/pck.adb b/gdb/testsuite/gdb.ada/info_addr_mixed_case/pck.adb new file mode 100644 index 0000000..2057040 --- /dev/null +++ b/gdb/testsuite/gdb.ada/info_addr_mixed_case/pck.adb @@ -0,0 +1,24 @@ +-- Copyright 2018 Free Software Foundation, Inc. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 3 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public License +-- along with this program. If not, see . + +package body Pck is + + procedure Do_Nothing (A : System.Address) is + begin + null; + end Do_Nothing; + +end Pck; + diff --git a/gdb/testsuite/gdb.ada/info_addr_mixed_case/pck.ads b/gdb/testsuite/gdb.ada/info_addr_mixed_case/pck.ads new file mode 100644 index 0000000..0a786cc --- /dev/null +++ b/gdb/testsuite/gdb.ada/info_addr_mixed_case/pck.ads @@ -0,0 +1,35 @@ +-- Copyright 2018 Free Software Foundation, Inc. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 3 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public License +-- along with this program. If not, see . + +with System; + +package Pck is + + type Float_Array is array (Integer range <>) of Integer; + type Float_Ptr is access Float_Array; + + type Table_Type is (One, Two, Three, Four, Five); + type New_Table_Array is array (Table_Type) of Float_Ptr; + + My_Table : New_Table_Array := (others => new Float_Array'((4 => 16#DE#, + 5 => 16#AD#))); + + My_F : Float_Ptr := new Float_Array'(4 => 16#BE#, + 5 => 16#EF#); + + procedure Do_Nothing (A : System.Address); + +end Pck; +