From patchwork Fri Dec 15 10:44:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 24962 Received: (qmail 112791 invoked by alias); 15 Dec 2017 10:45:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 112594 invoked by uid 89); 15 Dec 2017 10:45:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-wm0-f50.google.com Received: from mail-wm0-f50.google.com (HELO mail-wm0-f50.google.com) (74.125.82.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Dec 2017 10:45:03 +0000 Received: by mail-wm0-f50.google.com with SMTP id 64so16641947wme.3 for ; Fri, 15 Dec 2017 02:45:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=oKQ1hPvf8pqAqkbYCRW4Qk/Cq3hBs+EwdtmF8zBsuAA=; b=g1gPgvkwQ22ljyd3YJFD6vjARaJhQJJ5E4uW7QK6lCHzxfv0LHCuN9Yo3GLs8hj1ip s4OC6steglNI9dz2FE7lZavjxFIWYgIMg7M88rFeTBsR9vAT8h+RlPMkyQ8nLHnzqqPb b89GhVMCIyvPSu1ugEgD9QlwXO9cYjSQAF3veupJo9JpcNm2EMLnbr/XB/eEl+nTCuTF +wUgXQlLH6Dp1gomzO334VPuZ94/RhcEJCrzHmdDqijPRhjIHx/elVkb7X8lFAd43zAX 7Bif4pk1nVOIF4KEPAhHYsDLQkotdZFUtv4MUlcro4oNyEbWQvl7TFNzlmzV++q4uyAH 1yPA== X-Gm-Message-State: AKGB3mI24dKP3Quu+R30+itUSkKakt42SFhOMz2CNPwQteCN/xYQkq7x jaontlELbsTr0jeaBp/nVEycWw== X-Google-Smtp-Source: ACJfBosPKalbZpyYiLjRqz2cOyXrRmZPtpgkMwAzoKl+2OAbsHO2vA9wCwYrUmhr+174Rbf0LELcDA== X-Received: by 10.28.160.23 with SMTP id j23mr965104wme.54.1513334701158; Fri, 15 Dec 2017 02:45:01 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id 52sm18118146wrv.8.2017.12.15.02.45.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Dec 2017 02:45:00 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH OBV] Skip 'maintenance check xml-descriptions' if XML is disabled Date: Fri, 15 Dec 2017 10:44:57 +0000 Message-Id: <1513334697-31283-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes I see the following test failure when gdb is configured without XML support, maintenance check xml-descriptions binutils-gdb/gdb/testsuite/../features warning: Can not parse XML target description; XML support was disabled at compile time^M Tested 29 XML files, 29 failed (gdb) FAIL: gdb.gdb/unittest.exp: maintenance check xml-descriptions ${srcdir}/../features gdb/testsuite: 2017-12-15 Yao Qi * gdb.gdb/unittest.exp: Skip 'maintenance check xml-descriptions' if XML is disabled. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.gdb/unittest.exp | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 84ad6d6..8d52bb9 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2017-12-15 Yao Qi + + * gdb.gdb/unittest.exp: Skip 'maintenance check xml-descriptions' + if XML is disabled. + 2017-12-15 Xavier Roirand * gdb.ada/same_component_name: New testcase. diff --git a/gdb/testsuite/gdb.gdb/unittest.exp b/gdb/testsuite/gdb.gdb/unittest.exp index 58494e1..7d280d1 100644 --- a/gdb/testsuite/gdb.gdb/unittest.exp +++ b/gdb/testsuite/gdb.gdb/unittest.exp @@ -13,10 +13,12 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . +set do_xml_test [expr ![gdb_skip_xml_test]] + gdb_start gdb_test "maintenance selftest" "Ran $decimal unit tests, 0 failed" -if { ![is_remote host] } { +if { ![is_remote host] && $do_xml_test } { gdb_test "maintenance check xml-descriptions ${srcdir}/../features" \ "Tested $decimal XML files, 0 failed" \ "maintenance check xml-descriptions \${srcdir}/../features"