From patchwork Fri Dec 15 10:44:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 24961 Received: (qmail 104921 invoked by alias); 15 Dec 2017 10:44:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 104902 invoked by uid 89); 15 Dec 2017 10:44:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:clients, H*r:sk:static. X-HELO: mail-wm0-f45.google.com Received: from mail-wm0-f45.google.com (HELO mail-wm0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Dec 2017 10:44:28 +0000 Received: by mail-wm0-f45.google.com with SMTP id 9so16540092wme.4 for ; Fri, 15 Dec 2017 02:44:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=AmBCspjuTK0mIBFfIdJplGebYW4uv8ZZRy219pIKiiY=; b=Gdm0yGC+gndDMvhmeK28L451sbXm4Tzm5UnYby891g4pECwfWnPReH4Py+Et+YbJ7K 1tsr8H11wPfrZdBLLAHKoU/e595XiOvb3vgtxasRhLjnFtsZeRlRayYr39yk/vTcwLVt evauAuw00+qVehWxpfPeI8hp7ZkWOUE7ZUi1K7SqnwRlgSqdn9oO5YmQGACo5DMleNxk NCY05/4qnuR5v9IL768mekwhfbz7jXwag0MWKKFG+z+OhFaItiZynXRkoXt/pgt+f8m0 N+CrBnHipfhazVBMiyMTy2hjFqLWXWmNgLmncXxxBHIZ8hEPeJVtCWJbsg5gIvSPetMG PqGw== X-Gm-Message-State: AKGB3mKbvDAVLbxZXKk9KQ/j4A+Yh7IqxHGvVUnTHyaLYyuheLgXbJO5 9zpuXpG5CLZ9v6bg5EKrjEYlbA== X-Google-Smtp-Source: ACJfBotsSSAaKNIyYChZkNJs8NoLZtpYpUU9Ibw+vka2Oi4wMBKz902HerAmsXrWCIHqs3W5AoLhdw== X-Received: by 10.28.232.70 with SMTP id f67mr5290752wmh.90.1513334665943; Fri, 15 Dec 2017 02:44:25 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id c54sm7554746wra.84.2017.12.15.02.44.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Dec 2017 02:44:25 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH OBV] Skip parse_memory_map_tests if XML is disabled Date: Fri, 15 Dec 2017 10:44:21 +0000 Message-Id: <1513334661-31215-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes I find a fail in gdb unit test when gdb is configured without XML support. warning: Can not parse XML memory map; XML support was disabled at compile time^M Self test failed: self-test failed at ../../binutils-gdb/gdb/unittests/memory-map-selftests.c:65 ... Ran 31 unit tests, 1 failed^M (gdb) FAIL: gdb.gdb/unittest.exp: maintenance selftest I'll push it in. gdb: 2017-12-15 Yao Qi * unittests/memory-map-selftests.c: Wrap test with HAVE_LIBEXPAT. --- gdb/ChangeLog | 4 ++++ gdb/unittests/memory-map-selftests.c | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 83a014a..292929d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-12-15 Yao Qi + + * unittests/memory-map-selftests.c: Wrap test with HAVE_LIBEXPAT. + 2017-12-15 Xavier Roirand * ada-lang.c (ada_value_primitive_field): Handle field search diff --git a/gdb/unittests/memory-map-selftests.c b/gdb/unittests/memory-map-selftests.c index 3b282b5..618a1e9 100644 --- a/gdb/unittests/memory-map-selftests.c +++ b/gdb/unittests/memory-map-selftests.c @@ -21,6 +21,8 @@ #include "selftest.h" #include "memory-map.h" +#if defined(HAVE_LIBEXPAT) + namespace selftests { namespace memory_map_tests { @@ -72,10 +74,14 @@ parse_memory_map_tests () } /* namespace memory_map_tests */ } /* namespace selftests */ +#endif /* HAVE_LIBEXPAT */ + void _initialize_memory_map_selftests () { +#if defined(HAVE_LIBEXPAT) selftests::register_test ("parse_memory_map", selftests::memory_map_tests::parse_memory_map_tests); +#endif }