From patchwork Tue Nov 21 15:16:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 24409 Received: (qmail 95465 invoked by alias); 21 Nov 2017 15:16:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 95456 invoked by uid 89); 21 Nov 2017 15:16:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:sk:static., Hx-spam-relays-external:sk:static., H*r:sk:clients, H*r:sk:static. X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Nov 2017 15:16:33 +0000 Received: by mail-wm0-f65.google.com with SMTP id u83so4156865wmb.5 for ; Tue, 21 Nov 2017 07:16:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=7CjpPQ+yTzcbuzVNMshrXmCBio0nSbWm+Q+8YGzOphw=; b=Acp6MVzHxy4n+phAttoyqkxQQuuImiTdwnyzzz/t+mMsNlJHJim6RV4zFGxB1LeMky 0RkG2/ioMBNzKGa8NkOwB+IUQqvNVVUNwSZcf4J4zyXrz3L5ihmTRwfTaZAZ7SEaOTfj +sPjGlVaKnWGpz/bzF1PHy+GbJfVUjK7tfkh0NtoEZsSPQNTzhvWMMmv+BnAZasXpzQ8 IDwje6xyjVjUtBjAHQyPgZ0mm8twpyr8Pe3/4kMkyKk7cTDcqhVrJksT1Ac0K0g3Eq0S RjQ3zwUNsAcqtM0k1i5opLRrCP0Xok4OR4XXK8vriP+cR+c5ZCBitCfLaFpmRqynZUtf tqFQ== X-Gm-Message-State: AJaThX6CSzbitTrKnRvZoP8qQcUB33OFpyQYlD5+wlmYIL3RdkPyb8Sb ONXNh9gar0FQSlndkPJ3LkJFCw== X-Google-Smtp-Source: AGs4zMb+eE18dRipJs6om0XMcZ6whDC7mX9glxJFU7VOIeO2Rr9ji0Bhmp61FUBiS0GdI8b8FciClg== X-Received: by 10.28.13.135 with SMTP id 129mr1705108wmn.24.1511277390521; Tue, 21 Nov 2017 07:16:30 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id o190sm2420920wmd.32.2017.11.21.07.16.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 21 Nov 2017 07:16:30 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH] [testsuite] Remove code setting target_cflags -D_MIT_POSIX_THREADS Date: Tue, 21 Nov 2017 15:16:26 +0000 Message-Id: <1511277386-30697-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes target_cflags is not used at all. This patch removes it. I searched the history of gdb, gcc and dejagnu, I don't see how target_cflags was used. gdb/testsuite: 2017-11-21 Yao Qi * gdb.threads/gcore-thread.exp: Remove code setting target_cflags. * gdb.threads/pthreads.exp: Likewise. * gdb.threads/tls-nodebug.exp: Likewise. * gdb.threads/tls.exp: Likewise. --- gdb/testsuite/gdb.threads/gcore-thread.exp | 6 ------ gdb/testsuite/gdb.threads/pthreads.exp | 6 ------ gdb/testsuite/gdb.threads/tls-nodebug.exp | 6 ------ gdb/testsuite/gdb.threads/tls.exp | 6 ------ 4 files changed, 24 deletions(-) diff --git a/gdb/testsuite/gdb.threads/gcore-thread.exp b/gdb/testsuite/gdb.threads/gcore-thread.exp index b01fa83..571b25c 100644 --- a/gdb/testsuite/gdb.threads/gcore-thread.exp +++ b/gdb/testsuite/gdb.threads/gcore-thread.exp @@ -22,12 +22,6 @@ set objfile $binfile.o set corefile $binfile.test set core0file ${binfile}0.test -if [istarget "*-*-linux"] then { - set target_cflags "-D_MIT_POSIX_THREADS" -} else { - set target_cflags "" -} - # Attempt to prevent -Wl,-z,relro which happens by default at least on # Kubuntu-10.10. Due to PR corefiles/11804 will then GDB be unable to find # libpthread, therefore libthread_db will not fail as expected diff --git a/gdb/testsuite/gdb.threads/pthreads.exp b/gdb/testsuite/gdb.threads/pthreads.exp index 994846c..5c6f366 100644 --- a/gdb/testsuite/gdb.threads/pthreads.exp +++ b/gdb/testsuite/gdb.threads/pthreads.exp @@ -27,12 +27,6 @@ standard_testfile # carriage return) set horiz "\[^\n\r\]*" -if [istarget "*-*-linux"] then { - set target_cflags "-D_MIT_POSIX_THREADS" -} else { - set target_cflags "" -} - if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable debug] != "" } { return -1 } diff --git a/gdb/testsuite/gdb.threads/tls-nodebug.exp b/gdb/testsuite/gdb.threads/tls-nodebug.exp index e718736..421c651 100644 --- a/gdb/testsuite/gdb.threads/tls-nodebug.exp +++ b/gdb/testsuite/gdb.threads/tls-nodebug.exp @@ -16,12 +16,6 @@ standard_testfile -if [istarget "*-*-linux"] then { - set target_cflags "-D_MIT_POSIX_THREADS" -} else { - set target_cflags "" -} - if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable []] != "" } { return -1 } diff --git a/gdb/testsuite/gdb.threads/tls.exp b/gdb/testsuite/gdb.threads/tls.exp index 4213178..4517688 100644 --- a/gdb/testsuite/gdb.threads/tls.exp +++ b/gdb/testsuite/gdb.threads/tls.exp @@ -18,12 +18,6 @@ load_lib gdb-python.exp standard_testfile tls.c tls2.c -if [istarget "*-*-linux"] then { - set target_cflags "-D_MIT_POSIX_THREADS" -} else { - set target_cflags "" -} - if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile} ${srcdir}/${subdir}/${srcfile2}" "${binfile}" executable [list c++ debug]] != "" } { return -1 }