From patchwork Thu Sep 21 16:19:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Walfred Tedeschi X-Patchwork-Id: 23063 Received: (qmail 19427 invoked by alias); 21 Sep 2017 16:21:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 18938 invoked by uid 89); 21 Sep 2017 16:20:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=4.3.0, 18.0 X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 16:20:06 +0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2017 09:20:01 -0700 X-ExtLoop1: 1 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by FMSMGA003.fm.intel.com with ESMTP; 21 Sep 2017 09:19:59 -0700 Received: from ulvlx001.iul.intel.com (ulvlx001.iul.intel.com [172.28.207.17]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id v8LGJw56021438; Thu, 21 Sep 2017 17:19:58 +0100 Received: from ulvlx001.iul.intel.com (localhost [127.0.0.1]) by ulvlx001.iul.intel.com with ESMTP id v8LGJw99019677; Thu, 21 Sep 2017 18:19:58 +0200 Received: (from wtedesch@localhost) by ulvlx001.iul.intel.com with LOCAL id v8LGJwSS019673; Thu, 21 Sep 2017 18:19:58 +0200 From: Walfred Tedeschi To: palves@redhat.com, simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org, Walfred Tedeschi Subject: [PATCH V2] icc: allow code path for newer versions of icc. Date: Thu, 21 Sep 2017 18:19:52 +0200 Message-Id: <1506010792-19642-1-git-send-email-walfred.tedeschi@intel.com> X-IsSubscribed: yes Patch adds a version checkin for workaround an icc problem. Icc problem was fixed in version 14, and gdb code has to reflect the fix. This patch contains a parser for the icc string version and conditional workaround execution. Adds also gdb self tests for the dwarf producers. 2017-06-28 Walfred Tedeschi gdb/ChangeLog: * dwarf2read.c (dwarf2_cu): Remove field producer_is_icc and add producer_is_icc_lt_14. (producer_is_icc_lt_14): New function. (check_producer): Add code for checking version of icc. (producer_is_icc): Move to dwarf2utils. (read_structure_type): Add a check for the later version of icc where the issue was still not fixed. (dwarf_producer_test): Add new unit test. (_initialize_dwarf2_read): Register the unit test. * producer.c (producer_is_icc, _initialize_producer): New function. * producer.h (producer_is_icc): New function. --- gdb/dwarf2read.c | 35 ++++++++++++++---------- gdb/producer.c | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ gdb/producer.h | 24 ++++++++++++++++ 3 files changed, 127 insertions(+), 15 deletions(-) diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 4083c63..dac0609 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -603,7 +603,7 @@ struct dwarf2_cu unsigned int checked_producer : 1; unsigned int producer_is_gxx_lt_4_6 : 1; unsigned int producer_is_gcc_lt_4_3 : 1; - unsigned int producer_is_icc : 1; + unsigned int producer_is_icc_lt_14 : 1; /* When set, the file that we're processing is known to have debugging info for C++ namespaces. GCC 3.3.x did not produce @@ -9348,6 +9348,19 @@ read_import_statement (struct die_info *die, struct dwarf2_cu *cu) &objfile->objfile_obstack); } +/* For versions older than 14 ICC did not output the required DW_AT_declaration + on incomplete types, but gives them a size of zero. Starting on version 14 + ICC is compatible with GCC. */ + +static int +producer_is_icc_lt_14 (struct dwarf2_cu *cu) +{ + if (!cu->checked_producer) + check_producer (cu); + + return cu->producer_is_icc_lt_14; +} + /* Check for possibly missing DW_AT_comp_dir with relative .debug_line directory paths. GCC SVN r127613 (new option -fdebug-prefix-map) fixed this, it was first present in GCC release 4.3.0. */ @@ -12829,6 +12842,9 @@ dwarf2_record_block_ranges (struct die_info *die, struct block *block, } } + + + /* Check whether the producer field indicates either of GCC < 4.6, or the Intel C/C++ compiler, and cache the result in CU. */ @@ -12853,8 +12869,8 @@ check_producer (struct dwarf2_cu *cu) cu->producer_is_gxx_lt_4_6 = major < 4 || (major == 4 && minor < 6); cu->producer_is_gcc_lt_4_3 = major < 4 || (major == 4 && minor < 3); } - else if (startswith (cu->producer, "Intel(R) C")) - cu->producer_is_icc = 1; + else if (producer_is_icc (cu->producer, &major, &minor)) + cu->producer_is_icc_lt_14 = major < 14; else { /* For other non-GCC compilers, expect their behavior is DWARF version @@ -13595,17 +13611,6 @@ quirk_gcc_member_function_pointer (struct type *type, struct objfile *objfile) smash_to_methodptr_type (type, new_type); } -/* Return non-zero if the CU's PRODUCER string matches the Intel C/C++ compiler - (icc). */ - -static int -producer_is_icc (struct dwarf2_cu *cu) -{ - if (!cu->checked_producer) - check_producer (cu); - - return cu->producer_is_icc; -} /* Called when we find the DIE that starts a structure or union scope (definition) to create a type for the structure or union. Fill in @@ -13711,7 +13716,7 @@ read_structure_type (struct die_info *die, struct dwarf2_cu *cu) TYPE_LENGTH (type) = 0; } - if (producer_is_icc (cu) && (TYPE_LENGTH (type) == 0)) + if (producer_is_icc_lt_14 (cu) && (TYPE_LENGTH (type) == 0)) { /* ICC does not output the required DW_AT_declaration on incomplete types, but gives them a size of zero. */ diff --git a/gdb/producer.c b/gdb/producer.c index bea0d7e..ac10f54 100644 --- a/gdb/producer.c +++ b/gdb/producer.c @@ -22,9 +22,15 @@ #include "defs.h" #include "dyn-string.h" #include + #include "common/common-types.h" #include "common/common-exceptions.h" #include "common/common-utils.h" + +#if defined GDB_SELF_TEST +#include "selftest.h" +#endif + #include "utils.h" /* See documentation in the producer.h file. */ @@ -124,3 +130,80 @@ producer_is_icc (const char *producer, int *major, int *minor) } return FALSE; } + +#if defined GDB_SELF_TEST +namespace selftests { +namespace dwarf2utils { + +static void +dwarf_producer () +{ + int major = 0, minor = 0; + + const char *extern_f_14_1 = "Intel(R) Fortran Intel(R) 64 Compiler \ +XE for applications running on Intel(R) 64, Version \ +14.0.1.074 Build 20130716"; + + bool retval = producer_is_icc (extern_f_14_1, &major, &minor); + SELF_CHECK (retval == 1 && major == 14 && minor == 1); + retval = producer_is_gcc (extern_f_14_1, &major, &minor); + SELF_CHECK (retval == 0); + + const char *intern_f_14 = "Intel(R) Fortran Intel(R) 64 Compiler \ +XE for applications running on Intel(R) 64, Version \ +14.0"; + + major = 0; + minor = 0; + retval = producer_is_icc (intern_f_14, &major, &minor); + SELF_CHECK (retval == 1 && major == 14 && minor == 0); + retval = producer_is_gcc (intern_f_14, &major, &minor); + SELF_CHECK (retval == 0); + + const char *intern_c_14 = "Intel(R) C++ Intel(R) 64 Compiler \ +XE for applications running on Intel(R) 64, Version \ +14.0"; + major = 0; + minor = 0; + retval = producer_is_icc (intern_c_14, &major, &minor); + SELF_CHECK (retval == 1 && major == 14 && minor == 0); + retval = producer_is_gcc (intern_c_14, &major, &minor); + SELF_CHECK (retval == 0); + + const char *intern_c_18 = "Intel(R) C++ Intel(R) 64 Compiler \ +for applications running on Intel(R) 64, Version 18.0 Beta"; + major = 0; + minor = 0; + retval = producer_is_icc (intern_c_18, &major, &minor); + SELF_CHECK (retval == 1 && major == 18 && minor == 0); + + const char *gnu = "GNU C 4.7.2"; + major = 0; + minor = 0; + retval = producer_is_icc (gnu, &major, &minor); + SELF_CHECK (retval == 0); + retval = producer_is_gcc (gnu, &major, &minor); + SELF_CHECK (retval == 1 && major == 4 && minor == 7); + + const char *gnu_exp ="GNU C++14 5.0.0 20150123 (experimental)"; + major = 0; + minor = 0; + retval = producer_is_icc (gnu_exp, &major, &minor); + SELF_CHECK (retval == 0); + retval = producer_is_gcc (gnu_exp, &major, &minor); + SELF_CHECK (retval == 1 && major == 5 && minor == 0); +} +} +} +#endif + +/* Provide a prototype to silence -Wmissing-prototypes. */ +extern initialize_file_ftype _initialize_dwarf2utils; + +void +_initialize_dwarf2utils (void) +{ +#if defined GDB_SELF_TEST + selftests::register_test ("dwarf-producer", selftests::dwarf2utils::dwarf_producer); +#endif +} diff --git a/gdb/producer.h b/gdb/producer.h index 961f958..b2383c8 100644 --- a/gdb/producer.h +++ b/gdb/producer.h @@ -33,4 +33,28 @@ extern int producer_is_gcc_ge_4 (const char *producer); extern int producer_is_gcc (const char *producer, int *major, int *minor); +/* Returns TRUE if the given PRODUCER string is Intel or FALSE + otherwise. Sets the MAJOR and MINOR versions when not NULL. + + Internal and external versions have to be taken into account. + PRODUCER strings for internal releases are slightly different + than for public ones. Internal releases have a major release\ + number and 0 as minor release. External releases have 4 + fields, 3 of them are not 0 and only two are of interest, + major and update. + + Examples are: + + Public release: + "Intel(R) Fortran Intel(R) 64 Compiler XE for applications + running on Intel(R) 64, Version 14.0.1.074 Build 20130716"; + "Intel(R) C++ Intel(R) 64 Compiler XE for applications + running on Intel(R) 64, Version 14.0.1.074 Build 20130716"; + + Internal releases: + "Intel(R) C++ Intel(R) 64 Compiler for applications + running on Intel(R) 64, Version 18.0 Beta ....". */ + +extern bool producer_is_icc (const char *producer, int *major, int *minor); + #endif