[master/8.0] Add alias command to cmd_list_element
Commit Message
When we add alias command, we call add_alias_cmd and pass the alias name
and command name. This implicitly requires the command and its prefix
commands are already added to cmdlist. This may not be true, for example,
add_com_alias ("tty", "set inferior-tty", class_alias, 0);
"inferior-tty" command is added to setlist, but setlist may not be added
to cmdlist (It depends on the order of related _initialize_XXX functions
called) so that we can't find "set inferior-tty" from cmdlist.
This patch fixes this problem by pass cmd_list_element of "inferior-tty"
to add_alias_cmd, so that cmd_list_element of "inferior-tty" doesn't have
to be reachable from cmdlist at that moment.
Regression tested on x86_64-linux.
gdb:
2017-05-17 Yao Qi <yao.qi@linaro.org>
* cli/cli-decode.c (add_alias_cmd): New function.
* command.h (add_alias_cmd): Declare.
* infcmd.c (_initialize_infcmd): Don't call add_com_alias,
instead call add_alias_cmd.
gdb/testsuite:
2017-05-17 Simon Marchi <simon.marchi@ericsson.com>
* gdb.base/set-inferior-tty.exp (test_set_inferior_tty): Add
argument command.
(top-level): Invoke test_set_inferior_tty.
---
gdb/cli/cli-decode.c | 30 +++++++++++++++++++----------
gdb/command.h | 6 ++++++
gdb/infcmd.c | 5 ++++-
gdb/testsuite/gdb.base/set-inferior-tty.exp | 10 ++++++----
4 files changed, 36 insertions(+), 15 deletions(-)
Comments
On 2017-05-17 07:31, Yao Qi wrote:
> When we add alias command, we call add_alias_cmd and pass the alias
> name
> and command name. This implicitly requires the command and its prefix
> commands are already added to cmdlist. This may not be true, for
> example,
>
> add_com_alias ("tty", "set inferior-tty", class_alias, 0);
>
> "inferior-tty" command is added to setlist, but setlist may not be
> added
> to cmdlist (It depends on the order of related _initialize_XXX
> functions
> called) so that we can't find "set inferior-tty" from cmdlist.
>
> This patch fixes this problem by pass cmd_list_element of
> "inferior-tty"
"by passing"
> to add_alias_cmd, so that cmd_list_element of "inferior-tty" doesn't
> have
> to be reachable from cmdlist at that moment.
>
> Regression tested on x86_64-linux.
>
> gdb:
>
> 2017-05-17 Yao Qi <yao.qi@linaro.org>
>
> * cli/cli-decode.c (add_alias_cmd): New function.
> * command.h (add_alias_cmd): Declare.
> * infcmd.c (_initialize_infcmd): Don't call add_com_alias,
> instead call add_alias_cmd.
>
> gdb/testsuite:
>
> 2017-05-17 Simon Marchi <simon.marchi@ericsson.com>
>
> * gdb.base/set-inferior-tty.exp (test_set_inferior_tty): Add
> argument command.
> (top-level): Invoke test_set_inferior_tty.
> ---
> gdb/cli/cli-decode.c | 30
> +++++++++++++++++++----------
> gdb/command.h | 6 ++++++
> gdb/infcmd.c | 5 ++++-
> gdb/testsuite/gdb.base/set-inferior-tty.exp | 10 ++++++----
> 4 files changed, 36 insertions(+), 15 deletions(-)
>
> diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c
> index d45733e..e1d257a 100644
> --- a/gdb/cli/cli-decode.c
> +++ b/gdb/cli/cli-decode.c
> @@ -284,16 +284,10 @@ deprecate_cmd (struct cmd_list_element *cmd,
> const char *replacement)
> }
>
> struct cmd_list_element *
> -add_alias_cmd (const char *name, const char *oldname, enum
> command_class theclass,
> - int abbrev_flag, struct cmd_list_element **list)
> +add_alias_cmd (const char *name, cmd_list_element *old,
> + enum command_class theclass, int abbrev_flag,
> + struct cmd_list_element **list)
> {
> - const char *tmp;
> - struct cmd_list_element *old;
> - struct cmd_list_element *c;
> -
> - tmp = oldname;
> - old = lookup_cmd (&tmp, *list, "", 1, 1);
> -
> if (old == 0)
> {
> struct cmd_list_element *prehook, *prehookee, *posthook,
> *posthookee;
> @@ -307,7 +301,7 @@ add_alias_cmd (const char *name, const char
> *oldname, enum command_class theclas
> return 0;
> }
>
> - c = add_cmd (name, theclass, NULL, old->doc, list);
> + struct cmd_list_element *c = add_cmd (name, theclass, NULL,
> old->doc, list);
>
> /* If OLD->DOC can be freed, we should make another copy. */
> if (old->doc_allocated)
> @@ -330,6 +324,22 @@ add_alias_cmd (const char *name, const char
> *oldname, enum command_class theclas
> return c;
> }
>
> +struct cmd_list_element *
> +add_alias_cmd (const char *name, const char *oldname,
> + enum command_class theclass, int abbrev_flag,
> + struct cmd_list_element **list)
> +{
> + const char *tmp;
> + struct cmd_list_element *old;
> + struct cmd_list_element *c;
c is now unused.
Otherwise, LGTM. Thanks!
Simon
@@ -284,16 +284,10 @@ deprecate_cmd (struct cmd_list_element *cmd, const char *replacement)
}
struct cmd_list_element *
-add_alias_cmd (const char *name, const char *oldname, enum command_class theclass,
- int abbrev_flag, struct cmd_list_element **list)
+add_alias_cmd (const char *name, cmd_list_element *old,
+ enum command_class theclass, int abbrev_flag,
+ struct cmd_list_element **list)
{
- const char *tmp;
- struct cmd_list_element *old;
- struct cmd_list_element *c;
-
- tmp = oldname;
- old = lookup_cmd (&tmp, *list, "", 1, 1);
-
if (old == 0)
{
struct cmd_list_element *prehook, *prehookee, *posthook, *posthookee;
@@ -307,7 +301,7 @@ add_alias_cmd (const char *name, const char *oldname, enum command_class theclas
return 0;
}
- c = add_cmd (name, theclass, NULL, old->doc, list);
+ struct cmd_list_element *c = add_cmd (name, theclass, NULL, old->doc, list);
/* If OLD->DOC can be freed, we should make another copy. */
if (old->doc_allocated)
@@ -330,6 +324,22 @@ add_alias_cmd (const char *name, const char *oldname, enum command_class theclas
return c;
}
+struct cmd_list_element *
+add_alias_cmd (const char *name, const char *oldname,
+ enum command_class theclass, int abbrev_flag,
+ struct cmd_list_element **list)
+{
+ const char *tmp;
+ struct cmd_list_element *old;
+ struct cmd_list_element *c;
+
+ tmp = oldname;
+ old = lookup_cmd (&tmp, *list, "", 1, 1);
+
+ return add_alias_cmd (name, old, theclass, abbrev_flag, list);
+}
+
+
/* Like add_cmd but adds an element for a command prefix: a name that
should be followed by a subcommand to be looked up in another
command list. PREFIXLIST should be the address of the variable
@@ -141,6 +141,12 @@ extern struct cmd_list_element *add_alias_cmd (const char *, const char *,
enum command_class, int,
struct cmd_list_element **);
+extern struct cmd_list_element *add_alias_cmd (const char *,
+ cmd_list_element *,
+ enum command_class, int,
+ struct cmd_list_element **);
+
+
extern struct cmd_list_element *add_prefix_cmd (const char *, enum command_class,
cmd_cfunc_ftype *fun,
const char *,
@@ -3210,7 +3210,10 @@ is restored."),
set_inferior_tty_command,
show_inferior_tty_command,
&setlist, &showlist);
- add_com_alias ("tty", "set inferior-tty", class_alias, 0);
+ cmd_name = "inferior-tty";
+ c = lookup_cmd (&cmd_name, setlist, "", -1, 1);
+ gdb_assert (c != NULL);
+ add_alias_cmd ("tty", c, class_alias, 0, &cmdlist);
cmd_name = "args";
add_setshow_string_noescape_cmd (cmd_name, class_run,
@@ -21,20 +21,22 @@ if {[build_executable $testfile.exp $testfile ${srcfile} ${compile_options}] ==
return -1
}
-proc test_set_inferior_tty { } {
+proc test_set_inferior_tty { command } {
global binfile
clean_restart ${binfile}
- gdb_test_no_output "set inferior-tty hello" "set inferior-tty to hello"
+ gdb_test_no_output "$command hello" "set inferior-tty to hello"
gdb_test "show inferior-tty" \
"Terminal for future runs of program being debugged is \"hello\"." \
"show inferior-tty shows hello"
- gdb_test_no_output "set inferior-tty" "set inferior-tty to empty"
+ gdb_test_no_output "$command" "set inferior-tty to empty"
gdb_test "show inferior-tty" \
"Terminal for future runs of program being debugged is \"\"." \
"show inferior-tty shows empty"
}
-test_set_inferior_tty
+foreach_with_prefix command {"set inferior-tty" "tty"} {
+ test_set_inferior_tty $command
+}