From patchwork Wed May 10 13:10:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 20370 Received: (qmail 29008 invoked by alias); 10 May 2017 13:10:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 28904 invoked by uid 89); 10 May 2017 13:10:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.2 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1585 X-HELO: mail-pf0-f170.google.com Received: from mail-pf0-f170.google.com (HELO mail-pf0-f170.google.com) (209.85.192.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 May 2017 13:10:25 +0000 Received: by mail-pf0-f170.google.com with SMTP id v14so15734155pfd.2 for ; Wed, 10 May 2017 06:10:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=lXNbPOEIdg4ZasPof3wMypFuo6GS+vKrWzv+yJ321LY=; b=drFA6bmaFEComzOQxtBjEr5YIYb12VEIaW2TT7tzfuwtL5N5OxTb5H0FmFNFb7YlAS vP/lEsh8aV24dCWmU4yM7SqqlHz9fV/wN/EiqKpiBYz5UuBwXE/a0zcGQUitkN/CBF+L eXSQetFgVkQkYQeY/J57n17m1qBNYbyYsI70xxVKooiY1VoiNGlFB3CcN/UOVbhjtg/e usm+29/j8rjG+OfVZjaPxNazohBiIZOtRCXgHkLIRb40FFc5ANazZ82ah2CGkyLkqYrv h8mFdmxLt41HRKeE5mHbGcS5CV/tbud50t4wGBUkycD86cONbQpxU0E/op76ReJWcGkz Cw+w== X-Gm-Message-State: AODbwcB5uIdPFc1Fw2sT+evb8Op3pYOS6Klx9eEKnJjaEBPuS6ulrlMA DpZmw9PJ6CtFpiaP X-Received: by 10.98.214.90 with SMTP id r87mr6104524pfg.204.1494421826374; Wed, 10 May 2017 06:10:26 -0700 (PDT) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id 194sm5625928pgf.62.2017.05.10.06.10.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 10 May 2017 06:10:25 -0700 (PDT) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH 7/9] Get register contents by register_size instead of TYPE_LENGTH Date: Wed, 10 May 2017 14:10:11 +0100 Message-Id: <1494421813-7268-8-git-send-email-yao.qi@linaro.org> In-Reply-To: <1494421813-7268-1-git-send-email-yao.qi@linaro.org> References: <1494421813-7268-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes We should use register_size to get register contents instead of TYPE_LENGTH. gdb: 2017-04-24 Yao Qi * i387-tdep.c (i387_register_to_value): Use register_size instead of TYPE_LENGTH. * m68k-tdep.c (m68k_register_to_value): Likewise. --- gdb/i387-tdep.c | 3 ++- gdb/m68k-tdep.c | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/gdb/i387-tdep.c b/gdb/i387-tdep.c index 925f4e5..574914c 100644 --- a/gdb/i387-tdep.c +++ b/gdb/i387-tdep.c @@ -375,7 +375,8 @@ i387_register_to_value (struct frame_info *frame, int regnum, } /* Convert to TYPE. */ - if (!get_frame_register_bytes (frame, regnum, 0, TYPE_LENGTH (type), + if (!get_frame_register_bytes (frame, regnum, 0, + register_size (gdbarch, regnum), from, optimizedp, unavailablep)) return 0; diff --git a/gdb/m68k-tdep.c b/gdb/m68k-tdep.c index 585bc19..5620796 100644 --- a/gdb/m68k-tdep.c +++ b/gdb/m68k-tdep.c @@ -201,13 +201,15 @@ m68k_register_to_value (struct frame_info *frame, int regnum, struct type *type, gdb_byte *to, int *optimizedp, int *unavailablep) { + struct gdbarch *gdbarch = get_frame_arch (frame); gdb_byte from[M68K_MAX_REGISTER_SIZE]; struct type *fpreg_type = register_type (gdbarch, M68K_FP0_REGNUM); gdb_assert (TYPE_CODE (type) == TYPE_CODE_FLT); /* Convert to TYPE. */ - if (!get_frame_register_bytes (frame, regnum, 0, TYPE_LENGTH (type), + if (!get_frame_register_bytes (frame, regnum, 0, + register_size (gdbarch, regnum), from, optimizedp, unavailablep)) return 0;