From patchwork Fri Mar 24 03:01:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yousong Zhou X-Patchwork-Id: 19718 Received: (qmail 9236 invoked by alias); 24 Mar 2017 03:02:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 9217 invoked by uid 89); 24 Mar 2017 03:02:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=zhou, Zhou X-HELO: mail-pf0-f177.google.com Received: from mail-pf0-f177.google.com (HELO mail-pf0-f177.google.com) (209.85.192.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Mar 2017 03:01:59 +0000 Received: by mail-pf0-f177.google.com with SMTP id o190so1321188pfo.0 for ; Thu, 23 Mar 2017 20:02:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=VKfO7lOJ0rkkRHhkIwb10z4zJ3xkn5uqjNs7tNaQ/FE=; b=DTlh/g2m3QfpG1H4CMICBZRatNRxGU4tD5CunH1h1C0HJTA0rzoH7tHju3IdPEA0Ay HJmjfPXAgy2ywCaWePWPZ7e5scqZQb/Udrc/tAV3zruYKyapRYCQ1AmoMPNPAmL3av0K xYGqD82QpCtDyLEV3EVvdLJtYK6HsC5pV1FBkmVlpsg0/L7adjpDiw9M69pG+1MCrZgL dx72UMRgtRVaDaViD6zBKnBFdlIWDGsnruO2g1IKuACSe1BdH8gh9bIT2XYrw5EGWsmv 0IfU4Ke5lgMRRyzjUhe0g0nMRA9ItYcFtK6PX3lb56FW7m+FaeiFoL8OP3h1iYP0g3ec WvWQ== X-Gm-Message-State: AFeK/H1vBYpphvt3+zrQdD3d6d4EjKpdJU5IIXmsBY5t0FXn5IQ0Bun5Z7u8scuO5cOSKw== X-Received: by 10.98.69.141 with SMTP id n13mr6521402pfi.216.1490324518741; Thu, 23 Mar 2017 20:01:58 -0700 (PDT) Received: from titan.office.mos ([103.29.140.58]) by smtp.gmail.com with ESMTPSA id o194sm864246pfg.66.2017.03.23.20.01.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Mar 2017 20:01:57 -0700 (PDT) From: Yousong Zhou To: gdb-patches@sourceware.org Cc: Yousong Zhou Subject: [PATCH] Fix invalid sigprocmask call Date: Fri, 24 Mar 2017 11:01:59 +0800 Message-Id: <1490324519-11228-1-git-send-email-yszhou4tech@gmail.com> The POSIX document says The pthread_sigmask() and sigprocmask() functions shall fail if: [EINVAL] The value of the how argument is not equal to one of the defined values. and this is how musl-libc is currently doing. Fix the call to be safe and correct [1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_sigmask.html gdb/ChangeLog: 2017-03-24 Yousong Zhou * common/signals-state-save-restore.c (save_original_signals_state): Fix invalid sigprocmask call. --- gdb/ChangeLog | 5 +++++ gdb/common/signals-state-save-restore.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5ad7ac3..fc2c57b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-03-24 Yousong Zhou + + * common/signals-state-save-restore.c (save_original_signals_state): + Fix invalid sigprocmask call. + 2017-03-23 Simon Marchi * fbsd-tdep.c (fbsd_corefile_thread): Don't set/restore diff --git a/gdb/common/signals-state-save-restore.c b/gdb/common/signals-state-save-restore.c index d11a9ae..734335c 100644 --- a/gdb/common/signals-state-save-restore.c +++ b/gdb/common/signals-state-save-restore.c @@ -41,7 +41,7 @@ save_original_signals_state (void) int i; int res; - res = sigprocmask (0, NULL, &original_signal_mask); + res = sigprocmask (SIG_BLOCK, NULL, &original_signal_mask); if (res == -1) perror_with_name (("sigprocmask"));