From patchwork Thu Feb 23 14:13:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Machado X-Patchwork-Id: 19354 Received: (qmail 26767 invoked by alias); 23 Feb 2017 14:13:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 26756 invoked by uid 89); 23 Feb 2017 14:13:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=H*M:send, our X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Feb 2017 14:13:24 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1cgu94-0004eU-Pu from Luis_Gustavo@mentor.com for gdb-patches@sourceware.org; Thu, 23 Feb 2017 06:13:22 -0800 Received: from Opsys.world.mentorg.com (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.224.2; Thu, 23 Feb 2017 06:13:21 -0800 From: Luis Machado To: Subject: [PATCH] Restrict gdb.base/gcore-relro-pie.exp to native/linux targets Date: Thu, 23 Feb 2017 08:13:17 -0600 Message-ID: <1487859197-6269-1-git-send-email-lgustavo@codesourcery.com> MIME-Version: 1.0 X-IsSubscribed: yes This particular test doesn't work correctly on aarch64-elf for a couple reasons. First, the test is supposed to crash and bare-metal targets are not always ready to handle such exceptions like Linux does. In our case the board just keeps cycling within an ISR function. Second, core file generation is not guaranteed/not supposed to work with bare-metal targets. If it does, it may just be luck. Therefore the following patch restricts this particular test to only native and Linux targets, like some other core file tests. I see other core file tests that are not restricted to native/linux, but i don't see failures due to those. It doesn't mean they are correct in their assumptions though. I could fix those up in a single batch if it is deemed appropriate. Otherwise i'm happy with fixing only this one. gdb/testsuite/ChangeLog: 2017-02-23 Luis Machado * gdb.base/gcore-relro-pie.exp: Restrict to native/linux targets. --- gdb/testsuite/gdb.base/gcore-relro-pie.exp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gdb/testsuite/gdb.base/gcore-relro-pie.exp b/gdb/testsuite/gdb.base/gcore-relro-pie.exp index 28321fc..fd255e4 100644 --- a/gdb/testsuite/gdb.base/gcore-relro-pie.exp +++ b/gdb/testsuite/gdb.base/gcore-relro-pie.exp @@ -19,6 +19,11 @@ standard_testfile +if {![isnative] || ![istarget "*-*-linux*"]} { + untested "skipping core file test" + return 0 +} + if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug additional_flags=-fpie "ldflags=-pie -Wl,-z,relro"}]} { return -1 }