From patchwork Sun Feb 19 21:28:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 19305 Received: (qmail 117678 invoked by alias); 19 Feb 2017 21:28:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 117608 invoked by uid 89); 19 Feb 2017 21:28:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=coded X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 19 Feb 2017 21:28:49 +0000 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE8E24E4EE; Sun, 19 Feb 2017 21:28:49 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-221.ams2.redhat.com [10.36.116.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id 189852D5EB; Sun, 19 Feb 2017 21:28:48 +0000 (UTC) Subject: [PATCH v2 7/8] DWARF-5: DW_FORM_data16 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Victor Leschuk Date: Sun, 19 Feb 2017 22:28:47 +0100 Message-ID: <148753972721.4016.17786727251162049986.stgit@host1.jankratochvil.net> In-Reply-To: <148753968011.4016.6818202131640662529.stgit@host1.jankratochvil.net> References: <148753968011.4016.6818202131640662529.stgit@host1.jankratochvil.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-IsSubscribed: yes Hi, DWARF-5 has new form DW_FORM_data16. The problem is that GDB cannot pass 16-byte constant as a constant value as that would require GDB to use GCC extension __int128. Formerly such data was coded as DW_FORM_block* so GDB still decodes DW_FORM_data16 like DW_FORM_block*. Jan gdb/ChangeLog 2017-02-11 Jan Kratochvil * dwarf2read.c (skip_one_die, read_attribute_value) (dwarf2_const_value_attr, dump_die_shallow) (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes) (skip_form_bytes, attr_form_is_constant): Handle DW_FORM_data16. gdb/testsuite/ChangeLog 2017-02-11 Jan Kratochvil * gdb.dwarf2/formdata16.c: New file. * gdb.dwarf2/formdata16.exp: New file. * lib/dwarf.exp (Dwarf): Add DW_FORM_data16. --- gdb/dwarf2read.c | 25 ++++++++++ gdb/testsuite/gdb.dwarf2/formdata16.c | 22 +++++++++ gdb/testsuite/gdb.dwarf2/formdata16.exp | 77 +++++++++++++++++++++++++++++++ gdb/testsuite/lib/dwarf.exp | 4 ++ 4 files changed, 127 insertions(+), 1 deletion(-) create mode 100644 gdb/testsuite/gdb.dwarf2/formdata16.c create mode 100644 gdb/testsuite/gdb.dwarf2/formdata16.exp diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 1034d7b..7b450ee 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -7414,6 +7414,9 @@ skip_one_die (const struct die_reader_specs *reader, const gdb_byte *info_ptr, case DW_FORM_ref_sig8: info_ptr += 8; break; + case DW_FORM_data16: + info_ptr += 16; + break; case DW_FORM_string: read_direct_string (abfd, info_ptr, &bytes_read); info_ptr += bytes_read; @@ -16553,6 +16556,13 @@ read_attribute_value (const struct die_reader_specs *reader, DW_UNSND (attr) = read_8_bytes (abfd, info_ptr); info_ptr += 8; break; + case DW_FORM_data16: + blk = dwarf_alloc_block (cu); + blk->size = 16; + blk->data = read_n_bytes (abfd, info_ptr, 16); + info_ptr += 16; + DW_BLOCK (attr) = blk; + break; case DW_FORM_sec_offset: DW_UNSND (attr) = read_offset (abfd, info_ptr, &cu->header, &bytes_read); info_ptr += bytes_read; @@ -19296,6 +19306,7 @@ dwarf2_const_value_attr (const struct attribute *attr, struct type *type, case DW_FORM_block4: case DW_FORM_block: case DW_FORM_exprloc: + case DW_FORM_data16: blk = DW_BLOCK (attr); if (TYPE_LENGTH (type) != blk->size) dwarf2_const_value_length_mismatch_complaint (name, blk->size, @@ -20250,6 +20261,9 @@ dump_die_shallow (struct ui_file *f, int indent, struct die_info *die) fprintf_unfiltered (f, "expression: size %s", pulongest (DW_BLOCK (&die->attrs[i])->size)); break; + case DW_FORM_data16: + fprintf_unfiltered (f, "constant of 16 bytes"); + break; case DW_FORM_ref_addr: fprintf_unfiltered (f, "ref address: "); fputs_filtered (hex_string (DW_UNSND (&die->attrs[i])), f); @@ -20411,6 +20425,7 @@ dwarf2_get_attr_constant_value (const struct attribute *attr, int default_value) return DW_UNSND (attr); else { + /* For DW_FORM_data16 see attr_form_is_constant. */ complaint (&symfile_complaints, _("Attribute value is not a constant (%s)"), dwarf_form_name (attr->form)); @@ -20694,6 +20709,7 @@ dwarf2_fetch_constant_bytes (sect_offset offset, case DW_FORM_block4: case DW_FORM_block: case DW_FORM_exprloc: + case DW_FORM_data16: result = DW_BLOCK (attr)->data; *len = DW_BLOCK (attr)->size; break; @@ -21602,6 +21618,10 @@ skip_form_bytes (bfd *abfd, const gdb_byte *bytes, const gdb_byte *buffer_end, bytes += 8; break; + case DW_FORM_data16: + bytes += 16; + break; + case DW_FORM_string: read_direct_string (abfd, bytes, &bytes_read); bytes += bytes_read; @@ -22265,7 +22285,10 @@ attr_form_is_section_offset (const struct attribute *attr) (lineptr, loclistptr, macptr or rangelistptr). The DWARF spec says that, if an attribute's can be either a constant or one of the section offset classes, DW_FORM_data4 and DW_FORM_data8 should be - taken as section offsets, not constants. */ + taken as section offsets, not constants. + + DW_FORM_data16 is not considered as dwarf2_get_attr_constant_value + cannot handle that. */ static int attr_form_is_constant (const struct attribute *attr) diff --git a/gdb/testsuite/gdb.dwarf2/formdata16.c b/gdb/testsuite/gdb.dwarf2/formdata16.c new file mode 100644 index 0000000..956545f --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/formdata16.c @@ -0,0 +1,22 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2017 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +int +main () +{ + return 0; +} diff --git a/gdb/testsuite/gdb.dwarf2/formdata16.exp b/gdb/testsuite/gdb.dwarf2/formdata16.exp new file mode 100644 index 0000000..bba2015 --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/formdata16.exp @@ -0,0 +1,77 @@ +# Copyright 2017 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +load_lib dwarf.exp + +# This test can only be run on targets which support DWARF-2 and use gas. +if {![dwarf2_support]} { + return 0 +} + +standard_testfile .c formdata16-dw.S + +# We need to know the endianess in order +# to write some of the debugging info we'd like to generate. +if [prepare_for_testing "failed to prepare for endianness test" ${testfile} ${srcfile}] { + return -1 +} + +set endianness "little" +set test "show endian" +gdb_test_multiple $test $test { + -re "(.* )(big|little)( endian.*)\r\n$gdb_prompt $" { + set endianness $expect_out(2,string) + pass "endianness" + } +} + +set high "0x123456789abcdef0" +set low "0x0fedcba987654321" +if { $endianness == "big" } { + set pair $high,$low +} else { + set pair $low,$high +} + +# Make some DWARF for the test. +set asm_file [standard_output_file $srcfile2] +Dwarf::assemble $asm_file { + global pair + + cu { addr_size 4 } { + compile_unit {} { + declare_labels int_label + + int_label: DW_TAG_base_type { + {DW_AT_byte_size 16 DW_FORM_udata} + {DW_AT_encoding @DW_ATE_unsigned} + {DW_AT_name "__uint128"} + } + + DW_TAG_variable { + {name xxx} + {type :$int_label} + {const_value $pair DW_FORM_data16} + } + } + } +} + +if { [prepare_for_testing "failed to prepare" ${testfile} \ + [list $srcfile $asm_file] {nodebug}] } { + return -1 +} + +gdb_test "p/x xxx" " = 0x123456789abcdef00fedcba987654321" diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp index 149038c..1ccdc5d 100644 --- a/gdb/testsuite/lib/dwarf.exp +++ b/gdb/testsuite/lib/dwarf.exp @@ -481,6 +481,10 @@ namespace eval Dwarf { _op .8byte $value } + DW_FORM_data16 { + _op .8byte $value + } + DW_FORM_strp { variable _strings variable _cu_offset_size