From patchwork Fri Nov 11 14:16:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 17410 Received: (qmail 108984 invoked by alias); 11 Nov 2016 14:16:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 108968 invoked by uid 89); 11 Nov 2016 14:16:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, SPF_PASS autolearn=ham version=3.3.2 spammy=HX-HELO:sk:mail-pg, Hx-spam-relays-external:sk:mail-pg, H*r:sk:mail-pg, H*RU:sk:mail-pg X-HELO: mail-pg0-f66.google.com Received: from mail-pg0-f66.google.com (HELO mail-pg0-f66.google.com) (74.125.83.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Nov 2016 14:16:22 +0000 Received: by mail-pg0-f66.google.com with SMTP id e9so1686173pgc.1 for ; Fri, 11 Nov 2016 06:16:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=VuUmtk55jpJSf6ICg7HJaSylL/Kpo8fqM8cZsEAyjto=; b=G7CudNTwDIAFB/gc4sFDgqYjoY1VfA7SsCQN7adXylO7mKiVXL3NQcAsmgyMPuxyRn 4Wljt0gP6Dj0uyRKYhXZB0Vt9zELnBn4gXXdstZFtpqR5ZQCNssIRfNlwQnBzS6xqR3k 5fNYvaOPdS0K7e66iEquCtsYLU3m4XR1MmRgtQ72jMQr5X7W0mZ/KVmA+tLjsAaTjvp0 bK6d33CDc19QSKNi5lJeJqi0SgT8Ns1bPahxlhaeyw1w2sTrOmSuLnCXCAjBx9nzZD87 nfqXaDJTIhpb4SdSzSYEC7mlobNr/NYO7kr0I53ZXFPdBi2agKkaz8nDFFRRoPypCRY3 6+Qw== X-Gm-Message-State: ABUngveTH0HdRPiSFAZAyd1fdUn9/9l8Iok/NnRolcR/0vRf2uSpcRaDGFPQcKgW+6vPiA== X-Received: by 10.98.149.140 with SMTP id c12mr7493058pfk.100.1478873781066; Fri, 11 Nov 2016 06:16:21 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (gcc114.osuosl.org. [140.211.9.72]) by smtp.gmail.com with ESMTPSA id q90sm14401117pfk.31.2016.11.11.06.16.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 11 Nov 2016 06:16:20 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH] Don't handle unavailable/optimized-out in spu_software_single_step Date: Fri, 11 Nov 2016 14:16:16 +0000 Message-Id: <1478873776-16689-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes When we do software single step, frame is always the innermost one, so it is impossible to get unavailable/optimized-out errors. gdb: 2016-11-11 Yao Qi * spu-tdep.c (spu_software_single_step): Don't call get_frame_register_bytes, call get_frame_register_unsigned instead. --- gdb/spu-tdep.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/gdb/spu-tdep.c b/gdb/spu-tdep.c index 5494a93..073be2d 100644 --- a/gdb/spu-tdep.c +++ b/gdb/spu-tdep.c @@ -1652,24 +1652,7 @@ spu_software_single_step (struct frame_info *frame) if (reg == SPU_PC_REGNUM) target += SPUADDR_ADDR (pc); else if (reg != -1) - { - int optim, unavail; - - if (get_frame_register_bytes (frame, reg, 0, 4, buf, - &optim, &unavail)) - target += extract_unsigned_integer (buf, 4, byte_order) & -4; - else - { - if (optim) - throw_error (OPTIMIZED_OUT_ERROR, - _("Could not determine address of " - "single-step breakpoint.")); - if (unavail) - throw_error (NOT_AVAILABLE_ERROR, - _("Could not determine address of " - "single-step breakpoint.")); - } - } + target += get_frame_register_unsigned (frame, reg) & -4; target = target & lslr; if (target != next_pc)