diff mbox

arc: Fix ARI warning for printf(%p)

Message ID 1474540808-24812-1-git-send-email-Anton.Kolesov@synopsys.com
State Committed
Headers show

Commit Message

Anton Kolesov Sept. 22, 2016, 10:40 a.m. UTC
This particular warning is printed only when option -Wari is passed to
contrib/ari/gdb_ari.sh , so it slipped under my radar.

Ok to commit?

--

Replace printf ("%p") with printf ("%s", host_address_to_string ()). Printing
host address might make sense here because printed pointers can be null and
this would affect how arc_return_value behaves.
---
 gdb/arc-tdep.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Pedro Alves Sept. 22, 2016, 11:12 a.m. UTC | #1
On 09/22/2016 11:40 AM, Anton Kolesov wrote:
> This particular warning is printed only when option -Wari is passed to
> contrib/ari/gdb_ari.sh , so it slipped under my radar.
> 
> Ok to commit?

OK.  Thanks for the quick fix.

Thanks,
Pedro Alves
diff mbox

Patch

diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c
index 6048ad6..7bb93ad 100644
--- a/gdb/arc-tdep.c
+++ b/gdb/arc-tdep.c
@@ -574,8 +574,9 @@  arc_return_value (struct gdbarch *gdbarch, struct value *function,
 			  || TYPE_LENGTH (valtype) > 2 * ARC_REGISTER_SIZE);
 
   if (arc_debug)
-    debug_printf ("arc: return_value (readbuf = %p, writebuf = %p)\n",
-		  readbuf, writebuf);
+    debug_printf ("arc: return_value (readbuf = %s, writebuf = %s)\n",
+		  host_address_to_string (readbuf),
+		  host_address_to_string (writebuf));
 
   if (writebuf != NULL)
     {