diff mbox

[v2,2/2] Test GDB connection to GDBserver with no symbol files

Message ID 1460489060-17307-3-git-send-email-lgustavo@codesourcery.com
State New
Headers show

Commit Message

Luis Machado April 12, 2016, 7:24 p.m. UTC
This test exercises the scenarios where we attempt to connect GDB to GDBserver
in standard remote mode, query the symbol file path, attempt to open said
symbol file on GDB's end and fail, causing the connection to drop abruptly.

Regression-tested on x86-64/Ubuntu.

Does it look OK now?

Changes in v2:

- Addressed comments and moved the test to a proc that can be called multiple
times.
- The testcase now exercises these permutations:

* Unreadable file + empty sysroot
* Unreadable file + target: sysroot
* Removed file + empty sysroot
* Removed file + target: sysroot

With an unpatched GDB we should see this:

FAIL: gdb.server/connect-with-no-symbol-file.exp: test sysroot = "" action = permission: connection to GDBserver succeeded (the program is no longer running)
FAIL: gdb.server/connect-with-no-symbol-file.exp: test sysroot = "" action = delete: connection to GDBserver succeeded (the program is no longer running)
FAIL: gdb.server/connect-with-no-symbol-file.exp: test sysroot = "target:" action = permission: connection to GDBserver succeeded (the program is no longer running)
FAIL: gdb.server/connect-with-no-symbol-file.exp: test sysroot = "target:" action = delete: connection to GDBserver succeeded (the program is no longer running)

A patched GDB should have full passes.

gdb/testsuite/ChangeLog:

2016-04-12  Luis Machado  <lgustavo@codesourcery.com>

	* gdb.server/connect-with-no-symbol-file.c: New file.
	* gdb.server/connect-with-no-symbol-file.exp: New file.
---
 .../gdb.server/connect-with-no-symbol-file.c       |  25 +++++
 .../gdb.server/connect-with-no-symbol-file.exp     | 102 +++++++++++++++++++++
 2 files changed, 127 insertions(+)
 create mode 100644 gdb/testsuite/gdb.server/connect-with-no-symbol-file.c
 create mode 100644 gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp

Comments

Pedro Alves April 13, 2016, 3:16 p.m. UTC | #1
On 04/12/2016 08:24 PM, Luis Machado wrote:

> - Addressed comments and moved the test to a proc that can be called multiple
> times.
> - The testcase now exercises these permutations:
> 
> * Unreadable file + empty sysroot
> * Unreadable file + target: sysroot
> * Removed file + empty sysroot
> * Removed file + target: sysroot
> 
> With an unpatched GDB we should see this:
> 
> FAIL: gdb.server/connect-with-no-symbol-file.exp: test sysroot = "" action = permission: connection to GDBserver succeeded (the program is no longer running)
> FAIL: gdb.server/connect-with-no-symbol-file.exp: test sysroot = "" action = delete: connection to GDBserver succeeded (the program is no longer running)
> FAIL: gdb.server/connect-with-no-symbol-file.exp: test sysroot = "target:" action = permission: connection to GDBserver succeeded (the program is no longer running)
> FAIL: gdb.server/connect-with-no-symbol-file.exp: test sysroot = "target:" action = delete: connection to GDBserver succeeded (the program is no longer running)
> 
> A patched GDB should have full passes.

Excellent.  LGTM.  A couple minor comments below.

> +
> +#include <stdio.h>
> +
> +int
> +main (int argc, char **argv)
> +{
> +  printf ("Hello world!\n");
> +  return 0;
> +}

No need for stdio.h / printf, right?  As a general principle,
if the test doesn't need those, best just not to compile
them in either.

> +# Make sure we have the original symbol file in a safe place to copy from.
> +gdb_remote_download host $binfile $binfile.bak
> +
> +# Run the test with different permutations.
> +foreach sysroot $sysroots {
> +    foreach action $file_actions {
> +	with_test_prefix "test sysroot = \"$sysroot\" action = $action" {
> +	    connect_no_symbol_file $sysroot $action
> +	}
> +    }
> +}
> 

Note you can simplify using foreach_with_prefix.  No need
for the separate variables then:

foreach_with_prefix sysroot {"" "target:"} {
    foreach_with_prefix action {"permission" "delete"} {
       connect_no_symbol_file $sysroot $action
    }
}

Thanks,
Pedro Alves
Luis Machado April 13, 2016, 3:24 p.m. UTC | #2
On 04/13/2016 10:16 AM, Pedro Alves wrote:
> On 04/12/2016 08:24 PM, Luis Machado wrote:
>
>> - Addressed comments and moved the test to a proc that can be called multiple
>> times.
>> - The testcase now exercises these permutations:
>>
>> * Unreadable file + empty sysroot
>> * Unreadable file + target: sysroot
>> * Removed file + empty sysroot
>> * Removed file + target: sysroot
>>
>> With an unpatched GDB we should see this:
>>
>> FAIL: gdb.server/connect-with-no-symbol-file.exp: test sysroot = "" action = permission: connection to GDBserver succeeded (the program is no longer running)
>> FAIL: gdb.server/connect-with-no-symbol-file.exp: test sysroot = "" action = delete: connection to GDBserver succeeded (the program is no longer running)
>> FAIL: gdb.server/connect-with-no-symbol-file.exp: test sysroot = "target:" action = permission: connection to GDBserver succeeded (the program is no longer running)
>> FAIL: gdb.server/connect-with-no-symbol-file.exp: test sysroot = "target:" action = delete: connection to GDBserver succeeded (the program is no longer running)
>>
>> A patched GDB should have full passes.
>
> Excellent.  LGTM.  A couple minor comments below.
>
>> +
>> +#include <stdio.h>
>> +
>> +int
>> +main (int argc, char **argv)
>> +{
>> +  printf ("Hello world!\n");
>> +  return 0;
>> +}
>
> No need for stdio.h / printf, right?  As a general principle,
> if the test doesn't need those, best just not to compile
> them in either.
>

Nope. Fixed.

>> +# Make sure we have the original symbol file in a safe place to copy from.
>> +gdb_remote_download host $binfile $binfile.bak
>> +
>> +# Run the test with different permutations.
>> +foreach sysroot $sysroots {
>> +    foreach action $file_actions {
>> +	with_test_prefix "test sysroot = \"$sysroot\" action = $action" {
>> +	    connect_no_symbol_file $sysroot $action
>> +	}
>> +    }
>> +}
>>
>
> Note you can simplify using foreach_with_prefix.  No need
> for the separate variables then:
>
> foreach_with_prefix sysroot {"" "target:"} {
>      foreach_with_prefix action {"permission" "delete"} {
>         connect_no_symbol_file $sysroot $action
>      }
> }
>

Ah, handy! Thanks for the suggestion.

> Thanks,
> Pedro Alves
>
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.c b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.c
new file mode 100644
index 0000000..e5e4acc
--- /dev/null
+++ b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.c
@@ -0,0 +1,25 @@ 
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2016 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include <stdio.h>
+
+int
+main (int argc, char **argv)
+{
+  printf ("Hello world!\n");
+  return 0;
+}
diff --git a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp
new file mode 100644
index 0000000..2d171b6
--- /dev/null
+++ b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp
@@ -0,0 +1,102 @@ 
+# This testcase is part of GDB, the GNU debugger.
+
+# Copyright 2016 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Test GDB's ability to properly connect to GDBserver with no pre-opened
+# symbol file.  If GDB is buggy, it will drop the connection when
+# it attempts to open the symbol file indicated by GDBserver and fails.
+#
+# This test is only meaningful for standard remote connections.
+
+load_lib gdbserver-support.exp
+
+standard_testfile
+
+if { [skip_gdbserver_tests] } {
+    return 0
+}
+
+if { [prepare_for_testing $testfile.exp $testfile $srcfile debug] } {
+    return -1
+}
+
+# Test connecting GDB to GDBserver without loading a symbol file.
+#
+# SYSROOT is the desired sysroot string
+#
+# ACTION is the action to perform to the symbol file on the target.
+# It can be either "permission" to deny access to the file or "delete"
+# to remove the file.
+#
+proc connect_no_symbol_file { sysroot action } {
+    global binfile
+
+    with_test_prefix "setup" {
+	# Copy the symbol file to the target.
+	gdb_remote_download target $binfile.bak $binfile 
+
+	# Make sure we're disconnected, in case we're testing with an
+	# extended-remote board, therefore already connected.
+	gdb_test "disconnect" ".*" "disconnect"
+
+	# Discard any symbol files that we have opened.
+	gdb_test "file" ".*" "discard symbol table" \
+	    {Discard symbol table from `.*'\? \(y or n\) } "y"
+
+	# Set sysroot to something non-target and possibly also invalid so that
+	# GDB is unable to open the symbol file.
+	gdb_test_no_output "set sysroot $sysroot" "adjust sysroot"
+
+	set target_exec [gdbserver_download_current_prog]
+
+	# Start GDBserver.
+	set res [gdbserver_start "" $target_exec]
+
+	set gdbserver_protocol [lindex $res 0]
+	set gdbserver_gdbport [lindex $res 1]
+
+	# Perform test actions to the symbol file on the target.
+	if { $action == "delete" } then {
+	  remote_file target delete $binfile
+	} elseif { $action == "permission" } {
+	  remote_spawn target "chmod 000 $binfile"
+	}
+       
+	# Connect to GDBserver.
+	gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport
+    }
+
+    # Check if GDB succeeded connecting to GDBserver by attempting to detach
+    # from the process.
+    gdb_test "detach" \
+	".*Detaching from program: , process.*Ending remote debugging.*" \
+	"connection to GDBserver succeeded"
+}
+
+set sysroots {"" "target:"}
+set file_actions {"permission" "delete"}
+
+# Make sure we have the original symbol file in a safe place to copy from.
+gdb_remote_download host $binfile $binfile.bak
+
+# Run the test with different permutations.
+foreach sysroot $sysroots {
+    foreach action $file_actions {
+	with_test_prefix "test sysroot = \"$sysroot\" action = $action" {
+	    connect_no_symbol_file $sysroot $action
+	}
+    }
+}