From patchwork Wed Apr 6 03:15:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 11645 Received: (qmail 47046 invoked by alias); 6 Apr 2016 03:15:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 46890 invoked by uid 89); 6 Apr 2016 03:15:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00, SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:sk:cable-1, H*r:sk:cable-1, H*RU:sk:cable-1 X-HELO: smtp.electronicbox.net Received: from smtp.electronicbox.net (HELO smtp.electronicbox.net) (96.127.255.82) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 06 Apr 2016 03:15:48 +0000 Received: from localhost.localdomain (cable-192.222.137.139.electronicbox.net [192.222.137.139]) by smtp.electronicbox.net (Postfix) with ESMTP id 1EAF3440E81; Tue, 5 Apr 2016 23:15:46 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 4/4] Fix solib-display.exp remote check Date: Tue, 5 Apr 2016 23:15:43 -0400 Message-Id: <1459912543-15328-4-git-send-email-simon.marchi@polymtl.ca> In-Reply-To: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca> References: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca> This test currently uses [is_remote target] to check if the test is supported. This is not quite correct, as you could run the test with an extended-remote gdbserver configuration and a remote target [1]. The test uses "run", which makes it inappropriate for stub-like targets, so that's what it should check instead. [1] I managed to do it, but the current testsuite code does not make it easy to make such a board file... gdb/testsuite/ChangeLog: * gdb.base/solib-display.exp: Don't check for [is_remote target], check for $use_gdb_stub instead. --- gdb/testsuite/gdb.base/solib-display.exp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/solib-display.exp b/gdb/testsuite/gdb.base/solib-display.exp index 7f65617..42ad08c 100644 --- a/gdb/testsuite/gdb.base/solib-display.exp +++ b/gdb/testsuite/gdb.base/solib-display.exp @@ -28,7 +28,7 @@ # (and thus aren't affected by shared library unloading) are not # disabled prematurely. -if { [skip_shlib_tests] || [is_remote target] } { +if { [skip_shlib_tests] } { return 0 } @@ -72,6 +72,11 @@ foreach libsepdebug {NO IN SEP} { with_test_prefix "$libsepdebug" { clean_restart $executable + # This test uses run, so it's pointless to test on stub targets. + if $use_gdb_stub { + return 0 + } + if ![runto_main] then { fail "Can't run to main" return 0