From patchwork Wed Mar 2 16:21:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marcin_Ko=C5=9Bcielnicki?= X-Patchwork-Id: 11167 Received: (qmail 3405 invoked by alias); 2 Mar 2016 16:21:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 3396 invoked by uid 89); 2 Mar 2016 16:21:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=bag, agent, Tell, paper X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Mar 2016 16:21:09 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 85BF83FE29; Wed, 2 Mar 2016 17:22:02 +0100 (CET) Received: by hogfather.0x04.net (Postfix, from userid 1000) id E60E15800FF; Wed, 2 Mar 2016 17:21:05 +0100 (CET) From: =?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?= To: qiyaoltc@gmail.com Cc: palves@redhat.com, gdb-patches@sourceware.org, antoine.tremblay@ericsson.com, =?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?= Subject: [PATCH] [OBV] gdbserver: Only write ipa_tdesc_idx if agent is actually loaded. Date: Wed, 2 Mar 2016 17:21:05 +0100 Message-Id: <1456935665-14939-1-git-send-email-koriakin@0x04.net> In-Reply-To: <86egbsanh6.fsf@gmail.com> References: <86egbsanh6.fsf@gmail.com> MIME-Version: 1.0 X-IsSubscribed: yes Fixes rather embarassing gdb.trace regressions. gdb/gdbserver/ChangeLog: * tracepoint.c (cmd_qtstart): Only set ipa_tdesc_idx if agent is actually loaded. --- Whoops, now that's a brown paper bag bug. Pushed as obvious. gdb/gdbserver/ChangeLog | 5 +++++ gdb/gdbserver/tracepoint.c | 11 +++++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 4c8df3f..40150d7 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,8 @@ +2016-03-02 Marcin Kościelnicki + + * tracepoint.c (cmd_qtstart): Only set ipa_tdesc_idx if agent + is actually loaded. + 2016-02-25 Marcin Kościelnicki * linux-s390-low.c (s390_num_regs_3264): Define on 31-bit too. diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c index dbd0b46..383fb71 100644 --- a/gdb/gdbserver/tracepoint.c +++ b/gdb/gdbserver/tracepoint.c @@ -3214,10 +3214,13 @@ cmd_qtstart (char *packet) *packet = '\0'; - /* Tell IPA about the correct tdesc. */ - if (write_inferior_integer (ipa_sym_addrs.addr_ipa_tdesc_idx, - target_get_ipa_tdesc_idx ())) - error ("Error setting ipa_tdesc_idx variable in lib"); + if (agent_loaded_p ()) + { + /* Tell IPA about the correct tdesc. */ + if (write_inferior_integer (ipa_sym_addrs.addr_ipa_tdesc_idx, + target_get_ipa_tdesc_idx ())) + error ("Error setting ipa_tdesc_idx variable in lib"); + } /* Start out empty. */ if (agent_loaded_p ())