From patchwork Mon Feb 29 15:57:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 11140 Received: (qmail 27005 invoked by alias); 29 Feb 2016 15:57:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 26977 invoked by uid 89); 29 Feb 2016 15:57:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=*entry, finishes X-HELO: mail-pa0-f50.google.com Received: from mail-pa0-f50.google.com (HELO mail-pa0-f50.google.com) (209.85.220.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 29 Feb 2016 15:57:40 +0000 Received: by mail-pa0-f50.google.com with SMTP id fy10so93961147pac.1 for ; Mon, 29 Feb 2016 07:57:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=eRV6LiyH1g9xjqSuVJ96C+NiI2Q5fsFSrk++6XKWhf4=; b=lNMDAoSgn6OL3IURPerCGpOBLynvkLoMUlJVtwUdYCtR3Wwtt81pwAioOIb9wp3H/+ TH5T4U31kuWbBIt6L4t7L/eIItym3usjFbDRcmjRiwqk+ld3hFLPa9m7ptX2jw8mEow1 uzpEoAMA8cC4ADezCD2wqZFOsg/4wGD/t4LfKwF2Vnx6/25HzfLswXDjl9gxqYBKqAaA FZzsumAfMdinzNYaQnQ8Bv27tsDLdNOJR8NdI3jxkqHAJLeXAt6vd8dTkcp4iPvZUkox jab4oOykopjE4qFPCzsodNKg2TsDM7Z9nI/APNYo2zu2ubdPSw+FermB9RQMkOzQ4cKD XBQQ== X-Gm-Message-State: AD7BkJJ7BqzbQbnovnls96jIuBFLQHDABcvkrRorh4Ukgack3dx91lf8/yVoXEEO+gxYrQ== X-Received: by 10.66.100.228 with SMTP id fb4mr22688023pab.84.1456761458303; Mon, 29 Feb 2016 07:57:38 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id fn3sm39170017pab.20.2016.02.29.07.57.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 29 Feb 2016 07:57:37 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH] Update comments to start_step_over Date: Mon, 29 Feb 2016 15:57:27 +0000 Message-Id: <1456761447-26021-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes I happen to see that comments to start_step_over isn't in sync with code, so this patch is to update the comments. gdb/gdbserver: 2016-02-29 Yao Qi * linux-low.c: Update comments to start_step_over. --- gdb/gdbserver/linux-low.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index 983b2d1..2eb3efa 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -4629,18 +4629,10 @@ need_step_over_p (struct inferior_list_entry *entry, void *dummy) of the way. If we let other threads run while we do that, they may pass by the breakpoint location and miss hitting it. To avoid that, a step-over momentarily stops all threads while LWP is - single-stepped while the breakpoint is temporarily uninserted from - the inferior. When the single-step finishes, we reinsert the - breakpoint, and let all threads that are supposed to be running, - run again. - - On targets that don't support hardware single-step, we don't - currently support full software single-stepping. Instead, we only - support stepping over the thread event breakpoint, by asking the - low target where to place a reinsert breakpoint. Since this - routine assumes the breakpoint being stepped over is a thread event - breakpoint, it usually assumes the return address of the current - function is a good enough place to set the reinsert breakpoint. */ + single-stepped by either hardware or software while the breakpoint + is temporarily uninserted from the inferior. When the single-step + finishes, we reinsert the breakpoint, and let all threads that are + supposed to be running, run again. */ static int start_step_over (struct lwp_info *lwp)