From patchwork Wed Feb 24 14:26:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Machado X-Patchwork-Id: 11043 Received: (qmail 7112 invoked by alias); 24 Feb 2016 14:27:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 7051 invoked by uid 89); 24 Feb 2016 14:27:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Discard, Connect, gdb.server, UD:gdb.server X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Feb 2016 14:27:17 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1aYaPK-00068p-MO from Luis_Gustavo@mentor.com ; Wed, 24 Feb 2016 06:27:14 -0800 Received: from opsys.world.mentorg.com (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.224.2; Wed, 24 Feb 2016 06:27:12 -0800 From: Luis Machado To: CC: , Subject: [PATCH 2/2] Test GDB connection to GDBserver with no symbol files Date: Wed, 24 Feb 2016 11:26:54 -0300 Message-ID: <1456324014-17961-2-git-send-email-lgustavo@codesourcery.com> In-Reply-To: <1456324014-17961-1-git-send-email-lgustavo@codesourcery.com> References: <1456324014-17961-1-git-send-email-lgustavo@codesourcery.com> MIME-Version: 1.0 X-IsSubscribed: yes This test exercises the scenario where we attempt to connect GDB to GDBserver in standard remote mode, query the symbol file path, attempt to open said symbol file on GDB's end and fail, causing the connection to drop abruptly. I wish i could make all the other PASSes go away and only keep the last test, as that is the most important one. As it is, we get full passes for a patched GDB and 3 PASS/1 FAIL for an unpatched GDB. Regression-tested on x86-64/Ubuntu. gdb/testsuite/ChangeLog: 2016-02-24 Luis Machado * gdb.server/attach-with-no-symbol.c: New file. * gdb.server/attach-with-no-symbol.exp: New file. --- gdb/testsuite/gdb.server/attach-with-no-symbol.c | 25 ++++++++ gdb/testsuite/gdb.server/attach-with-no-symbol.exp | 68 ++++++++++++++++++++++ 2 files changed, 93 insertions(+) create mode 100644 gdb/testsuite/gdb.server/attach-with-no-symbol.c create mode 100644 gdb/testsuite/gdb.server/attach-with-no-symbol.exp diff --git a/gdb/testsuite/gdb.server/attach-with-no-symbol.c b/gdb/testsuite/gdb.server/attach-with-no-symbol.c new file mode 100644 index 0000000..e5e4acc --- /dev/null +++ b/gdb/testsuite/gdb.server/attach-with-no-symbol.c @@ -0,0 +1,25 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2016 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include + +int +main (int argc, char **argv) +{ + printf ("Hello world!\n"); + return 0; +} diff --git a/gdb/testsuite/gdb.server/attach-with-no-symbol.exp b/gdb/testsuite/gdb.server/attach-with-no-symbol.exp new file mode 100644 index 0000000..a6d0d85 --- /dev/null +++ b/gdb/testsuite/gdb.server/attach-with-no-symbol.exp @@ -0,0 +1,68 @@ +# This testcase is part of GDB, the GNU debugger. + +# Copyright 2016 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test GDB's ability to properly connect to GDBserver with no pre-opened +# symbol file. If GDB is buggy, it will drop the connection when +# it attempts to open the symbol file indicated by GDBserver and fails. +# +# This test is only meaningful for standard remote connections. + +load_lib gdbserver-support.exp + +standard_testfile + +if { [skip_gdbserver_tests] } { + return 0 +} + +if { [prepare_for_testing $testfile.exp $testfile $srcfile debug] } { + return -1 +} + +# Make sure we're disconnected, in case we're testing with an +# extended-remote board, therefore already connected. +gdb_test "disconnect" ".*" + +# Discard any symbol files that we have opened. +gdb_test "file" ".*" "Discard symbol table" \ + {Discard symbol table from `.*'\? \(y or n\) } "y" + +set target_exec [gdbserver_download_current_prog] + +# Start GDBserver. +set res [gdbserver_start "" $target_exec] + +set gdbserver_protocol [lindex $res 0] +set gdbserver_gdbport [lindex $res 1] + +# Prevent access to the symbol file. +if {[file exists $binfile]} { + system "chmod 000 $binfile" +} + +# Set sysroot to something non-target and possibly also invalid so that GDB is +# unable to open the symbol file. +gdb_test_no_output "set sysroot" "Disable downloading of symbol files" + +# Connect to GDBserver. +gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport + +# Check if GDB succeeded connecting to GDBserver by attempting to detach from +# the process. +gdb_test "detach" \ + ".*Detaching from program: , process.*Ending remote debugging.*" \ + "Connection to GDBserver succeeded"