From patchwork Thu Feb 18 10:59:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 10888 Received: (qmail 76668 invoked by alias); 18 Feb 2016 10:59:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 76645 invoked by uid 89); 18 Feb 2016 10:59:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=detach-on-fork, detachonfork, 836, UD:gdb.threads X-HELO: mail-pf0-f172.google.com Received: from mail-pf0-f172.google.com (HELO mail-pf0-f172.google.com) (209.85.192.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 18 Feb 2016 10:59:09 +0000 Received: by mail-pf0-f172.google.com with SMTP id e127so29501011pfe.3 for ; Thu, 18 Feb 2016 02:59:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=EO6mNvG9ojL362JorlxhbuUxTJxp8sff+xGYoGeIqjs=; b=JWjiBmwOz32pkgb0bOwdkqYdOtsvK3XzU/RuuCmEjUdaKzbiR+Zu+qigWIxQM0BzTp S2J2gxXMir3ucM5nxZC9au/NoaqfD/1cx3ZXzGeoa5NKscTmzS/d5227CEwNrxmllQiX /RGsFbAk4WUFVB97IAySMVScmFBBOb4lN4wuaVpP2O5hqF/dEP/GeWgJrpGbitrfwyDH kXdcosYmmJl8bWQeMOAY15Bkeyka5IPNwcEriTfmEnOT4quEoPeGujw4pj+QONJD7wbT eL/0cX4mdeSEm/F1a9KOJnvWJQPoLQr7WMExS9TGnWS8X58cW7lfxT9ckMYiTJbrHFeR Db5Q== X-Gm-Message-State: AG10YORnKp53pVldHfl4yizf5NxOplHKDJb3W9uS++YXe/cMayTYQZlDk4muBebINzDJOw== X-Received: by 10.98.10.86 with SMTP id s83mr9073118pfi.85.1455793148321; Thu, 18 Feb 2016 02:59:08 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id l62sm9433409pfj.7.2016.02.18.02.59.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 Feb 2016 02:59:07 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH] Set breakpoint condition-evaluation in forking-threads-plus-breakpoint.exp Date: Thu, 18 Feb 2016 10:59:03 +0000 Message-Id: <1455793143-25234-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes Proc do_test in forking-threads-plus-breakpoint.exp has an argument cond_bp_target, but the test doesn't use it to set "breakpoint condition-evaluation", which is an oversight in the test. This patch fixes it by setting "breakpoint condition-evaluation" per $cond_bp_target. gdb/testsuite: 2016-02-18 Yao Qi * gdb.threads/forking-threads-plus-breakpoint.exp (do_test): Set "set breakpoint condition-evaluation" per $cond_bp_target. --- .../gdb.threads/forking-threads-plus-breakpoint.exp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp b/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp index ff3ca9a..3d8b308 100644 --- a/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp +++ b/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp @@ -83,6 +83,21 @@ proc do_test { cond_bp_target detach_on_fork displaced } { return 0 } + if {$cond_bp_target} { + set test "set breakpoint condition-evaluation target" + gdb_test_multiple $test $test { + -re "warning: Target does not support breakpoint condition evaluation.\r\nUsing host evaluation mode instead.\r\n$gdb_prompt $" { + # Target doesn't support breakpoint condition + # evaluation on its side. Skip the test. + return 0 + } + -re "^$test\r\n$gdb_prompt $" { + } + } + } else { + gdb_test_no_output "set breakpoint condition-evaluation host" + } + gdb_test_no_output "set detach-on-fork $detach_on_fork" gdb_test_no_output "set displaced $displaced"