From patchwork Thu Dec 10 16:31:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 9962 Received: (qmail 47722 invoked by alias); 10 Dec 2015 16:31:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 47700 invoked by uid 89); 10 Dec 2015 16:31:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Dec 2015 16:31:14 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 54C508E748 for ; Thu, 10 Dec 2015 16:31:13 +0000 (UTC) Received: from brno.lan (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBAGVCp5005704 for ; Thu, 10 Dec 2015 11:31:12 -0500 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [ob/pushed] Stop using nowarnings in gdb/testsuite/gdb.multi/ Date: Thu, 10 Dec 2015 16:31:11 +0000 Message-Id: <1449765071-32101-1-git-send-email-palves@redhat.com> Several of the gdb.multi tests use the "nowarnings" option to suppress warnings. The warnings in question all come from missing headers, like e.g.: src/gdb/testsuite/gdb.multi/multi-arch-exec.c:28:3: warning: incompatible implicit declaration of built-in function 'exit' [enabled by default] exit (1); ^ There's no point in trying to avoid to include standard headers. In gdb.base/hangout.c's case, it's even dangerous, as that file calls printf. In order to compile a call to a variatic function correctly, a declaration must be visible. gdb/testsuite/ChangeLog: 2015-12-10 Pedro Alves * gdb.multi/base.exp: Don't use nowarnings. * gdb.multi/bkpt-multi-exec.exp: Don't use nowarnings. * gdb.multi/hangout.c: Include stdio.h. * gdb.multi/hello.c: Include stdlib.h. * gdb.multi/multi-arch-exec.c: Include stdlib.h. * gdb.multi/multi-arch-exec.exp: Don't use nowarnings. * gdb.multi/multi-arch.exp: Don't use nowarnings. --- gdb/testsuite/ChangeLog | 10 ++++++++++ gdb/testsuite/gdb.multi/base.exp | 6 +++--- gdb/testsuite/gdb.multi/bkpt-multi-exec.exp | 2 +- gdb/testsuite/gdb.multi/hangout.c | 2 ++ gdb/testsuite/gdb.multi/hello.c | 2 ++ gdb/testsuite/gdb.multi/multi-arch-exec.c | 1 + gdb/testsuite/gdb.multi/multi-arch-exec.exp | 4 ++-- gdb/testsuite/gdb.multi/multi-arch.exp | 4 ++-- 8 files changed, 23 insertions(+), 8 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index bad4382..f0e026d 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,13 @@ +2015-12-10 Pedro Alves + + * gdb.multi/base.exp: Don't use nowarnings. + * gdb.multi/bkpt-multi-exec.exp: Don't use nowarnings. + * gdb.multi/hangout.c: Include stdio.h. + * gdb.multi/hello.c: Include stdlib.h. + * gdb.multi/multi-arch-exec.c: Include stdlib.h. + * gdb.multi/multi-arch-exec.exp: Don't use nowarnings. + * gdb.multi/multi-arch.exp: Don't use nowarnings. + 2015-12-10 Andrew Burgess * gdb.dwarf2/dw2-ranges-base.c: New file. diff --git a/gdb/testsuite/gdb.multi/base.exp b/gdb/testsuite/gdb.multi/base.exp index 78b913c..b58e49a 100644 --- a/gdb/testsuite/gdb.multi/base.exp +++ b/gdb/testsuite/gdb.multi/base.exp @@ -30,15 +30,15 @@ set exec3 "goodbye" set srcfile3 ${exec3}.c set binfile3 [standard_output_file ${exec3}] -if { [build_executable ${testfile}.exp ${exec1} "${srcfile1}" {debug nowarnings}] == -1 } { +if { [build_executable ${testfile}.exp ${exec1} "${srcfile1}" {debug}] == -1 } { return -1 } -if { [build_executable ${testfile}.exp ${exec2} "${srcfile2}" {debug nowarnings}] == -1} { +if { [build_executable ${testfile}.exp ${exec2} "${srcfile2}" {debug}] == -1} { return -1 } -if { [build_executable ${testfile}.exp ${exec3} "${srcfile3}" {debug nowarnings}] == -1 } { +if { [build_executable ${testfile}.exp ${exec3} "${srcfile3}" {debug}] == -1 } { return -1 } diff --git a/gdb/testsuite/gdb.multi/bkpt-multi-exec.exp b/gdb/testsuite/gdb.multi/bkpt-multi-exec.exp index 4f572bb..e66c1ba 100644 --- a/gdb/testsuite/gdb.multi/bkpt-multi-exec.exp +++ b/gdb/testsuite/gdb.multi/bkpt-multi-exec.exp @@ -33,7 +33,7 @@ set exec2 "crashme" set srcfile2 ${exec2}.c set binfile2 [standard_output_file ${exec2}] -set compile_options {debug nowarnings} +set compile_options {debug} set dirname [relative_filename [pwd] [file dirname $binfile1]] lappend compile_options "additional_flags=-DBASEDIR=\"$dirname\"" diff --git a/gdb/testsuite/gdb.multi/hangout.c b/gdb/testsuite/gdb.multi/hangout.c index c67b621..0ac2650 100644 --- a/gdb/testsuite/gdb.multi/hangout.c +++ b/gdb/testsuite/gdb.multi/hangout.c @@ -15,6 +15,8 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ +#include + main(int argc, char *argv[]) { int i; diff --git a/gdb/testsuite/gdb.multi/hello.c b/gdb/testsuite/gdb.multi/hello.c index 0233c96..a7c11f7 100644 --- a/gdb/testsuite/gdb.multi/hello.c +++ b/gdb/testsuite/gdb.multi/hello.c @@ -15,6 +15,8 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ +#include + short hglob = 1; short glob = 92; diff --git a/gdb/testsuite/gdb.multi/multi-arch-exec.c b/gdb/testsuite/gdb.multi/multi-arch-exec.c index 4c8dfaa..918af4b 100644 --- a/gdb/testsuite/gdb.multi/multi-arch-exec.c +++ b/gdb/testsuite/gdb.multi/multi-arch-exec.c @@ -15,6 +15,7 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ +#include #include #include diff --git a/gdb/testsuite/gdb.multi/multi-arch-exec.exp b/gdb/testsuite/gdb.multi/multi-arch-exec.exp index 67020d9..a54f408 100644 --- a/gdb/testsuite/gdb.multi/multi-arch-exec.exp +++ b/gdb/testsuite/gdb.multi/multi-arch-exec.exp @@ -54,13 +54,13 @@ if [istarget "s390*-*-*"] { set dirname [relative_filename [pwd] [file dirname $binfile2]] if { [prepare_for_testing ${testfile}.exp ${exec1} "${srcfile1}" \ - [list debug nowarnings \ + [list debug \ additional_flags=${march1} \ additional_flags=-DBASEDIR=\"$dirname\"]] } { return -1 } -set options [list debug nowarnings] +set options [list debug] if { [istarget "aarch64*-*-*"] } { if {[info exists ARM_CC_FOR_TARGET]} { diff --git a/gdb/testsuite/gdb.multi/multi-arch.exp b/gdb/testsuite/gdb.multi/multi-arch.exp index 70d0a09..986e663 100644 --- a/gdb/testsuite/gdb.multi/multi-arch.exp +++ b/gdb/testsuite/gdb.multi/multi-arch.exp @@ -53,11 +53,11 @@ if [istarget "s390*-*-*"] { } if { [prepare_for_testing ${testfile}.exp ${exec1} "${srcfile1}" \ - [list debug nowarnings additional_flags=${march1}]] } { + [list debug additional_flags=${march1}]] } { return -1 } -set options [list debug nowarnings] +set options [list debug] if [istarget "aarch64*-*-*"] { if {[info exists ARM_CC_FOR_TARGET]} {