From patchwork Fri Nov 13 09:59:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 9658 Received: (qmail 42496 invoked by alias); 13 Nov 2015 09:59:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 42374 invoked by uid 89); 13 Nov 2015 09:59:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS, UNSUBSCRIBE_BODY autolearn=no version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 13 Nov 2015 09:59:15 +0000 Received: by pabfh17 with SMTP id fh17so96042304pab.0 for ; Fri, 13 Nov 2015 01:59:13 -0800 (PST) X-Received: by 10.68.179.228 with SMTP id dj4mr30557011pbc.112.1447408753513; Fri, 13 Nov 2015 01:59:13 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (gcc2-power8.osuosl.org. [140.211.9.43]) by smtp.gmail.com with ESMTPSA id fe6sm8866821pab.40.2015.11.13.01.59.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 13 Nov 2015 01:59:12 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH] Use value_contents instead of value_contents_writeable Date: Fri, 13 Nov 2015 09:59:08 +0000 Message-Id: <1447408748-11179-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes Both aarch64_push_dummy_call and bfin_push_dummy_call only use value contents but then never write to them, so that we can use value_contents instead. Regression tested on aarch64-linux only. No bfin box to test. gdb: 2015-11-13 Yao Qi * aarch64-tdep.c (aarch64_push_dummy_call): Call value_contents instead of value_contents_writeable. * bfin-tdep.c (bfin_push_dummy_call): Likewise. --- gdb/aarch64-tdep.c | 2 +- gdb/bfin-tdep.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index bc282e9..553a420 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -1300,7 +1300,7 @@ aarch64_push_dummy_call (struct gdbarch *gdbarch, struct value *function, check_typedef (value_type (field)); pass_in_v_or_stack (gdbarch, regcache, &info, field_type, - value_contents_writeable (field)); + value_contents (field)); } } else diff --git a/gdb/bfin-tdep.c b/gdb/bfin-tdep.c index 1d48225..54936cc 100644 --- a/gdb/bfin-tdep.c +++ b/gdb/bfin-tdep.c @@ -531,7 +531,7 @@ bfin_push_dummy_call (struct gdbarch *gdbarch, int container_len = (TYPE_LENGTH (value_type) + 3) & ~3; sp -= container_len; - write_memory (sp, value_contents_writeable (args[i]), container_len); + write_memory (sp, value_contents (args[i]), container_len); } /* Initialize R0, R1, and R2 to the first 3 words of parameters. */