diff mbox

[c++,2/6] solib-spu: Add gdb_byte* cast

Message ID 1444624329-4828-2-git-send-email-simon.marchi@polymtl.ca
State New, archived
Headers

Commit Message

Simon Marchi Oct. 12, 2015, 4:32 a.m. UTC 
  Fixes this error:

/home/simark/src/binutils-gdb/gdb/solib-spu.c: In function ‘file_ptr spu_bfd_iovec_pread(bfd*, void*, void*, file_ptr, file_ptr)’:
/home/simark/src/binutils-gdb/gdb/solib-spu.c:299:55: error: invalid conversion from ‘void*’ to ‘gdb_byte* {aka unsigned char*}’ [-fpermissive]
   ret = target_read_memory (addr + offset, buf, nbytes);
                                                       ^
In file included from /home/simark/src/binutils-gdb/gdb/target.h:65:0,
                 from /home/simark/src/binutils-gdb/gdb/exec.h:23,
                 from /home/simark/src/binutils-gdb/gdb/gdbcore.h:29,
                 from /home/simark/src/binutils-gdb/gdb/solib-spu.c:23:
/home/simark/src/binutils-gdb/gdb/target/target.h:35:12: note:   initializing argument 2 of ‘int target_read_memory(CORE_ADDR, gdb_byte*, ssize_t)’
 extern int target_read_memory (CORE_ADDR memaddr, gdb_byte *myaddr,

gdb/ChangeLog:

	* solib-spu.c (spu_bfd_iovec_pread): Add (gdb_byte *) cast.
---
 gdb/solib-spu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pedro Alves Oct. 22, 2015, 10:57 a.m. UTC | #1 
On 10/12/2015 05:32 AM, Simon Marchi wrote:
> Fixes this error:
> 
> /home/simark/src/binutils-gdb/gdb/solib-spu.c: In function ‘file_ptr spu_bfd_iovec_pread(bfd*, void*, void*, file_ptr, file_ptr)’:
> /home/simark/src/binutils-gdb/gdb/solib-spu.c:299:55: error: invalid conversion from ‘void*’ to ‘gdb_byte* {aka unsigned char*}’ [-fpermissive]
>    ret = target_read_memory (addr + offset, buf, nbytes);
>                                                        ^
> In file included from /home/simark/src/binutils-gdb/gdb/target.h:65:0,
>                  from /home/simark/src/binutils-gdb/gdb/exec.h:23,
>                  from /home/simark/src/binutils-gdb/gdb/gdbcore.h:29,
>                  from /home/simark/src/binutils-gdb/gdb/solib-spu.c:23:
> /home/simark/src/binutils-gdb/gdb/target/target.h:35:12: note:   initializing argument 2 of ‘int target_read_memory(CORE_ADDR, gdb_byte*, ssize_t)’
>  extern int target_read_memory (CORE_ADDR memaddr, gdb_byte *myaddr,
> 
> gdb/ChangeLog:
> 
> 	* solib-spu.c (spu_bfd_iovec_pread): Add (gdb_byte *) cast.

OK.

Thanks,
Pedro Alves
diff mbox

Patch

diff --git a/gdb/solib-spu.c b/gdb/solib-spu.c
index 468ab1a..dca13e0 100644
--- a/gdb/solib-spu.c
+++ b/gdb/solib-spu.c
@@ -296,7 +296,7 @@  spu_bfd_iovec_pread (bfd *abfd, void *stream, void *buf,
   CORE_ADDR addr = *(CORE_ADDR *)stream;
   int ret;
 
-  ret = target_read_memory (addr + offset, buf, nbytes);
+  ret = target_read_memory (addr + offset, (gdb_byte *) buf, nbytes);
   if (ret != 0)
     {
       bfd_set_error (bfd_error_invalid_operation);