From patchwork Fri Oct 9 21:41:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 9025 Received: (qmail 19304 invoked by alias); 9 Oct 2015 21:42:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 19246 invoked by uid 89); 9 Oct 2015 21:42:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 09 Oct 2015 21:42:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7E8632912D for ; Fri, 9 Oct 2015 17:42:06 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id pnPgdzovLvTs for ; Fri, 9 Oct 2015 17:42:06 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4D7D028F8A for ; Fri, 9 Oct 2015 17:42:06 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E344A42BBA; Fri, 9 Oct 2015 14:42:04 -0700 (PDT) From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [PATCH 2/8] use gdb_byte in ada-lang.c::ada_value_primitive_packed_val... Date: Fri, 9 Oct 2015 14:41:55 -0700 Message-Id: <1444426921-19985-3-git-send-email-brobecker@adacore.com> In-Reply-To: <1444426921-19985-1-git-send-email-brobecker@adacore.com> References: <1444426921-19985-1-git-send-email-brobecker@adacore.com> ... instead of "unsigned char". gdb/Changelog: * ada-lang.c (ada_value_primitive_packed_val): Change the type of local variables src and unpacked to "gdb_type *" instead of "unsigned char *". --- gdb/ChangeLog | 6 ++++++ gdb/ada-lang.c | 10 +++++----- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 02e9e40..ff3e7d5 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2015-10-09 Joel Brobecker + * ada-lang.c (ada_value_primitive_packed_val): Change the type + of local variables src and unpacked to "gdb_type *" instead of + "unsigned char *". + +2015-10-09 Joel Brobecker + * ada-lang.c (ada_value_primitive_packed_val): Make the name of various local variables more explicit and consistent. No real code change otherwise. diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 6063952..a5e68d5 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -2406,8 +2406,8 @@ ada_value_primitive_packed_val (struct value *obj, const gdb_byte *valaddr, unusedLS, /* Number of bits in next significant byte of source that are unused */ accumSize; /* Number of meaningful bits in accum */ - unsigned char *src; /* First byte containing data to unpack */ - unsigned char *unpacked; + gdb_byte *src; /* First byte containing data to unpack */ + gdb_byte *unpacked; unsigned long accum; /* Staging area for bits being transferred */ unsigned char sign; int src_len = (bit_size + bit_offset + HOST_CHAR_BIT - 1) / 8; @@ -2420,7 +2420,7 @@ ada_value_primitive_packed_val (struct value *obj, const gdb_byte *valaddr, if (obj == NULL) { v = allocate_value (type); - src = (unsigned char *) valaddr + offset; + src = (gdb_byte *) valaddr + offset; } else if (VALUE_LVAL (obj) == lval_memory && value_lazy (obj)) { @@ -2443,7 +2443,7 @@ ada_value_primitive_packed_val (struct value *obj, const gdb_byte *valaddr, else { v = allocate_value (type); - src = (unsigned char *) value_contents (obj) + offset; + src = (gdb_byte *) value_contents (obj) + offset; } if (obj != NULL) @@ -2466,7 +2466,7 @@ ada_value_primitive_packed_val (struct value *obj, const gdb_byte *valaddr, } else set_value_bitsize (v, bit_size); - unpacked = (unsigned char *) value_contents (v); + unpacked = (gdb_byte *) value_contents (v); srcBitsLeft = bit_size; src_bytes_left = src_len;