From patchwork Sat Aug 29 22:33:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Palka X-Patchwork-Id: 8513 Received: (qmail 41501 invoked by alias); 29 Aug 2015 22:33:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 41485 invoked by uid 89); 29 Aug 2015 22:33:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-qk0-f169.google.com Received: from mail-qk0-f169.google.com (HELO mail-qk0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 29 Aug 2015 22:33:30 +0000 Received: by qkch123 with SMTP id h123so46300959qkc.0 for ; Sat, 29 Aug 2015 15:33:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=T4H2tGcUvmCWU+HlMZBmFw3iC/IzEn/KrFvFiwCb40Y=; b=WasVOXPzFkwPHStadjzb4dLbw5ZGgMXyR3jfd8JxRI1yPRAbDJbTDiA4usx3AbmIrX qWGiansslVjsG2HLkvPkU82sA6ywAUP4vpgJ13BTTfz4MQkmD+x/V3/OqiDyV80VnXoO /F+YyBk6J7WWDT2mY1TgN1rKWJvpVRquvmy24TMZXr8oheScuvfeLazDafwi9b7KEkqG SLth3SmSTCEXG4rWKVrtHJ36q0XBM8fJJqpFYRBSp1zEJwaq5cjxgZ9Se176vYn1bief ty5drTH1t3v4RZPLUe8svyv8EvgdZfn07baELE8pDzXaGwdbPnoYmru+dJYSUBpjirKV F1eQ== X-Gm-Message-State: ALoCoQkmUHEQpxaMo40VstirT80TiGh32NNu0DJ/KTQ17V67S6tb5AhXi++hALmlrQitloB8Axwj X-Received: by 10.55.197.84 with SMTP id p81mr27148356qki.90.1440887608015; Sat, 29 Aug 2015 15:33:28 -0700 (PDT) Received: from localhost.localdomain (ool-4353acd8.dyn.optonline.net. [67.83.172.216]) by smtp.gmail.com with ESMTPSA id p18sm942435qge.40.2015.08.29.15.33.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 29 Aug 2015 15:33:27 -0700 (PDT) From: Patrick Palka To: gdb-patches@sourceware.org Cc: xdje42@gmail.com, Patrick Palka Subject: [PATCH 2/2] Use gdbarch obstack to allocate the TYPE_NAME string in arch_type Date: Sat, 29 Aug 2015 18:33:20 -0400 Message-Id: <1440887600-22980-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: References: [ The earlier committed version of this patch was reverted. ] Since the type whose name is being set is now being allocated on the gdbarch obstack, we should allocate its TYPE_NAME on the obstack too. This reduces the number of individual valgrind warnings for the command "gdb gdb" from ~300 to ~150. Tested on x86_64-unknown-linux-gnu. gdb/ChangeLog: * gdb_obstack.h (obstack_strdup): Declare. * gdb_obstack.c (obstack_strdup): Declare. * gdbarch.sh (gdbarch_obstack_strdup): Declare and define. * gdbarch.c: Regenerate. * gdbarch.h: Regenerate. * gdbtypes.c (arch_type): Use gdbarch_obstack_strdup. --- gdb/gdb_obstack.c | 10 ++++++++++ gdb/gdb_obstack.h | 5 +++++ gdb/gdbarch.c | 8 ++++++++ gdb/gdbarch.h | 5 +++++ gdb/gdbarch.sh | 13 +++++++++++++ gdb/gdbtypes.c | 2 +- 6 files changed, 42 insertions(+), 1 deletion(-) diff --git a/gdb/gdb_obstack.c b/gdb/gdb_obstack.c index b972eab..d8d03df 100644 --- a/gdb/gdb_obstack.c +++ b/gdb/gdb_obstack.c @@ -45,3 +45,13 @@ obconcat (struct obstack *obstackp, ...) return obstack_finish (obstackp); } + +/* See gdb_obstack.h. */ + +char * +obstack_strdup (struct obstack *obstackp, const char *string) +{ + char *obstring = obstack_alloc (obstackp, strlen (string) + 1); + strcpy (obstring, string); + return obstring; +} diff --git a/gdb/gdb_obstack.h b/gdb/gdb_obstack.h index 826c8b2..3272721 100644 --- a/gdb/gdb_obstack.h +++ b/gdb/gdb_obstack.h @@ -58,4 +58,9 @@ extern char *obconcat (struct obstack *obstackp, ...) ATTRIBUTE_SENTINEL; +/* Duplicate STRING, returning an equivalent string that's allocated on the + obstack OBSTACKP. */ + +extern char *obstack_strdup (struct obstack *obstackp, const char *string); + #endif diff --git a/gdb/gdbarch.c b/gdb/gdbarch.c index 0d4142b..f04eef9 100644 --- a/gdb/gdbarch.c +++ b/gdb/gdbarch.c @@ -449,6 +449,14 @@ gdbarch_obstack_zalloc (struct gdbarch *arch, long size) return data; } +/* See gdbarch.h. */ + +char * +gdbarch_obstack_strdup (struct gdbarch *arch, const char *string) +{ + return obstack_strdup (arch->obstack, string); +} + /* Free a gdbarch struct. This should never happen in normal operation --- once you've created a gdbarch, you keep it around. diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h index 7df37c9..82e0259 100644 --- a/gdb/gdbarch.h +++ b/gdb/gdbarch.h @@ -1618,6 +1618,11 @@ extern void *gdbarch_obstack_zalloc (struct gdbarch *gdbarch, long size); #define GDBARCH_OBSTACK_CALLOC(GDBARCH, NR, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), (NR) * sizeof (TYPE))) #define GDBARCH_OBSTACK_ZALLOC(GDBARCH, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), sizeof (TYPE))) +/* Duplicate STRING, returning an equivalent string that's allocated on the + obstack associated with GDBARCH. The string is freed when the corresponding + architecture is also freed. */ + +extern char *gdbarch_obstack_strdup (struct gdbarch *arch, const char *string); /* Helper function. Force an update of the current architecture. diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh index 34e6a74..388920f 100755 --- a/gdb/gdbarch.sh +++ b/gdb/gdbarch.sh @@ -1486,6 +1486,11 @@ extern void *gdbarch_obstack_zalloc (struct gdbarch *gdbarch, long size); #define GDBARCH_OBSTACK_CALLOC(GDBARCH, NR, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), (NR) * sizeof (TYPE))) #define GDBARCH_OBSTACK_ZALLOC(GDBARCH, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), sizeof (TYPE))) +/* Duplicate STRING, returning an equivalent string that's allocated on the + obstack associated with GDBARCH. The string is freed when the corresponding + architecture is also freed. */ + +extern char *gdbarch_obstack_strdup (struct gdbarch *arch, const char *string); /* Helper function. Force an update of the current architecture. @@ -1791,6 +1796,14 @@ gdbarch_obstack_zalloc (struct gdbarch *arch, long size) return data; } +/* See gdbarch.h. */ + +char * +gdbarch_obstack_strdup (struct gdbarch *arch, const char *string) +{ + return obstack_strdup (arch->obstack, string); +} + /* Free a gdbarch struct. This should never happen in normal operation --- once you've created a gdbarch, you keep it around. diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 7a18bed..12ff014 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -4549,7 +4549,7 @@ arch_type (struct gdbarch *gdbarch, TYPE_LENGTH (type) = length; if (name) - TYPE_NAME (type) = xstrdup (name); + TYPE_NAME (type) = gdbarch_obstack_strdup (gdbarch, name); return type; }