From patchwork Tue Jun 30 02:28:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Palka X-Patchwork-Id: 7430 Received: (qmail 118416 invoked by alias); 30 Jun 2015 02:28:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 118395 invoked by uid 89); 30 Jun 2015 02:28:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-qk0-f180.google.com Received: from mail-qk0-f180.google.com (HELO mail-qk0-f180.google.com) (209.85.220.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 30 Jun 2015 02:28:12 +0000 Received: by qkhu186 with SMTP id u186so104171743qkh.0 for ; Mon, 29 Jun 2015 19:28:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3S3vikZSBXoExgOuuXsu2pDmlsAyvZiZClUz3LWybuc=; b=UGfeZDnxVdKlAWrFHYzMjBo3xcVUkDlNwJcBxMs6laMYyTaD2neYPKL/XgCMkPmyaO m/J87JXIpTl4N/ff2wahcMLBpTq40nRRxBcXHIBUs2+enJu5hQvcQUF6fH4/LdT4S+fe IUHSwT7keLWfPior1d9Kgqxh8Bm2x0ITmuSWyOwP03DahgUPKabJBrr/bWyxynW8+rpr yCO5ITSdic/h33TkwT/y+ox4U/kraMo2d9hpU0BpIHjyt2Zay7iFXY+0hO7rgtwj9+bL yX9QJlQP7kjTervcXL/tSzhy+hq7xzANla7Wu3ZNySCyjhEFXOyaVfHTPYpw4TbUtdjG PGeg== X-Gm-Message-State: ALoCoQnc07HWDdopR+gE3rBjK60cohrf1M+VFDBHWTdvy8PfuhKAW5dy8x8PHhBsVVcDqbSDHj+i X-Received: by 10.140.145.201 with SMTP id 192mr24471014qhr.82.1435631290278; Mon, 29 Jun 2015 19:28:10 -0700 (PDT) Received: from localhost.localdomain (ool-4353acd8.dyn.optonline.net. [67.83.172.216]) by mx.google.com with ESMTPSA id h3sm12487104qgh.22.2015.06.29.19.28.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 29 Jun 2015 19:28:09 -0700 (PDT) From: Patrick Palka To: gdb-patches@sourceware.org Cc: Patrick Palka Subject: [PATCH 2/2] Use gdbarch obstack to allocate the TYPE_NAME string in arch_type Date: Mon, 29 Jun 2015 22:28:01 -0400 Message-Id: <1435631281-31970-2-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1435631281-31970-1-git-send-email-patrick@parcs.ath.cx> References: <1435631281-31970-1-git-send-email-patrick@parcs.ath.cx> Since the type whose name is being set is now being allocated on the gdbarch obstack, we should allocate its TYPE_NAME on the obstack too. This reduces the number of individual valgrind warnings for the command "gdb gdb" from ~300 to ~150. Tested on x86_64-unknown-linux-gnu. [ I have a few more patches on top of these that together bring the total number of valgrind warnings for the command "gdb gdb" down to ~30 but they are more controversial than these two, and if these aren't OK then the rest definitely aren't OK. ] gdb/ChangeLog: * gdbarch.h (gdbarch_obstack_strdup): Declare. * gdbarch.c (gdbarch_obstack_strdup): Define. * gdbtypes.c (arch_type): Use it. --- gdb/gdbarch.c | 10 ++++++++++ gdb/gdbarch.h | 5 +++++ gdb/gdbtypes.c | 2 +- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/gdb/gdbarch.c b/gdb/gdbarch.c index c289334..a232177 100644 --- a/gdb/gdbarch.c +++ b/gdb/gdbarch.c @@ -449,6 +449,16 @@ gdbarch_obstack_zalloc (struct gdbarch *arch, long size) return data; } +/* See gdbarch.h. */ + +char * +gdbarch_obstack_strdup (struct gdbarch *gdbarch, const char *string) +{ + char *obstring = gdbarch_obstack_zalloc (gdbarch, strlen (string) + 1); + strcpy (obstring, string); + return obstring; +} + /* Free a gdbarch struct. This should never happen in normal operation --- once you've created a gdbarch, you keep it around. diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h index 7d6a0cf..fc35136 100644 --- a/gdb/gdbarch.h +++ b/gdb/gdbarch.h @@ -1614,6 +1614,11 @@ extern void *gdbarch_obstack_zalloc (struct gdbarch *gdbarch, long size); #define GDBARCH_OBSTACK_CALLOC(GDBARCH, NR, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), (NR) * sizeof (TYPE))) #define GDBARCH_OBSTACK_ZALLOC(GDBARCH, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), sizeof (TYPE))) +/* Duplicate STRING, returning an equivalent string that's allocated on the + obstack associated with GDBARCH. The string is freed when the corresponding + architecture is also freed. */ + +extern char *gdbarch_obstack_strdup (struct gdbarch *gdbarch, const char *string); /* Helper function. Force an update of the current architecture. diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 979ed6c..86c6282 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -4539,7 +4539,7 @@ arch_type (struct gdbarch *gdbarch, TYPE_LENGTH (type) = length; if (name) - TYPE_NAME (type) = xstrdup (name); + TYPE_NAME (type) = gdbarch_obstack_strdup (gdbarch, name); return type; }