gdb: microblaze: delete useless stubs
Commit Message
These don't accomplish anything the common core doesn't already, so
punt them as they purely waste code.
2015-06-21 Mike Frysinger <vapier@gentoo.org>
* microblaze-tdep.c (microblaze_push_dummy_code): Delete.
(microblaze_push_dummy_call): Likewise.
(microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code
and set_gdbarch_push_dummy_call.
---
gdb/microblaze-tdep.c | 26 --------------------------
1 file changed, 26 deletions(-)
Comments
On 06/21/2015 11:13 AM, Mike Frysinger wrote:
> These don't accomplish anything the common core doesn't already, so
> punt them as they purely waste code.
>
> 2015-06-21 Mike Frysinger <vapier@gentoo.org>
>
> * microblaze-tdep.c (microblaze_push_dummy_code): Delete.
> (microblaze_push_dummy_call): Likewise.
> (microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code
> and set_gdbarch_push_dummy_call.
Does the common code issue an error if someone tries
to call a target function?
On 21 Jun 2015 12:36, Michael Eager wrote:
> On 06/21/2015 11:13 AM, Mike Frysinger wrote:
> > These don't accomplish anything the common core doesn't already, so
> > punt them as they purely waste code.
> >
> > 2015-06-21 Mike Frysinger <vapier@gentoo.org>
> >
> > * microblaze-tdep.c (microblaze_push_dummy_code): Delete.
> > (microblaze_push_dummy_call): Likewise.
> > (microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code
> > and set_gdbarch_push_dummy_call.
>
> Does the common code issue an error if someone tries
> to call a target function?
yes
gdb/infcall.c:
struct value *
call_function_by_hand_dummy (struct value *function,
...
if (!gdbarch_push_dummy_call_p (gdbarch))
error (_("This target does not support function calls."));
$ ./gdb ...
(gdb) p foo(1)
This target does not support function calls.
-mike
On 06/21/2015 09:56 PM, Mike Frysinger wrote:
> On 21 Jun 2015 12:36, Michael Eager wrote:
>> On 06/21/2015 11:13 AM, Mike Frysinger wrote:
>>> These don't accomplish anything the common core doesn't already, so
>>> punt them as they purely waste code.
>>>
>>> 2015-06-21 Mike Frysinger <vapier@gentoo.org>
>>>
>>> * microblaze-tdep.c (microblaze_push_dummy_code): Delete.
>>> (microblaze_push_dummy_call): Likewise.
>>> (microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code
>>> and set_gdbarch_push_dummy_call.
>>
>> Does the common code issue an error if someone tries
>> to call a target function?
>
> yes
>
> gdb/infcall.c:
> struct value *
> call_function_by_hand_dummy (struct value *function,
> ...
> if (!gdbarch_push_dummy_call_p (gdbarch))
> error (_("This target does not support function calls."));
>
> $ ./gdb ...
> (gdb) p foo(1)
> This target does not support function calls.
> -mike
Go ahead and commit.
@@ -134,30 +134,6 @@ microblaze_fetch_instruction (CORE_ADDR pc)
return extract_unsigned_integer (buf, 4, byte_order);
}
-
-static CORE_ADDR
-microblaze_push_dummy_code (struct gdbarch *gdbarch, CORE_ADDR sp,
- CORE_ADDR funcaddr,
- struct value **args, int nargs,
- struct type *value_type,
- CORE_ADDR *real_pc, CORE_ADDR *bp_addr,
- struct regcache *regcache)
-{
- error (_("push_dummy_code not implemented"));
- return sp;
-}
-
-
-static CORE_ADDR
-microblaze_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
- struct regcache *regcache, CORE_ADDR bp_addr,
- int nargs, struct value **args, CORE_ADDR sp,
- int struct_return, CORE_ADDR struct_addr)
-{
- error (_("store_arguments not implemented"));
- return sp;
-}
-
static const gdb_byte *
microblaze_breakpoint_from_pc (struct gdbarch *gdbarch, CORE_ADDR *pc,
int *len)
@@ -749,8 +725,6 @@ microblaze_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
/* Call dummy code. */
set_gdbarch_call_dummy_location (gdbarch, ON_STACK);
- set_gdbarch_push_dummy_code (gdbarch, microblaze_push_dummy_code);
- set_gdbarch_push_dummy_call (gdbarch, microblaze_push_dummy_call);
set_gdbarch_return_value (gdbarch, microblaze_return_value);
set_gdbarch_stabs_argument_has_addr