From patchwork Sat Mar 28 21:45:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 5872 Received: (qmail 53983 invoked by alias); 28 Mar 2015 21:45:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 53919 invoked by uid 89); 28 Mar 2015 21:45:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 28 Mar 2015 21:45:57 +0000 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 62584340A41 for ; Sat, 28 Mar 2015 21:45:55 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 3/5] sim: sh: fix broken handling in DSR reg Date: Sat, 28 Mar 2015 17:45:50 -0400 Message-Id: <1427579152-7275-3-git-send-email-vapier@gentoo.org> In-Reply-To: <1427579152-7275-1-git-send-email-vapier@gentoo.org> References: <1427579152-7275-1-git-send-email-vapier@gentoo.org> X-IsSubscribed: yes A missing */ caused a case statement to be incorrect masked out which also hide an error where the wrong value was being checked. Fix both. Committed. --- sim/sh/ChangeLog | 4 ++++ sim/sh/gencode.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/sim/sh/ChangeLog b/sim/sh/ChangeLog index 3e0fff1..46b8e53 100644 --- a/sim/sh/ChangeLog +++ b/sim/sh/ChangeLog @@ -1,5 +1,9 @@ 2015-03-28 Mike Frysinger + * gencode.c (ppi_gensim): Add missing */. Change case 4 to case 5. + +2015-03-28 Mike Frysinger + * Makefile.in (gencode): Add $(BUILD_CFLAGS), $(BUILD_LDFLAGS), and $(WARN_CFLAGS). * gencode.c: Include ctype.h, stdlib.h, string.h, and unistd.h. diff --git a/sim/sh/gencode.c b/sim/sh/gencode.c index 0fb1b87..bcaeb6c 100644 --- a/sim/sh/gencode.c +++ b/sim/sh/gencode.c @@ -3359,11 +3359,11 @@ ppi_gensim (void) printf (" DSR |= res_grd >> 7 & 1;\n"); printf (" case 2: /* Zero Value Mode */\n"); printf (" DSR |= DSR >> 6 & 1;\n"); - printf (" case 3: /* Overflow mode\n"); + printf (" case 3: /* Overflow mode */\n"); printf (" DSR |= overflow >> 4;\n"); printf (" case 4: /* Signed Greater Than Mode */\n"); printf (" DSR |= DSR >> 7 & 1;\n"); - printf (" case 4: /* Signed Greater Than Or Equal Mode */\n"); + printf (" case 5: /* Signed Greater Than Or Equal Mode */\n"); printf (" DSR |= greater_equal >> 7;\n"); printf (" }\n"); printf (" assign_z:\n");