From patchwork Tue Jan 13 22:47:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Don Breazeal X-Patchwork-Id: 4657 Received: (qmail 5627 invoked by alias); 13 Jan 2015 22:47:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 5595 invoked by uid 89); 13 Jan 2015 22:47:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jan 2015 22:47:14 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1YBAEx-000775-HN from Don_Breazeal@mentor.com for gdb-patches@sourceware.org; Tue, 13 Jan 2015 14:47:11 -0800 Received: from build4-lucid-cs (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.224.2; Tue, 13 Jan 2015 14:47:10 -0800 Received: by build4-lucid-cs (Postfix, from userid 1905) id C76A140DCE; Tue, 13 Jan 2015 14:47:10 -0800 (PST) From: Don Breazeal To: Subject: [PATCH] Skip two more attach tests when testing against stub-like targets Date: Tue, 13 Jan 2015 14:47:10 -0800 Message-ID: <1421189230-2516-1-git-send-email-donb@codesourcery.com> MIME-Version: 1.0 X-IsSubscribed: yes This is a follow-up to Pedro's recent patch 'Skip "attach" tests when testing against stub-like targets' (https://sourceware.org/ml/gdb-patches/2015-01/msg00119.html). This patch replaces "is_remote target" with "can_spawn_for_attach" in two more attach tests where "attach" doesn't make sense so that they are skipped when appropriate. Tested with i686-mingw32 host and i686-pc-linux-gnu build/target. OK? Thanks --Don gdb/testsuite/ 2015-01-13 Don Breazeal * gdb.base/attach-pie-noexec.exp: Use can_spawn_for_attach instead of checking whether the target board is remote. * gdb.base/attach-twice.exp: Likewise. --- gdb/testsuite/gdb.base/attach-pie-noexec.exp | 3 +-- gdb/testsuite/gdb.base/attach-twice.exp | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/gdb/testsuite/gdb.base/attach-pie-noexec.exp b/gdb/testsuite/gdb.base/attach-pie-noexec.exp index f6aa1c8..b53d516 100644 --- a/gdb/testsuite/gdb.base/attach-pie-noexec.exp +++ b/gdb/testsuite/gdb.base/attach-pie-noexec.exp @@ -13,8 +13,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . -# Manipulation with PID on target is not supported. -if [is_remote target] then { +if {![can_spawn_for_attach]} { return 0 } diff --git a/gdb/testsuite/gdb.base/attach-twice.exp b/gdb/testsuite/gdb.base/attach-twice.exp index 654ceca..eb03c92 100644 --- a/gdb/testsuite/gdb.base/attach-twice.exp +++ b/gdb/testsuite/gdb.base/attach-twice.exp @@ -13,8 +13,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . -# Manipulation with PID on target is not supported. -if [is_remote target] then { +if {![can_spawn_for_attach]} { return 0 }