From patchwork Sat Dec 13 15:29:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Brobecker X-Patchwork-Id: 4232 Received: (qmail 9815 invoked by alias); 13 Dec 2014 15:29:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 9798 invoked by uid 89); 13 Dec 2014 15:29:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 13 Dec 2014 15:29:47 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 14BD2116472 for ; Sat, 13 Dec 2014 10:29:45 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id J6xFjsVpe9yI for ; Sat, 13 Dec 2014 10:29:45 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EEBA211645B for ; Sat, 13 Dec 2014 10:29:44 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id CE14B40164; Sat, 13 Dec 2014 10:29:45 -0500 (EST) From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [pushed] Avoid use of sprintf in gdb/utils.c:make_hex_string Date: Sat, 13 Dec 2014 10:29:43 -0500 Message-Id: <1418484583-18492-1-git-send-email-brobecker@adacore.com> In-Reply-To: <20141205015244.GA30467@sourceware.org> References: <20141205015244.GA30467@sourceware.org> The use of sprintf is discouraged in GDB. Use xsnprintf instead. gdb/ChangeLog: * utils.c (make_hex_string): Replace use of sprintf by use of xsnprintf. Tested on x86_64-linux and pushed. --- gdb/ChangeLog | 5 +++++ gdb/utils.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ac916de..c12de3a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2014-12-13 Joel Brobecker + * utils.c (make_hex_string): Replace use of sprintf by use of + xsnprintf. + +2014-12-13 Joel Brobecker + * compile/compile-object-load.c (link_callbacks_multiple_definition) (link_callbacks_warning, link_callbacks_einfo): Remove trailing newline at end of warning message. diff --git a/gdb/utils.c b/gdb/utils.c index 1ab183c..ea2b18a 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -1124,7 +1124,7 @@ make_hex_string (const gdb_byte *data, size_t length) p = result; for (i = 0; i < length; ++i) - p += sprintf (p, "%02x", data[i]); + p += xsnprintf (p, 2, "%02x", data[i]); *p = '\0'; return result; }