From patchwork Tue Nov 4 13:31:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 3569 Received: (qmail 442 invoked by alias); 4 Nov 2014 13:31:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 427 invoked by uid 89); 4 Nov 2014 13:31:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 04 Nov 2014 13:31:34 +0000 Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id C5.63.25146.C7A78545; Tue, 4 Nov 2014 08:04:28 +0100 (CET) Received: from simark-hp.mo.ca.am.ericsson.se (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.78) with Microsoft SMTP Server (TLS) id 14.3.174.1; Tue, 4 Nov 2014 08:31:31 -0500 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH] tui: Fix newterm call for older ncurses Date: Tue, 4 Nov 2014 08:31:25 -0500 Message-ID: <1415107885-18095-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-IsSubscribed: yes Older versions of ncurses' newterm can't take NULL for their ofp and ifp parameters. Newer versions can, and they fall back on stdout/stdin if that is the case. This patch explicitely passes stdout/stdin to the call to newterm to avoid segfaulting with older ncurses. Reference: https://sourceware.org/ml/gdb-patches/2014-11/msg00055.html gdb/Changelog: 2014-11-04 Simon Marchi * tui/tui.c (tui_enable): Pass pass stdout and stdin to newterm. --- gdb/tui/tui.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c index cb85fb0..12ddab3 100644 --- a/gdb/tui/tui.c +++ b/gdb/tui/tui.c @@ -424,7 +424,7 @@ tui_enable (void) if (!ui_file_isatty (gdb_stdout)) error (_("Cannot enable the TUI when output is not a terminal")); - s = newterm (NULL, NULL, NULL); + s = newterm (NULL, stdout, stdin); if (s == NULL) { error (_("Cannot enable the TUI: error opening terminal [TERM=%s]"),