From patchwork Wed Sep 10 09:21:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keven Boell X-Patchwork-Id: 2725 Received: (qmail 29878 invoked by alias); 10 Sep 2014 09:22:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 29730 invoked by uid 89); 10 Sep 2014 09:22:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Sep 2014 09:22:14 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 10 Sep 2014 02:22:12 -0700 X-ExtLoop1: 1 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga002.jf.intel.com with ESMTP; 10 Sep 2014 02:22:11 -0700 Received: from ullecvh004g04.iul.intel.com (ullecvh004g04.iul.intel.com [172.28.50.14]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id s8A9MAtE008348; Wed, 10 Sep 2014 10:22:10 +0100 Received: from ullecvh004g04.iul.intel.com (ullecvh004g04.iul.intel.com [127.0.0.1]) by ullecvh004g04.iul.intel.com (8.13.8/8.13.8) with ESMTP id s8A9MEUL020708; Wed, 10 Sep 2014 11:22:14 +0200 Received: (from kboell@localhost) by ullecvh004g04.iul.intel.com (8.13.8/8.13.8/Submit) id s8A9MEuG020707; Wed, 10 Sep 2014 11:22:14 +0200 From: Keven Boell To: gdb-patches@sourceware.org Cc: sanimir.agovic@intel.com, Keven Boell Subject: [V3 06/21] vla: get dynamic array corner cases to work Date: Wed, 10 Sep 2014 11:21:54 +0200 Message-Id: <1410340929-20653-7-git-send-email-keven.boell@intel.com> In-Reply-To: <1410340929-20653-1-git-send-email-keven.boell@intel.com> References: <1410340929-20653-1-git-send-email-keven.boell@intel.com> This patch does not overwrite the value type in case it is a dynamic type. For dynamic types GDB resolved its dynamic values in a copy of the type. The call to deprecated_set_value_type overwrites the resolved type with the original type, which breaks e.g. pointer to a Fortran type, which contains a dynamic array. Old: (gdb) print &vla1 (PTR TO -> ( real(kind=4) (23959136:23959184))) 0x7fffffffd490 New: (gdb) print &vla1 (PTR TO -> ( real(kind=4) (5))) 0x7fffffffd490 2014-05-28 Keven Boell Sanimir Agovic * value.c (readjust_indirect_value_type): Add check for dynamic types. --- gdb/value.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/value.c b/gdb/value.c index 769cbbb..2d995b9 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -3647,7 +3647,8 @@ readjust_indirect_value_type (struct value *value, struct type *enc_type, struct value *original_value) { /* Re-adjust type. */ - deprecated_set_value_type (value, TYPE_TARGET_TYPE (original_type)); + if (!is_dynamic_type (TYPE_TARGET_TYPE (original_type))) + deprecated_set_value_type (value, TYPE_TARGET_TYPE (original_type)); /* Add embedding info. */ set_value_enclosing_type (value, enc_type);