From patchwork Wed Aug 6 06:25:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 2311 Received: (qmail 14993 invoked by alias); 6 Aug 2014 06:29:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 14981 invoked by uid 89); 6 Aug 2014 06:29:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Aug 2014 06:29:56 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1XEujR-0001Ul-LL from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Tue, 05 Aug 2014 23:29:53 -0700 Received: from SVR-ORW-FEM-06.mgc.mentorg.com ([147.34.97.120]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 5 Aug 2014 23:29:53 -0700 Received: from qiyao.dyndns.org.com (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.2.247.3; Tue, 5 Aug 2014 23:29:52 -0700 From: Yao Qi To: Subject: [PATCH] Replace 0 with TARGET_XFER_EOF in to_xfer_partial Date: Wed, 6 Aug 2014 14:25:45 +0800 Message-ID: <1407306345-4371-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 X-IsSubscribed: yes I run splint in gdb source and get the following warnings: ../../../git/gdb/corelow.c:740: Return value type int does not match declared type enum target_xfer_status: 0 'TARGET_XFER_EOF' (enum target_xfer_status) is expected to be returned, but 0 is returned. This patch is to replace 0 with TARGET_XFER_EOF in the implementations of to_xfer_partial. I'll commit it in two days. gdb: 2014-08-06 Yao Qi * corelow.c (core_xfer_partial): Replace 0 with TARGET_XFER_EOF. * remote-m32r-sdi.c (m32r_xfer_memory): Likewise. --- gdb/corelow.c | 2 +- gdb/remote-m32r-sdi.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/corelow.c b/gdb/corelow.c index ad780ed..4d783b6 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -737,7 +737,7 @@ core_xfer_partial (struct target_ops *ops, enum target_object object, size = bfd_section_size (core_bfd, section); if (offset >= size) - return 0; + return TARGET_XFER_EOF; size -= offset; if (size > len) size = len; diff --git a/gdb/remote-m32r-sdi.c b/gdb/remote-m32r-sdi.c index e5b66a0..3d2260d 100644 --- a/gdb/remote-m32r-sdi.c +++ b/gdb/remote-m32r-sdi.c @@ -1081,7 +1081,7 @@ m32r_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf, if (remote_debug) fprintf_unfiltered (gdb_stdlog, "m32r_xfer_memory() failed\n"); - return 0; + return TARGET_XFER_EOF; } ret = send_data (writebuf, len); } @@ -1095,7 +1095,7 @@ m32r_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf, { if (remote_debug) fprintf_unfiltered (gdb_stdlog, "m32r_xfer_memory() failed\n"); - return 0; + return TARGET_XFER_EOF; } c = serial_readchar (sdi_desc, SDI_TIMEOUT); @@ -1103,7 +1103,7 @@ m32r_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf, { if (remote_debug) fprintf_unfiltered (gdb_stdlog, "m32r_xfer_memory() failed\n"); - return 0; + return TARGET_XFER_EOF; } ret = recv_data (readbuf, len);