From patchwork Mon Jul 7 19:17:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 1931 Received: (qmail 6350 invoked by alias); 7 Jul 2014 19:17:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 6304 invoked by uid 89); 7 Jul 2014 19:17:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 07 Jul 2014 19:17:54 +0000 Received: from EUSAAHC008.ericsson.se (Unknown_Domain [147.117.188.96]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 19.D8.25146.7CD9AB35; Mon, 7 Jul 2014 15:16:55 +0200 (CEST) Received: from simark-hp.mo.ca.am.ericsson.se (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.96) with Microsoft SMTP Server (TLS) id 14.3.174.1; Mon, 7 Jul 2014 15:17:47 -0400 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH v2 2/2] Only leave dprintf inserted if it is marked as persistent (PR breakpoints/17012) Date: Mon, 7 Jul 2014 15:17:44 -0400 Message-ID: <1404760664-17289-2-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1404760664-17289-1-git-send-email-simon.marchi@ericsson.com> References: <1404760664-17289-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-IsSubscribed: yes On Linux native, if dprintf are inserted when detaching, they are left in the inferior which causes it to crash from a SIGTRAP. It also happens with dprintfs on remote targets, when set disconnected-dprintf is off. I believe that the rationale of the line I modified was to leave dprinfs inserted in order to support disconnected dprintfs. This adds a check to see if the dprintf should actually stay inserted or not. bl->target_info.persist will be 1 only if disconnected-dprintf is on and we are debugging a remote target. On native, it will always be 0, regardless of the value of disconnected-dprintf. This makes sense, since disconnected dprintfs are not supported by the native target. gdb/Changelog: 2014-07-07 Simon Marchi PR breakpoints/17012 * breakpoint.c (remove_breakpoints_pid): Only skip removing dprintf if it is marked as persistent. --- gdb/breakpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 908a1ea..fb833d0 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -3112,7 +3112,7 @@ remove_breakpoints_pid (int pid) if (bl->pspace != inf->pspace) continue; - if (bl->owner->type == bp_dprintf) + if (bl->owner->type == bp_dprintf && bl->target_info.persist == 1) continue; if (bl->inserted)