From patchwork Mon Jun 16 13:54:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 1511 Received: (qmail 21689 invoked by alias); 16 Jun 2014 13:54:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 21678 invoked by uid 89); 16 Jun 2014 13:54:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Jun 2014 13:54:21 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5GDsKoX028387 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 16 Jun 2014 09:54:20 -0400 Received: from barimba.redhat.com (ovpn-113-103.phx2.redhat.com [10.3.113.103]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5GDsJeT013234; Mon, 16 Jun 2014 09:54:20 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [FYI] fix incorrect comments in minsyms.h Date: Mon, 16 Jun 2014 07:54:14 -0600 Message-Id: <1402926854-16825-1-git-send-email-tromey@redhat.com> minsyms.h incorrectly claims that a couple of functions call prim_record_minimal_symbol_full with COPY_NAME=0 -- but actually they pass 1. Passing 1 is the correct behavior, so this patch fixes the documentation. I'm checking this in as obvious. 2014-06-16 Tom Tromey * minsyms.h (prim_record_minimal_symbol) (prim_record_minimal_symbol_and_info): Update comments. --- gdb/ChangeLog | 5 +++++ gdb/minsyms.h | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/minsyms.h b/gdb/minsyms.h index 289dcae..807e5ee 100644 --- a/gdb/minsyms.h +++ b/gdb/minsyms.h @@ -102,7 +102,7 @@ struct minimal_symbol *prim_record_minimal_symbol_full /* Like prim_record_minimal_symbol_full, but: - uses strlen to compute NAME_LEN, - - passes COPY_NAME = 0, + - passes COPY_NAME = 1, - and passes a default SECTION, depending on the type This variant does not return the new symbol. */ @@ -113,7 +113,7 @@ void prim_record_minimal_symbol (const char *, CORE_ADDR, /* Like prim_record_minimal_symbol_full, but: - uses strlen to compute NAME_LEN, - - passes COPY_NAME = 0. */ + - passes COPY_NAME = 1. */ struct minimal_symbol *prim_record_minimal_symbol_and_info (const char *,