From patchwork Tue May 27 12:10:50 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 1168 Received: (qmail 20511 invoked by alias); 27 May 2014 12:13:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 20483 invoked by uid 89); 27 May 2014 12:13:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 May 2014 12:13:24 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WpGFs-0003fz-Mo from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Tue, 27 May 2014 05:13:20 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 27 May 2014 05:13:20 -0700 Received: from qiyao.dyndns.org.com (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Tue, 27 May 2014 05:13:19 -0700 From: Yao Qi To: Subject: [PATCH] Different outputs affected by locale Date: Tue, 27 May 2014 20:10:50 +0800 Message-ID: <1401192650-29688-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 X-IsSubscribed: yes We find the following fails in gdb test on mingw host. FAIL: gdb.base/wchar.exp: print repeat FAIL: gdb.base/wchar.exp: print repeat_p FAIL: gdb.base/wchar.exp: print repeat (print null on) FAIL: gdb.base/wchar.exp: print repeat (print elements 3) FAIL: gdb.base/wchar.exp: print repeat_p (print elements 3) print repeat^M $7 = L"A", '¢' , "B", '\000' ^M (gdb) FAIL: gdb.base/wchar.exp: print repeat the \242 is expected in the test but cent sign is displayed. In valprint.c:print_wchar, wchar_printable is called to determine whether a wchar is printable. wchar_printable calls iswprint but the iswprint's return value depends on LC_CTYPE setting of locale [1, 2]. The output may vary with different locale settings. I noticed that gdb.exp:gdb_init set LC_CTYPE to C. If I remove that line, tests fail on native testing too. IMO, either \242 or '¢' (cent sign) is a correct output, which is affect by locale, and it is not related to gdb at all. [1] http://pubs.opengroup.org/onlinepubs/009604499/functions/iswprint.html [2] msdn.microsoft.com/en-us/library/ewx8s4kw.aspx This patch is to add code to 'p repeat[1]' to extract the cent first, and then use it to match in the following tests. gdb/testsuite: 2014-05-27 Yao Qi * gdb.base/wchar.exp: Execute command 'p repeat[1]' and extract cent from the output. --- gdb/testsuite/gdb.base/wchar.exp | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/wchar.exp b/gdb/testsuite/gdb.base/wchar.exp index 4290478..215d2f4 100644 --- a/gdb/testsuite/gdb.base/wchar.exp +++ b/gdb/testsuite/gdb.base/wchar.exp @@ -36,7 +36,23 @@ gdb_test "print simple\[2\]" "= 99 L'c'" gdb_test "print difficile\[2\]" "= 65261 L'\\\\xfeed'" -set cent "\\\\242" +# The contents in 'repeat' are shown differently under different +# locale. In stead of hard code the cent sign in variable 'cent', +# extract it from the output of 'print repeat[1]', and use it to +# match the output in the following tests. +set cent "" +set test "get cent" +gdb_test_multiple "p repeat\[1\]" $test { + -re " = 162 L'(.*)'.*\r\n$gdb_prompt $" { + set cent [string_to_regexp $expect_out(1,string)] + pass $test + } + -re ".*$gdb_prompt $" { + fail $test + return + } +} + gdb_test "print repeat" "= L\"A\", '$cent' , \"B.*" global hex