diff mbox

[RFA(7.8)+NEWS] Remove "set/show remotebaud" (deprecated) commands.

Message ID 1400525808-20354-1-git-send-email-brobecker@adacore.com
State Committed
Headers

Commit Message

Joel Brobecker May 19, 2014, 6:56 p.m. UTC 
  Hello,

This patch removes support for the "set/show remotebaud" command,
which were deprecated in GDB 7.7, and should be now be removed
ahead of cutting the GDB 7.8 branch. This should take care of
the one item that's on my list pre- branching 7.8.

gdb/ChangeLog:

        * serial.c (_initialize_serial): Remove support for
        the "set remotebaud" and "show remotebaud" commands.
        * NEWS: Add entry documenting the removal of that command.

gdb/testsuite/ChangeLog:

        * config/monitor.exp (gdb_target_monitor): Replace use of
        "set remotebaud" by "set serial baud".

Tested on x86_64-linux. The testsuite change was tested by hand
by copy/pasting the command and making sure that it works...

OK to commit?

Thanks,

Comments

Eli Zaretskii May 19, 2014, 7:09 p.m. UTC | #1 
> From: Joel Brobecker <brobecker@adacore.com>
> Date: Mon, 19 May 2014 11:56:48 -0700
> 
> This patch removes support for the "set/show remotebaud" command,
> which were deprecated in GDB 7.7, and should be now be removed
> ahead of cutting the GDB 7.8 branch. This should take care of
> the one item that's on my list pre- branching 7.8.
> 
> gdb/ChangeLog:
> 
>         * serial.c (_initialize_serial): Remove support for
>         the "set remotebaud" and "show remotebaud" commands.
>         * NEWS: Add entry documenting the removal of that command.
> 
> gdb/testsuite/ChangeLog:
> 
>         * config/monitor.exp (gdb_target_monitor): Replace use of
>         "set remotebaud" by "set serial baud".
> 
> Tested on x86_64-linux. The testsuite change was tested by hand
> by copy/pasting the command and making sure that it works...
> 
> OK to commit?

OK for the documentation part.

Thanks.
Joel Brobecker May 28, 2014, 8 p.m. UTC | #2 
> gdb/ChangeLog:
> 
>         * serial.c (_initialize_serial): Remove support for
>         the "set remotebaud" and "show remotebaud" commands.
>         * NEWS: Add entry documenting the removal of that command.
> 
> gdb/testsuite/ChangeLog:
> 
>         * config/monitor.exp (gdb_target_monitor): Replace use of
>         "set remotebaud" by "set serial baud".

Pushed! Thanks, Eli, for your review of the NEWS part.
diff mbox

Patch

diff --git a/gdb/NEWS b/gdb/NEWS
index 00ec8b9..fc5ef45 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -113,6 +113,10 @@  PowerPC64 GNU/Linux little-endian	powerpc64le-*-linux*
   and "assf"), have been deprecated.  Use the "sharedlibrary" command, or
   its alias "share", instead.
 
+* The commands "set remotebaud" and "show remotebaud" are no longer
+  supported.  Use "set serial baud" and "show serial baud" (respectively)
+  instead.
+
 *** Changes in GDB 7.7
 
 * Improved support for process record-replay and reverse debugging on
diff --git a/gdb/serial.c b/gdb/serial.c
index 7471a6b..e780bbe 100644
--- a/gdb/serial.c
+++ b/gdb/serial.c
@@ -671,34 +671,6 @@  using remote targets."),
 			    serial_baud_show_cmd,
 			    &serial_set_cmdlist, &serial_show_cmdlist);
 
-  /* The commands "set/show serial baud" used to have a different name.
-     Add aliases to those names to facilitate the transition, and mark
-     them as deprecated, in order to make users aware of the fact that
-     the command names have been changed.  */
-    {
-      const char *cmd_name;
-      struct cmd_list_element *cmd;
-
-      /* FIXME: There is a limitation in the deprecation mechanism,
-	 and the warning ends up not being displayed for prefixed
-	 aliases.  So use a real command instead of an alias.  */
-      add_setshow_zinteger_cmd ("remotebaud", class_alias, &baud_rate, _("\
-Set baud rate for remote serial I/O."), _("\
-Show baud rate for remote serial I/O."), _("\
-This value is used to set the speed of the serial port when debugging\n\
-using remote targets."),
-				NULL,
-				serial_baud_show_cmd,
-				&setlist, &showlist);
-      cmd_name = "remotebaud";
-      cmd = lookup_cmd (&cmd_name, setlist, "", -1, 1);
-      deprecate_cmd (cmd, "set serial baud");
-      cmd_name
-	= "remotebaud"; /* needed because lookup_cmd updates the pointer */
-      cmd = lookup_cmd (&cmd_name, showlist, "", -1, 1);
-      deprecate_cmd (cmd, "show serial baud");
-    }
-
   add_setshow_filename_cmd ("remotelogfile", no_class, &serial_logfile, _("\
 Set filename for remote session recording."), _("\
 Show filename for remote session recording."), _("\
diff --git a/gdb/testsuite/config/monitor.exp b/gdb/testsuite/config/monitor.exp
index bddcdd5..a85aaee 100644
--- a/gdb/testsuite/config/monitor.exp
+++ b/gdb/testsuite/config/monitor.exp
@@ -86,7 +86,7 @@  proc gdb_target_monitor { exec_file } {
 	return -1
     }
     if [target_info exists baud] {
-	gdb_test "set remotebaud [target_info baud]" "" ""
+	gdb_test "set serial baud [target_info baud]" "" ""
     }
     if [target_info exists binarydownload] {
 	gdb_test "set remotebinarydownload [target_info binarydownload]" "" ""