From patchwork Fri May 16 15:26:22 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 961 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx22.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id A452836007B for ; Fri, 16 May 2014 08:26:59 -0700 (PDT) Received: by homiemail-mx22.g.dreamhost.com (Postfix, from userid 14314964) id 4A65159EED02; Fri, 16 May 2014 08:26:59 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx22.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx22.g.dreamhost.com (Postfix) with ESMTPS id 0F09959EED0F for ; Fri, 16 May 2014 08:26:59 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=cqfZTr2HpvygUtbq2ZqwcPRvd7RhKil /t922Yjh7XI69HD020RuPgFjZRZM2ZKlo+7JtuKG0nojDfsXJdpgdvMcQy+Y0rJ1 Tnq6GL4hvi2ot0DMTkWkkaREHgzY+U5QgxeFNd9XV/GAedLsS1upUly2F5CAu7Xe 4SlciSbJkVgY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references; s=default; bh=HKnAC1NN+/c42ddpfLnGjSUK2cQ=; b=XxIh5 bTNP0yINfd2n9j8YSSAT6FC06BLdnZAu8kekAaUCT8orQkM4N2o0LjfGuaaPOznr wgvWtwcAftZxMa++KEQP1rpu17KguNbVSmqrubmByQjdwmbVJJxsGWQKeSivGaQ8 TNm7Z/PEaCz8IMFKC+cY52E1uEb2G+6jjSCdi4= Received: (qmail 15113 invoked by alias); 16 May 2014 15:26:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 14986 invoked by uid 89); 16 May 2014 15:26:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 May 2014 15:26:41 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4GFQduC019054 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 16 May 2014 11:26:40 -0400 Received: from barimba.redhat.com (ovpn-113-182.phx2.redhat.com [10.3.113.182]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4GFQcV3006849; Fri, 16 May 2014 11:26:39 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 01/14] introduce ui_file_write_for_put Date: Fri, 16 May 2014 09:26:22 -0600 Message-Id: <1400253995-12333-2-git-send-email-tromey@redhat.com> In-Reply-To: <1400253995-12333-1-git-send-email-tromey@redhat.com> References: <1400253995-12333-1-git-send-email-tromey@redhat.com> X-DH-Original-To: gdb@patchwork.siddhesh.in This introduces a small helper function, ui_file_write_for_put. It is a wrapper for ui_write that is suitable for passing directly to ui_file_put. This patch also updates one existing spot to use this new function. 2014-05-16 Tom Tromey * ui-file.h (ui_file_write_for_put): Declare. * ui-file.c (ui_file_write_for_put): New function. * mi/mi-out.c (do_write): Remove. (mi_out_put): Use ui_file_write_for_put. --- gdb/ChangeLog | 7 +++++++ gdb/mi/mi-out.c | 8 +------- gdb/ui-file.c | 6 ++++++ gdb/ui-file.h | 6 ++++++ 4 files changed, 20 insertions(+), 7 deletions(-) diff --git a/gdb/mi/mi-out.c b/gdb/mi/mi-out.c index 6ec41e6..9f5d1c0 100644 --- a/gdb/mi/mi-out.c +++ b/gdb/mi/mi-out.c @@ -376,18 +376,12 @@ mi_out_rewind (struct ui_out *uiout) /* Dump the buffer onto the specified stream. */ -static void -do_write (void *data, const char *buffer, long length_buffer) -{ - ui_file_write (data, buffer, length_buffer); -} - void mi_out_put (struct ui_out *uiout, struct ui_file *stream) { mi_out_data *data = ui_out_data (uiout); - ui_file_put (data->buffer, do_write, stream); + ui_file_put (data->buffer, ui_file_write_for_put, stream); ui_file_rewind (data->buffer); } diff --git a/gdb/ui-file.c b/gdb/ui-file.c index e59d70b..e5e35d8 100644 --- a/gdb/ui-file.c +++ b/gdb/ui-file.c @@ -226,6 +226,12 @@ ui_file_write (struct ui_file *file, } void +ui_file_write_for_put (void *data, const char *buffer, long length_buffer) +{ + ui_file_write (data, buffer, length_buffer); +} + +void ui_file_write_async_safe (struct ui_file *file, const char *buf, long length_buf) diff --git a/gdb/ui-file.h b/gdb/ui-file.h index 50c1333..29ce5e0 100644 --- a/gdb/ui-file.h +++ b/gdb/ui-file.h @@ -98,6 +98,12 @@ extern int ui_file_isatty (struct ui_file *); extern void ui_file_write (struct ui_file *file, const char *buf, long length_buf); +/* A wrapper for ui_file_write that is suitable for use by + ui_file_put. */ + +extern void ui_file_write_for_put (void *data, const char *buffer, + long length_buffer); + extern void ui_file_write_async_safe (struct ui_file *file, const char *buf, long length_buf);