[PUSHED,2/2] New testsuite/boards/local-remote-host.exp board, now with editing on
Commit Message
This adds a variant of local-remote-host-notty.exp that forces
pseudo-tty allocation, so that readline/editing is enabled.
$ ssh localhost gdb -q
(gdb) show editing
Editing of command lines as they are typed is off.
(gdb)
vs:
$ ssh -t localhost gdb -q
(gdb) show editing
Editing of command lines as they are typed is on.
We now get, e.g.:
Running ../../../src/gdb/testsuite/gdb.base/filesym.exp ...
PASS: gdb.base/filesym.exp: complete on "filesy"
PASS: gdb.base/filesym.exp: completion list for "filesym"
PASS: gdb.base/filesym.exp: set breakpoint at filesym
gdb/testsuite/
2014-05-01 Pedro Alves <palves@redhat.com>
* boards/local-remote-host.exp: New file.
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/boards/local-remote-host.exp | 32 ++++++++++++++++++++++++++++++
2 files changed, 36 insertions(+)
create mode 100644 gdb/testsuite/boards/local-remote-host.exp
Comments
On 05/02/2014 12:27 AM, Pedro Alves wrote:
> +proc ${board}_spawn { board cmd } {
> + global board_info
> +
> + set remote [board_info $board hostname]
> + set username [board_info $board username]
> + set RSH [board_info $board rsh_prog]
> +
> + spawn $RSH -t -l $username $remote $cmd
> + set board_info($board,fileid) $spawn_id
> + return $spawn_id
> +}
Thanks for doing this, Pedro.
It is clever to pass '-t' option to RSH in ${board}_spawn. I thought
of passing '-t' to remote_spawn in dejagnu, but give up due the
complexity there.
@@ -1,5 +1,9 @@
2014-05-01 Pedro Alves <palves@redhat.com>
+ * boards/local-remote-host.exp: New file.
+
+2014-05-01 Pedro Alves <palves@redhat.com>
+
* boards/local-remote-host.exp: Rename to ...
* boards/local-remote-host-notty.exp: ... this.
new file mode 100644
@@ -0,0 +1,32 @@
+# Copyright 2014 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# Like local-remote-host-notty, but with readline/editing enabled.
+
+load_board_description "local-remote-host-notty"
+
+# Like standard_spawn, but force pseudo-tty allocation, with 'ssh -t'.
+
+proc ${board}_spawn { board cmd } {
+ global board_info
+
+ set remote [board_info $board hostname]
+ set username [board_info $board username]
+ set RSH [board_info $board rsh_prog]
+
+ spawn $RSH -t -l $username $remote $cmd
+ set board_info($board,fileid) $spawn_id
+ return $spawn_id
+}