diff mbox

rename "set debugvarobj" to "set debug varobj"

Message ID 1398785790-2059-1-git-send-email-tromey@redhat.com
State Committed
Headers

Commit Message

Tom Tromey April 29, 2014, 3:36 p.m. UTC 
  I think "set debugvarobj" has the wrong name.
It ought to be "set debug varobj", like gdb's other debug settings.

This patch makes the change.

I chose not to install deprecated aliases, since this is only a debug
setting; but if someone feels strongly about it I will add them.

Built and regtested on x86-64 Fedora 20.

2014-04-29  Tom Tromey  <tromey@redhat.com>

	* varobj.c (_initialize_varobj): Rename to "set debug varobj" and
	"show debug varobj".

2014-04-29  Tom Tromey  <tromey@redhat.com>

	* gdb.texinfo (Debugging Output): Rename to "set debug varobj" and
	"show debug varobj".
---
 gdb/ChangeLog       | 5 +++++
 gdb/doc/ChangeLog   | 5 +++++
 gdb/doc/gdb.texinfo | 4 ++--
 gdb/varobj.c        | 5 +++--
 4 files changed, 15 insertions(+), 4 deletions(-)

Comments

Eli Zaretskii April 29, 2014, 4:10 p.m. UTC | #1 
> From: Tom Tromey <tromey@redhat.com>
> Cc: Tom Tromey <tromey@redhat.com>
> Date: Tue, 29 Apr 2014 09:36:30 -0600
> 
> I think "set debugvarobj" has the wrong name.
> It ought to be "set debug varobj", like gdb's other debug settings.
> 
> This patch makes the change.

The documentation part is fine with me, thanks.
Joel Brobecker April 29, 2014, 5:58 p.m. UTC | #2 
> I chose not to install deprecated aliases, since this is only a debug
> setting; but if someone feels strongly about it I will add them.

FWIW, that seems fine to me.

> 2014-04-29  Tom Tromey  <tromey@redhat.com>
> 
> 	* varobj.c (_initialize_varobj): Rename to "set debug varobj" and
> 	"show debug varobj".
> 
> 2014-04-29  Tom Tromey  <tromey@redhat.com>
> 
> 	* gdb.texinfo (Debugging Output): Rename to "set debug varobj" and
> 	"show debug varobj".

Thanks for doing that, Tom!
Andrew Burgess April 30, 2014, 1:18 p.m. UTC | #3 
On 29/04/2014 4:36 PM, Tom Tromey wrote:
> +++ b/gdb/varobj.c
> @@ -2795,17 +2795,18 @@ void
>  _initialize_varobj (void)
>  {
>    int sizeof_table = sizeof (struct vlist *) * VAROBJ_TABLE_SIZE;
> +  struct cmd_list_element *c;

I don't think this extra line is needed.

Cheers,
Andrew

>    varobj_table = xmalloc (sizeof_table);
>    memset (varobj_table, 0, sizeof_table);
>  
> -  add_setshow_zuinteger_cmd ("debugvarobj", class_maintenance,
> +  add_setshow_zuinteger_cmd ("varobj", class_maintenance,
>  			     &varobjdebug,
>  			     _("Set varobj debugging."),
>  			     _("Show varobj debugging."),
>  			     _("When non-zero, varobj debugging is enabled."),
>  			     NULL, show_varobjdebug,
> -			     &setlist, &showlist);
> +			     &setdebuglist, &showdebuglist);
>  }
>  
>  /* Invalidate varobj VAR if it is tied to locals and re-create it if it is
>
Tom Tromey May 8, 2014, 2:35 p.m. UTC | #4 
>> +  struct cmd_list_element *c;

Andrew> I don't think this extra line is needed.

Thanks.  I was considering adding the deprecated aliases and then
decided against it, but forgot to undo what I did.

Tom
diff mbox

Patch

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 9d91075..623a954 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -22925,11 +22925,11 @@  message.
 @item show debug timestamp
 Displays the current state of displaying timestamps with @value{GDBN}
 debugging info.
-@item set debugvarobj
+@item set debug varobj
 @cindex variable object debugging info
 Turns on or off display of @value{GDBN} variable object debugging
 info. The default is off.
-@item show debugvarobj
+@item show debug varobj
 Displays the current state of displaying @value{GDBN} variable object
 debugging info.
 @item set debug xml
diff --git a/gdb/varobj.c b/gdb/varobj.c
index 10ef5b7..eab6030 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -2795,17 +2795,18 @@  void
 _initialize_varobj (void)
 {
   int sizeof_table = sizeof (struct vlist *) * VAROBJ_TABLE_SIZE;
+  struct cmd_list_element *c;
 
   varobj_table = xmalloc (sizeof_table);
   memset (varobj_table, 0, sizeof_table);
 
-  add_setshow_zuinteger_cmd ("debugvarobj", class_maintenance,
+  add_setshow_zuinteger_cmd ("varobj", class_maintenance,
 			     &varobjdebug,
 			     _("Set varobj debugging."),
 			     _("Show varobj debugging."),
 			     _("When non-zero, varobj debugging is enabled."),
 			     NULL, show_varobjdebug,
-			     &setlist, &showlist);
+			     &setdebuglist, &showdebuglist);
 }
 
 /* Invalidate varobj VAR if it is tied to locals and re-create it if it is