From patchwork Thu Apr 17 10:15:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 593 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx22.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id 7567436007C for ; Thu, 17 Apr 2014 03:15:46 -0700 (PDT) Received: by homiemail-mx22.g.dreamhost.com (Postfix, from userid 14314964) id 2D6B2496133E; Thu, 17 Apr 2014 03:15:46 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx22.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx22.g.dreamhost.com (Postfix) with ESMTPS id E51484A45110 for ; Thu, 17 Apr 2014 03:15:45 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type; q=dns; s=default; b=wBaSc 5IRGKFdi1Azuf7DSJFdn3Wac+v7AzJZpLXa+6nhFVfUoL9gTpKzGwR7Q1DzQEmvg zomamdbPevRSGZ0GADSq1mLjZAjiLOqo3kUPKP4UYMeFPq/OXgR3aSY8sbmNMEL0 47i8jWMVjlGlF419zsdqLTWEst0MIaeNpInmlc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type; s=default; bh=q+Y8H6KZ/Do Xiv2hZmKB09HQwGc=; b=FelX8d6p0nX6Tf1OUa5mMpTH9IrcYVXuL6/X9SPoWji JHzQ6lXx+3WHENW0htaceqAYPmJdH43LUJUW09meNZATiaPlPk3hXYdfMSCeQ3i9 KzRq+Jd3qwQ89OfIYnCPiP+zkFAwuSBgakpMuX1rmtzu/VfrcwGB6Ky7ej0+padE = Received: (qmail 31650 invoked by alias); 17 Apr 2014 10:15:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 31474 invoked by uid 89); 17 Apr 2014 10:15:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-gw2-out.broadcom.com Received: from mail-gw2-out.broadcom.com (HELO mail-gw2-out.broadcom.com) (216.31.210.63) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Apr 2014 10:15:32 +0000 Received: from irvexchcas06.broadcom.com (HELO IRVEXCHCAS06.corp.ad.broadcom.com) ([10.9.208.53]) by mail-gw2-out.broadcom.com with ESMTP; 17 Apr 2014 03:38:52 -0700 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS06.corp.ad.broadcom.com (10.9.208.53) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 17 Apr 2014 03:15:29 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.3.174.1; Thu, 17 Apr 2014 03:15:29 -0700 Received: from xl-cam-21.broadcom.com (xl-cam-21.cam.broadcom.com [10.177.132.81]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id BCE95EAD4E; Thu, 17 Apr 2014 03:15:28 -0700 (PDT) Received: by xl-cam-21.broadcom.com (Postfix, from userid 15136) id 1267B2CE89A0; Thu, 17 Apr 2014 11:15:28 +0100 (BST) From: Andrew Burgess To: CC: Andrew Burgess Subject: [PATCH v2 3/4] Deprecate frame_stop_reason_string. Date: Thu, 17 Apr 2014 11:15:15 +0100 Message-ID: <1397729716-8985-4-git-send-email-aburgess@broadcom.com> In-Reply-To: <533EC5B7.6080600@broadcom.com> References: <533EC5B7.6080600@broadcom.com> MIME-Version: 1.0 X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in gdb/ChangeLog: * frame.c (frame_stop_reason_string): Rename to ... (deprecated_frame_stop_reason_string): this. * frame.h (frame_stop_reason_string): Rename to ... (deprecated_frame_stop_reason_string): this. * stack.c (frame_info): Update call to frame_stop_reason_string. (backtrace_command_1): Update call to frame_stop_reason_string. * guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Update call to frame_stop_reason_string. * python/py-frame.c (gdbpy_frame_stop_reason_string): Update call to frame_stop_reason_string. ~ChangeLog~ --- gdb/frame.c | 2 +- gdb/frame.h | 5 +++-- gdb/guile/scm-frame.c | 2 +- gdb/python/py-frame.c | 2 +- gdb/stack.c | 4 ++-- 5 files changed, 8 insertions(+), 7 deletions(-) diff --git a/gdb/frame.c b/gdb/frame.c index 5f05968..5a6e0c7 100644 --- a/gdb/frame.c +++ b/gdb/frame.c @@ -2556,7 +2556,7 @@ get_frame_unwind_stop_reason (struct frame_info *frame) /* Return a string explaining REASON. */ const char * -frame_stop_reason_string (enum unwind_stop_reason reason) +deprecated_frame_stop_reason_string (enum unwind_stop_reason reason) { switch (reason) { diff --git a/gdb/frame.h b/gdb/frame.h index e451a93..7db5382 100644 --- a/gdb/frame.h +++ b/gdb/frame.h @@ -495,9 +495,10 @@ enum unwind_stop_reason enum unwind_stop_reason get_frame_unwind_stop_reason (struct frame_info *); -/* Translate a reason code to an informative string. */ +/* Translate a reason code to an informative string. This is DEPRECATED, + use frame_stop_reason_string instead. */ -const char *frame_stop_reason_string (enum unwind_stop_reason); +const char *deprecated_frame_stop_reason_string (enum unwind_stop_reason); /* Unwind the stack frame so that the value of REGNUM, in the previous (up, older) frame is returned. If VALUEP is NULL, don't diff --git a/gdb/guile/scm-frame.c b/gdb/guile/scm-frame.c index 6031a7f..ddd062c 100644 --- a/gdb/guile/scm-frame.c +++ b/gdb/guile/scm-frame.c @@ -944,7 +944,7 @@ gdbscm_unwind_stop_reason_string (SCM reason_scm) if (reason < UNWIND_FIRST || reason > UNWIND_LAST) scm_out_of_range (FUNC_NAME, reason_scm); - str = frame_stop_reason_string (reason); + str = deprecated_frame_stop_reason_string (reason); return gdbscm_scm_from_c_string (str); } diff --git a/gdb/python/py-frame.c b/gdb/python/py-frame.c index 8c80d39..e7fcfe3 100644 --- a/gdb/python/py-frame.c +++ b/gdb/python/py-frame.c @@ -588,7 +588,7 @@ gdbpy_frame_stop_reason_string (PyObject *self, PyObject *args) return NULL; } - str = frame_stop_reason_string (reason); + str = deprecated_frame_stop_reason_string (reason); return PyUnicode_Decode (str, strlen (str), host_charset (), NULL); } diff --git a/gdb/stack.c b/gdb/stack.c index da7d977..4fa9dd6 100644 --- a/gdb/stack.c +++ b/gdb/stack.c @@ -1528,7 +1528,7 @@ frame_info (char *addr_exp, int from_tty) reason = get_frame_unwind_stop_reason (fi); if (reason != UNWIND_NO_REASON) printf_filtered (_(" Outermost frame: %s\n"), - frame_stop_reason_string (reason)); + deprecated_frame_stop_reason_string (reason)); } else if (get_frame_type (fi) == TAILCALL_FRAME) puts_filtered (" tail call frame"); @@ -1847,7 +1847,7 @@ backtrace_command_1 (char *count_exp, int show_locals, int no_filters, reason = get_frame_unwind_stop_reason (trailing); if (reason >= UNWIND_FIRST_ERROR) printf_filtered (_("Backtrace stopped: %s\n"), - frame_stop_reason_string (reason)); + deprecated_frame_stop_reason_string (reason)); } } }