diff mbox

[02/12] vla: enable sizeof operator to work with variable length arrays

Message ID 1397495596-25364-3-git-send-email-brobecker@adacore.com
State Committed
Headers

Commit Message

Joel Brobecker April 14, 2014, 5:13 p.m. UTC 
  From: Sanimir Agovic <sanimir.agovic@intel.com>

In C99 the sizeof operator computes the size of a variable length array
at runtime (6.5.3.4 The sizeof operator). This patch reflects the semantic
change in the debugger.

We now are able to get the size of a vla:

1| void foo (size_t n) {
2|   int vla[n];
3| }

(gdb) p sizeof(vla)

yields N * sizeof(int).

gdb/ChangeLog:

	* eval.c (evaluate_subexp_for_sizeof) <OP_VAR_VALUE>: If the type
	passed to sizeof is dynamic evaluate the argument to compute the length.
---
 gdb/ChangeLog | 5 +++++
 gdb/eval.c    | 8 +++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index cf9a35d..1755609 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,4 +1,9 @@ 
 2014-04-14  Sanimir Agovic  <sanimir.agovic@intel.com>
+
+	* eval.c (evaluate_subexp_for_sizeof) <OP_VAR_VALUE>: If the type
+	passed to sizeof is dynamic evaluate the argument to compute the length.
+
+2014-04-14  Sanimir Agovic  <sanimir.agovic@intel.com>
 	    Joel Brobecker  <brobecker@adacore.com>
 
 	* dwarf2loc.c (dwarf2_locexpr_baton_eval): New function.
diff --git a/gdb/eval.c b/gdb/eval.c
index c1e47e0..85523cd 100644
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -3040,8 +3040,14 @@  evaluate_subexp_for_sizeof (struct expression *exp, int *pos)
       break;
 
     case OP_VAR_VALUE:
-      (*pos) += 4;
       type = SYMBOL_TYPE (exp->elts[pc + 2].symbol);
+      if (is_dynamic_type (type))
+	{
+	  val = evaluate_subexp (NULL_TYPE, exp, pos, EVAL_NORMAL);
+	  type = value_type (val);
+	}
+      else
+	(*pos) += 4;
       break;
 
     default: