From patchwork Tue May 30 20:46:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 70341 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E253A3854E56 for ; Tue, 30 May 2023 20:48:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E253A3854E56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1685479705; bh=KfggFHAybcT4U3+5aRvVJSfCS/jqQSOMQksgngIXpRk=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=MZ7nXEoLFISKeNWOPFCpiUkDHgU0t62XV/R7jFBDwiC1L2gkNerrZJjy3/q4qEyoO GQTKc+QgorMgVxHNKbYogpsJn59qOLFmOCeHnovkrZztrEQupbqD2gtJucc4xTVirn MpOcBibAmNs2h6LikOSW6qUYkXd3vhEYhtQI7hvg= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 120E03856967 for ; Tue, 30 May 2023 20:47:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 120E03856967 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-450-BMRSMrXzOia0i00hmrcKEQ-1; Tue, 30 May 2023 16:47:11 -0400 X-MC-Unique: BMRSMrXzOia0i00hmrcKEQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f608ea691fso28705955e9.3 for ; Tue, 30 May 2023 13:47:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685479630; x=1688071630; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KfggFHAybcT4U3+5aRvVJSfCS/jqQSOMQksgngIXpRk=; b=Wl2u1hoauO+/rmTdFfzXr+IfOa7nIHNIh+XGgyk+xtIisMcy20Acc4kItRmzijlJfQ bpP97JFrN3TqVw/nAzC+LHg8IHOleVtGf9jQQzQDjV5kG6rHnWxJI6jMEws1oDidAJmU CjjIw2/UuVp5j7TRYAOvT/KaFDdP8gym4NTzu3JNZeXLmd09t8Mg5AjREnc3kWatu0DH m3o4iHgNASMkpmN2arhEG7n/GrVOQPmjRs5vcsIw+NC87NI566pUW33pk3D0t+pUxR4q wy75Y+iJ6+HtrwuTaqPxvJUjuVeInEvtvfca0SbrkPgiTeyx9iTj3AINBXpI3dwcdVnh 0YGw== X-Gm-Message-State: AC+VfDzGt0WNOttnuVZFasRKS+ydB1pzxBhokU4z3WFmit6y0/KXpSs8 cN57nXwkoifYLSbpaYuYsSze4qusXfIZqUeeAJBwfCB4RrBRF6OrXW5qPIB/qMuGGsYAcq1mgQc HxHJC8IKH6qiAZ8So/qyj73+DK67taTnnh/iC2ek2R9EbajAiczJ6hpdqInoLWzSBr+VZ5/jfsz Ge3WnJlg== X-Received: by 2002:a05:600c:2204:b0:3f6:c7b:d3c8 with SMTP id z4-20020a05600c220400b003f60c7bd3c8mr3521843wml.16.1685479630336; Tue, 30 May 2023 13:47:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ50gYYaflFFUP0xw9heFeU5IiM8Rpu6R14jKRiOyjVU10HvYWjaAmu7IUR20E52dPG7KjABmg== X-Received: by 2002:a05:600c:2204:b0:3f6:c7b:d3c8 with SMTP id z4-20020a05600c220400b003f60c7bd3c8mr3521834wml.16.1685479630062; Tue, 30 May 2023 13:47:10 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id f9-20020a1c6a09000000b003f4272c2d0csm18296791wmc.36.2023.05.30.13.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 13:47:09 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv3 8/9] gdb: remove tracepoint_probe_create_sals_from_location_spec Date: Tue, 30 May 2023 21:46:52 +0100 Message-Id: <117ecc2576438f9754b752f0925dde8730998352.1685479504.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" The tracepoint_probe_create_sals_from_location_spec function just forwards all its arguments to bkpt_probe_create_sals_from_location_spec, and is only used in one place. Lets delete tracepoint_probe_create_sals_from_location_spec and replace it with bkpt_probe_create_sals_from_location_spec. There should be no user visible changes after this commit. --- gdb/breakpoint.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 79a55d66f08..4343016b6b2 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -221,9 +221,6 @@ static bool strace_marker_p (struct breakpoint *b); static void bkpt_probe_create_sals_from_location_spec (location_spec *locspec, struct linespec_result *canonical); -static void tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical); const struct breakpoint_ops code_breakpoint_ops = { @@ -238,10 +235,11 @@ static const struct breakpoint_ops bkpt_probe_breakpoint_ops = create_breakpoints_sal, }; -/* Tracepoints set on probes. */ +/* Tracepoints set on probes. We use the same methods as for breakpoints + on probes. */ static const struct breakpoint_ops tracepoint_probe_breakpoint_ops = { - tracepoint_probe_create_sals_from_location_spec, + bkpt_probe_create_sals_from_location_spec, create_breakpoints_sal, }; @@ -11994,17 +11992,6 @@ tracepoint::print_recreate (struct ui_file *fp) const gdb_printf (fp, " passcount %d\n", pass_count); } -/* Virtual table for tracepoints on static probes. */ - -static void -tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical) -{ - /* We use the same method for breakpoint on probes. */ - bkpt_probe_create_sals_from_location_spec (locspec, canonical); -} - void dprintf_breakpoint::re_set () {