From patchwork Fri Jan 24 21:22:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 37535 Received: (qmail 107440 invoked by alias); 24 Jan 2020 21:22:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 107360 invoked by uid 89); 24 Jan 2020 21:22:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2205 X-HELO: mail-wr1-f49.google.com Received: from mail-wr1-f49.google.com (HELO mail-wr1-f49.google.com) (209.85.221.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Jan 2020 21:22:30 +0000 Received: by mail-wr1-f49.google.com with SMTP id b6so3735626wrq.0 for ; Fri, 24 Jan 2020 13:22:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=6++IHDk1Gi1Y70SsZgs6yY1/iDVscb90xegf0MbToY4=; b=EElcEWx8hSqyGWGc0rWIeBicWk6tIvxjug3Gz6CML5OA+WcvOSe5j/LpFNX3rW7EkH eLCtvA+WqSJdd834ih7YS00hU9+jg5aNpPQ2jOlG9gYrHoQoEqVnHJpklhIRciwrqndS kuyrx4303kZl+GtNiReSnl9Fcv+pYFonxaGrxwSJnBoO0V2h/jlqTUAP9tudJQqAB4C/ 19jlzEkGF1faZxhAnrkfDmJBapLQuI3/+UcNvhtVWdPuLwFp3kTXJeslGm/08pPQ1u9L ZpNrHJaIUgGbkqzW/8srLp8kZX9yXnzsUyXTGEXEDifkZ8aOdIvmaACWIYK/fHmq2y1y zMGQ== Return-Path: Received: from localhost (host86-191-239-73.range86-191.btcentralplus.com. [86.191.239.73]) by smtp.gmail.com with ESMTPSA id h2sm9876876wrt.45.2020.01.24.13.22.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Jan 2020 13:22:27 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Shahab.Vahedi@synopsys.com, palves@redhat.com, tom@tromey.com, Andrew Burgess Subject: [PATCH 1/2] gdb/tui: Update help text for scroll commands Date: Fri, 24 Jan 2020 21:22:20 +0000 Message-Id: <0e5ed15995ac816d3b6f650e1c3e362e14d0bd21.1579900754.git.andrew.burgess@embecosm.com> In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes GDB has some commands ('+', '-', '<', and '>') for scrolling the SRC and ASM TUI windows from the CMD window, however the help text for these commands lists the arguments in the wrong order. This commit updates the help text to match how GDB actually works, and also extends the text to describe what the arguments mean, and what the defaults are. There should be no change in GDBs functionality after this commit. gdb/ChangeLog: * tui/tui-win.c (_initialize_tui_win): Update help text for '+', '-', '<', and '>' commands. Change-Id: Ib2624891de1f4ba983838822206304e4c3ed982e --- gdb/ChangeLog | 5 +++++ gdb/tui/tui-win.c | 16 ++++++++++++---- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c index 8b7c39916a3..185ae26f698 100644 --- a/gdb/tui/tui-win.c +++ b/gdb/tui/tui-win.c @@ -1063,16 +1063,24 @@ FOCUS_USAGE set_cmd_completer (cmd, focus_completer); add_com ("+", class_tui, tui_scroll_forward_command, _("\ Scroll window forward.\n\ -Usage: + [WIN] [N]")); +Usage: + [N] [WIN]\n\ +Scroll window WIN N lines forwards. Both WIN and N are optional, N\n\ +defaults to 1, and WIN defaults to the currently focused window.")); add_com ("-", class_tui, tui_scroll_backward_command, _("\ Scroll window backward.\n\ -Usage: - [WIN] [N]")); +Usage: - [N] [WIN]\n\ +Scroll window WIN N lines backwards. Both WIN and N are optional, N\n\ +defaults to 1, and WIN defaults to the currently focused window.")); add_com ("<", class_tui, tui_scroll_left_command, _("\ Scroll window text to the left.\n\ -Usage: < [WIN] [N]")); +Usage: < [N] [WIN]\n\ +Scroll window WIN N characters left. Both WIN and N are optional, N\n\ +defaults to 1, and WIN defaults to the currently focused window.")); add_com (">", class_tui, tui_scroll_right_command, _("\ Scroll window text to the right.\n\ -Usage: > [WIN] [N]")); +Usage: > [N] [WIN]\n\ +Scroll window WIN N characters right. Both WIN and N are optional, N\n\ +defaults to 1, and WIN defaults to the currently focused window.")); /* Define the tui control variables. */ add_setshow_enum_cmd ("border-kind", no_class, tui_border_kind_enums,