From patchwork Wed Mar 27 21:34:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 32032 Received: (qmail 102657 invoked by alias); 27 Mar 2019 21:35:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 100610 invoked by uid 89); 27 Mar 2019 21:35:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=unavailable version=3.3.1 spammy=re-use X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Mar 2019 21:35:08 +0000 Received: by mail-wr1-f68.google.com with SMTP id j9so20325525wrn.6 for ; Wed, 27 Mar 2019 14:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=42ENFCVqXC5rCuui7/+NGQxOoVd9VZy2RWp4qZAmtms=; b=EG+F5nE+CvkmrSX4ko5CKvU2k4hYNLHi+fIklPokwjyLELLQ8leK8EDcRVRd0y78X1 j95pEzZfTrdOolqlGTdEB7j3bwymeQpShjUI2Bk/o72Y949smCOjhY+xKZfYIgfvaqE0 Gjhlhbwn5lZAqofw5yQ2clu6rLMMmf3FehvqKRD1UifOogWllX/qnS6cDF8/xyvtaRpe 3HIk3LJPFkMNbIcPVIERr1KTPWIsN1c7TqlPEQU1sEqgrX0b6eUUW6taoH04abu3vAN9 79k2/LYlA3dOEnmv06IHJoOsDxgDVBw4zwefNoUB8L+dhC9Shoh2kx6pS0XA7PcHanCG 93qw== Return-Path: Received: from localhost (host81-151-161-58.range81-151.btcentralplus.com. [81.151.161.58]) by smtp.gmail.com with ESMTPSA id t187sm1273495wma.1.2019.03.27.14.35.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 14:35:04 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: kevinb@redhat.com, macro@linux-mips.org, brobecker@adacore.com, green@moxielogic.com, qiyao@sourceware.org, shorne@gmail.com, Andrew Burgess Subject: [PATCH 22/25] gdb/vax: Use default gdbarch methods where possible Date: Wed, 27 Mar 2019 21:34:18 +0000 Message-Id: <06985db67a06a35fd0f9b4f8d4cb1d70ee6f4baf.1553721879.git.andrew.burgess@embecosm.com> In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes Make use of the default gdbarch method gdbarch_unwind_pc where possible. I have not tested this change but, by inspecting the code, I believe the default methods are equivalent to the code being deleted. gdb/ChangeLog: * vax-tdep.c (vax_unwind_pc): Delete. (vax_gdbarch_init): Don't register deleted function with gdbarch. --- gdb/ChangeLog | 5 +++++ gdb/vax-tdep.c | 7 ------- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/gdb/vax-tdep.c b/gdb/vax-tdep.c index 6046c0e98b4..e4a565df050 100644 --- a/gdb/vax-tdep.c +++ b/gdb/vax-tdep.c @@ -437,11 +437,6 @@ vax_frame_num_args (struct frame_info *frame) return get_frame_memory_unsigned (frame, args, 1); } -static CORE_ADDR -vax_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame) -{ - return frame_unwind_register_unsigned (next_frame, VAX_PC_REGNUM); -} /* Initialize the current architecture based on INFO. If possible, re-use an @@ -502,8 +497,6 @@ vax_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) set_gdbarch_deprecated_function_start_offset (gdbarch, 2); set_gdbarch_believe_pcc_promotion (gdbarch, 1); - set_gdbarch_unwind_pc (gdbarch, vax_unwind_pc); - frame_base_set_default (gdbarch, &vax_frame_base); /* Hook in ABI-specific overrides, if they have been registered. */