From patchwork Sun Oct 27 09:19:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 99677 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 70D743858C2B for ; Sun, 27 Oct 2024 09:20:50 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id AC12E3858CDA for ; Sun, 27 Oct 2024 09:19:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AC12E3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AC12E3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730020780; cv=none; b=kL+xlELwBrIbeH+jRTa+iCm0vAC7GzmvdbfgEiTr7wHNcvzuA8sl9gDDEVBf7GZDpVI9mXIWsIGHjpiAZg4nnQPTCJk8IvHZDujzbG3wPgQgJeyY5LQXk24NddNHzhtWTNS2cCGmJ1uN2Ft7lgEdHI02OacJJXm1epRe7n2WhpQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730020780; c=relaxed/simple; bh=0XXXMsG1RUwMDCgGCburuNSC9wSN+/nVIWWZ0gol/oM=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=AzEuE8jUR+/mR3sJZmuROQCh+7OlpkTe7mJfMZq92DHQPERvpq65Wm9Lw2642cSHt/TnVSjZFxbDNopovBjGGS3mRdggqwN0Vvp21mgf+XHmeArl+Vs8i8YJS9tvEG3KjzjRm3v0L4bvDDKq9NBmweyAgkar51Hy8eFkl3E0igk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730020776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ms/syLbY3x49n1/ojnBgBx6kM9OPBSutiK0xZM3IokU=; b=BoGP0j14RbYzJGEWWqddY1fAy/UtvF+EfPRRs3j0HVHswCrYDmC5QNM4pCZ7H6/HmP998/ YzR+TeZmYRNZ00K+wsk/wTHZ5Xl1WXUGMNjfBGGPr4pIOLuBl7WGNQEtRuuHT83oMn4Dd6 U/feMdDTLNVvXV4TtM8cceZc07mzc5M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-TjsxbvkiP9izpksq9gFjcg-1; Sun, 27 Oct 2024 05:19:22 -0400 X-MC-Unique: TjsxbvkiP9izpksq9gFjcg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-431518e6d8fso24945965e9.0 for ; Sun, 27 Oct 2024 02:19:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730020760; x=1730625560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ms/syLbY3x49n1/ojnBgBx6kM9OPBSutiK0xZM3IokU=; b=gVCzzts8gTNN+qyipKFe20ilMIwsz8phsXnm9D24jzNJcNE/TTLogbSEiFGI3DIpn0 3I148Y7jiMlK2HDkfpGwrxT5rhIjbydPRgJGxizerlICiJcsGXHQ9Gw13L3k1LDAx91v w3QRcEtj1nmkirXXiz+H1EF0VmF69tVKhUoyXa5OLZOUX3Vkilr6Y5ppLoJZZvklOIPh TvhSPIipfv0CnaeCQKJD5m0ijM/TAvcR0C/AnAybE9XmiCnlHxqqSNPi/NPq5a8rTJIL i7YCMJnEnvy0gzeL+MfJBKDDzAkoXy6k4m/f/SqSM/0xxeFomrtyUy9DBiwx7OcMFMbN 5iAg== X-Gm-Message-State: AOJu0Ywt3hZdNW/OPTou7WCY7QTcJ63qG+FLk0LAOle4lUU/MKE/pNtP dAWslzWNsftXa9tUM3rd/sWunj6i6zZlUZ9iX0uZFdvlsqNNZAexInOFMIj51Yk4mR7/3RCQTA1 N8zoImK99ijzNj8Op0FwDpZNm68v1PTlMo0mj70YQaMyMQSX8B3ZwkmILeoyZFkbW2p0OYjuwGt 12/zUSU2T9gQpkOaUQlB1KOi3L5LGi5CRaZ12jdeftNr8= X-Received: by 2002:a05:600c:3b86:b0:42c:bae0:f065 with SMTP id 5b1f17b1804b1-4319ac77f48mr39643955e9.5.1730020760459; Sun, 27 Oct 2024 02:19:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHf58ByEbvzih0nuP/SeUnzJi/ve2g+gCfs+pvzFV0UlGe9PhtyKxXSVMkGfPeAtyQn9VdyqQ== X-Received: by 2002:a05:600c:3b86:b0:42c:bae0:f065 with SMTP id 5b1f17b1804b1-4319ac77f48mr39643705e9.5.1730020759817; Sun, 27 Oct 2024 02:19:19 -0700 (PDT) Received: from localhost (197.209.200.146.dyn.plus.net. [146.200.209.197]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38058b1c8a9sm6311784f8f.12.2024.10.27.02.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 02:19:18 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv1 1/2] gdb: make core_target_open static Date: Sun, 27 Oct 2024 09:19:13 +0000 Message-Id: <04948a031ad2d72f09ea3135b8157ef6cb8b0de5.1730020661.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org The core_target_open function is only used in corelow.c, so lets make it static. There should be no user visible changes after this commit. --- gdb/corelow.c | 8 ++++++-- gdb/gdbcore.h | 4 ---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/corelow.c b/gdb/corelow.c index 5820ffed332..3e4e3304997 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -59,6 +59,10 @@ #define O_LARGEFILE 0 #endif +/* Forward declarations. */ + +static void core_target_open (const char *arg, int from_tty); + /* A mem_range and the build-id associated with the file mapped into the given range. */ @@ -849,9 +853,9 @@ locate_exec_from_corefile_build_id (bfd *abfd, int from_tty) } } -/* See gdbcore.h. */ +/* Open and set up the core file bfd. */ -void +static void core_target_open (const char *arg, int from_tty) { const char *p; diff --git a/gdb/gdbcore.h b/gdb/gdbcore.h index 782643acf56..eb318d557d4 100644 --- a/gdb/gdbcore.h +++ b/gdb/gdbcore.h @@ -124,10 +124,6 @@ extern void (*deprecated_file_changed_hook) (const char *filename); extern bool write_files; -/* Open and set up the core file bfd. */ - -extern void core_target_open (const char *arg, int from_tty); - extern void core_file_command (const char *filename, int from_tty); extern void exec_file_attach (const char *filename, int from_tty);