From patchwork Tue Nov 7 18:18:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 79350 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B4153858035 for ; Tue, 7 Nov 2023 18:19:26 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2E2913858CDB for ; Tue, 7 Nov 2023 18:18:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2E2913858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2E2913858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699381140; cv=none; b=UmArZDthZr8vmgSbNMKjuy6HK1jj+WM8w9F7iQq34u/ykQOY3Ozi2UuAo+kJ2f43pHw560z62WZdqCCNOm2vt/g4w3bvY/iRk4fA0vkauJrwGLAeAtK3rw+3qnxzCPANGLDCEi2js76fyHkqZwRekpMN018Ax6d7S1aaFPlVelg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699381140; c=relaxed/simple; bh=5OuHH+df8HS2j7pA6fsjcN6Rmx6v8WaZX6f8zBV9kuU=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=mQLztIpUuM0KEkeVdtuHWJl2QjLHXViJXZGXKPw/fO5pyoKxEXLI+/ALl9sjYXxTg1LUgfEpJCiY5fFcd11qYBkyFoPyl4RDKxoNLmoGuDzcdMYwiRAMP/5TCUspBWTHxGqlBJI02JaODn5H7cqjujdwbQ9JrY05iZ2gO9oUnXA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699381138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n1DHofxdpg/JTmZfLd9MeFN44Srikmbrn2VIAnnJh0M=; b=SFGw3R/zJxIZGoJgU+IH2UZKmOwBDrmoApq+CKB165kCwkk4g8ak4Kc5qXwEUiJfhe9Ewf mQjuigCgQy8xSU9cKgUz1OAjCb787bMSqM6817AXg2gG3NG+h0ot4IKm35pI4b7waLh7bW LqhYjtFmywZjVlUqezTZBI6vvJDnG4g= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-90--7K6TDfVO0iwKI7AbD4Qog-1; Tue, 07 Nov 2023 13:18:57 -0500 X-MC-Unique: -7K6TDfVO0iwKI7AbD4Qog-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5082705f6dfso6002834e87.2 for ; Tue, 07 Nov 2023 10:18:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699381135; x=1699985935; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n1DHofxdpg/JTmZfLd9MeFN44Srikmbrn2VIAnnJh0M=; b=W1kOFGZ5zljr6ID5pOWpyDSEa+SFE4YmUSlOSdfFA7tIBsEHaTd/JNJCj1MVlj5hV3 Y47o9b81XENP6wfxxTWH801wUan77WQ7WFXtzVRBL7kmYTpKAR5HjE3cfx1Cbq9amL+/ skKAHpiJCVdXRa4C5tjNVZN//S8h/bYY0P5P+rI2oAOmEmlZo/m2iuyk9FwouSvZqNh6 uuzvge0caDX67gbO+edQ/E7Zym5f/r0JxsQQrydXnIAhnz4L1Cx+Z/W/AjorhJy2WHYz 450a+vcSuHxdUkIbxSK7QKjk+XTgefQuu9xHJmMTxlED4BWvmnHs6Kde6w8hJm+MhJ6C r99w== X-Gm-Message-State: AOJu0YySSK9zacIYv6+ZCCsisTr2p9dU+uQR32eLI9o9e8XxJvpHPbAh kCCduqUfv2datlRL7Ouk8c5iRouYgwPvrPYSq+v4Nrvn3z81lP36hsr7h/46b38Kg5JGImHWSAt dE3yfb6Vc+KP03OWLFAor1VVWXWxEMzr+yscmrESHA6Jr8HzMLoAr8xgoKLqmlJrVgqdCyxof3K REk1JeOA== X-Received: by 2002:a05:6512:3092:b0:503:8fa:da21 with SMTP id z18-20020a056512309200b0050308fada21mr31955416lfd.43.1699381135285; Tue, 07 Nov 2023 10:18:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFKlCyWH2Aa+9DCggsuu7m9ZKP1FtdtL7woe91bQ8NgrNnoP5Q64VGWP5UKPZF00PuFPLFoog== X-Received: by 2002:a05:6512:3092:b0:503:8fa:da21 with SMTP id z18-20020a056512309200b0050308fada21mr31955399lfd.43.1699381134888; Tue, 07 Nov 2023 10:18:54 -0800 (PST) Received: from localhost (105.226.159.143.dyn.plus.net. [143.159.226.105]) by smtp.gmail.com with ESMTPSA id m17-20020a056000181100b0032da6f17ffdsm2995950wrh.38.2023.11.07.10.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 10:18:54 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 1/2] gdb/testsuite: log 'make check' command in make-check-all.sh Date: Tue, 7 Nov 2023 18:18:48 +0000 Message-Id: <047bb72318595c2c3e2435bc0b8ff062515c28e3.1699381067.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I have been making more use of the make-check-all.sh script to run tests against all boards. But one thing is pretty annoying. When a test fails on some random board, I have to run make-check-all.sh with --verbose and --dry-run in order to see what RUNTESTFLAGS I should be using. I always run with --keep-results on, so, in this commit, I propose that, when --keep-results is on the 'make check' command will be written out to a file within the stored results directory, like: check-all/BOARD_NAME/make-check.sh then, if I want to rerun a test, I can just: sh check-all/BOARD_NAME/make-check.sh and the test will be re-run for me. --- gdb/testsuite/make-check-all.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/testsuite/make-check-all.sh b/gdb/testsuite/make-check-all.sh index 7d8adb58e87..6d67567758f 100755 --- a/gdb/testsuite/make-check-all.sh +++ b/gdb/testsuite/make-check-all.sh @@ -186,6 +186,10 @@ do_tests () mkdir -p "$dir" cp gdb.sum gdb.log "$dir" + + # Record the 'make check' command to enable easy re-running. + echo "make check RUNTESTFLAGS=\"${rtf[*]} ${tests[*]}\"" \ + > "$dir/make-check.sh" fi }