From patchwork Sun Sep 25 08:42:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tsukasa OI X-Patchwork-Id: 57995 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A749E385801A for ; Sun, 25 Sep 2022 08:43:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A749E385801A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664095403; bh=q78jJd9DqGMM7qAXcz6vcnrQG2Zf1oimYv5OZDRvaXU=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wuJntXgRp4QdhXHiAwZgTMdGzYT/M8imHZhRHWmGCLC8MR1YtbgN79MYvLNfTvp1B PwWcOFgb2VqaLiU+9mbRAPy7qQv7m8eoadkgeEAw5ShlYVLcKC7fidds4OlwbaarIB bc+LXqWVFo7ZpbHmWyDmYVzzG3LcxGoGy0vF2ycw= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 9E15C385840C for ; Sun, 25 Sep 2022 08:42:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9E15C385840C Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 8DC8E300089; Sun, 25 Sep 2022 08:42:51 +0000 (UTC) To: Tsukasa OI , Andrew Burgess , Mike Frysinger Subject: [PATCH v2 3/5] sim: Suppress non-literal printf warning Date: Sun, 25 Sep 2022 08:42:04 +0000 Message-Id: <01dad5247fe31088813a45d200500a3ed2cdbce9.1664095312.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tsukasa OI via Gdb-patches From: Tsukasa OI Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). However, non-literal format string is completely safe here. We have "include/diagnostics.h" to suppress certain warnings only when necessary. Because DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL can suppress warnings when the format string of a printf-like function is not a literal, this commit adds this macro (only where necessary) to suppress this warning. sim/ChangeLog: * common/sim-hw.c (hw_vabort): Suppress non-literal printf warning by using DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL. --- sim/common/sim-hw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sim/common/sim-hw.c b/sim/common/sim-hw.c index cece5638bc9..36f355d2262 100644 --- a/sim/common/sim-hw.c +++ b/sim/common/sim-hw.c @@ -425,10 +425,13 @@ hw_vabort (struct hw *me, strcat (msg, ": "); strcat (msg, fmt); /* report the problem */ + DIAGNOSTIC_PUSH + DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL sim_engine_vabort (hw_system (me), STATE_HW (hw_system (me))->cpu, STATE_HW (hw_system (me))->cia, msg, ap); + DIAGNOSTIC_POP } void