Message ID | 001a11c2e548981b14051b0098eb@google.com |
---|---|
State | New |
Headers | show |
> Date: Thu, 16 Jul 2015 16:30:57 +0000 > From: Doug Evans <dje@google.com> > > "make info" is currently giving the following warning: > > makeinfo -DHAVE_MAKEINFO_CLICK -I ../../../random-cleanup/gdb/doc -o > stabs.info ../../../random-cleanup/gdb/doc/stabs.texinfo > ../../../random-cleanup/gdb/doc/stabs.texinfo:4065: warning: undefined > flag: GDBN > > This needs to go into the 7.10 branch as well. Thanks, please do.
On Thu, 2015-07-16 at 16:30 +0000, Doug Evans wrote: > 2015-07-16 Doug Evans <dje@google.com> > > * stabs.texinfo: @include gdb-cfg.texi. > > diff --git a/gdb/doc/stabs.texinfo b/gdb/doc/stabs.texinfo > index 15c4152..c4ea037 100644 > --- a/gdb/doc/stabs.texinfo > +++ b/gdb/doc/stabs.texinfo > @@ -3,6 +3,10 @@ > @setchapternewpage odd > @settitle STABS > > +@c man begin INCLUDE > +@include gdb-cfg.texi > +@c man end > + > @c @finalout > > @c This is a dir.info fragment to support semi-automated addition of This patch breaks my parallel gdb builds (though the bug may be a latent one that this change finally causes to trigger). On my machine my parallel GDB build dies with: ./gdb-cfg.texi:16: @include `GDBvn.texi': No such file or directory. And then later in the log I see: mv GDBvn.new GDBvn.texi I think there is a missing dependency in the doc/Makefile.in to say that GDBvn.texi needs to be built before gdb-cfg.texi. Steve Ellcey sellcey@imgtec.com
On Fri, Jul 17, 2015 at 3:30 PM, Steve Ellcey <sellcey@imgtec.com> wrote: > On Thu, 2015-07-16 at 16:30 +0000, Doug Evans wrote: > >> 2015-07-16 Doug Evans <dje@google.com> >> >> * stabs.texinfo: @include gdb-cfg.texi. >> >> diff --git a/gdb/doc/stabs.texinfo b/gdb/doc/stabs.texinfo >> index 15c4152..c4ea037 100644 >> --- a/gdb/doc/stabs.texinfo >> +++ b/gdb/doc/stabs.texinfo >> @@ -3,6 +3,10 @@ >> @setchapternewpage odd >> @settitle STABS >> >> +@c man begin INCLUDE >> +@include gdb-cfg.texi >> +@c man end >> + >> @c @finalout >> >> @c This is a dir.info fragment to support semi-automated addition of > > This patch breaks my parallel gdb builds (though the bug may be a latent > one that this change finally causes to trigger). On my machine my > parallel GDB build dies with: > > ./gdb-cfg.texi:16: @include `GDBvn.texi': No such file or directory. > > And then later in the log I see: > > mv GDBvn.new GDBvn.texi > > I think there is a missing dependency in the doc/Makefile.in to say that > GDBvn.texi needs to be built before gdb-cfg.texi. Bleah. I think we just need to update STABS_DOC_BUILD_INCLUDES to be like GDB_DOC_BUILD_INCLUDES. I'll take care of it. Thanks for the report.
diff --git a/gdb/doc/stabs.texinfo b/gdb/doc/stabs.texinfo index 15c4152..c4ea037 100644 --- a/gdb/doc/stabs.texinfo +++ b/gdb/doc/stabs.texinfo @@ -3,6 +3,10 @@ @setchapternewpage odd @settitle STABS +@c man begin INCLUDE +@include gdb-cfg.texi +@c man end + @c @finalout @c This is a dir.info fragment to support semi-automated addition of