[3/5,doc,RFA] : Enhancements to "flags": main patch

Message ID 001a1146145abecc20052e1d7f6b@google.com
State New, archived
Headers

Commit Message

Doug Evans March 15, 2016, 9:58 p.m. UTC
  Eli Zaretskii writes:
  > > Date: Thu, 03 Mar 2016 18:46:32 +0000
  > > From: Doug Evans <dje@google.com>
  > > Cc: gdb-patches@sourceware.org, cole945@gmail.com
  > >
  > > Eli Zaretskii writes:
  > >   > > Date: Mon, 29 Feb 2016 23:07:09 +0000
  > >   > > From: Doug Evans <dje@google.com>
  > >   > > Cc: cole945@gmail.com
  > >   > >
  > >   > >   @cindex <struct>
  > >   > > +@cindex <flags>
  > >   > >   If a register's value is composed from several separate values,
  > > define
  > >   > > -it with a structure type.  There are two forms of the  
@samp{<struct>}
  > >   > > -element; a @samp{<struct>} element must either contain only  
bitfields
  > >   > > -or contain no bitfields.  If the structure contains only  
bitfields,
  > >   > > -its total size in bytes must be specified, each bitfield must  
have an
  > >   > > -explicit start and end, and bitfields are automatically  
assigned an
  > >   > > -integer type.  The field's @var{start} should be less than or
  > >   > > -equal to its @var{end}, and zero represents the least  
significant bit.
  > >   > > +it with either a structure type or a flags type.
  > >   > > +A flags type may only contain bitfields.
  > >   > > +A structure type may either contain only bitfields or contain no
  > > bitfields.
  > >   > > +If the value contains only bitfields, its total size in bytes  
must be
  > >   > > +specified.
  > >   >
  > >   > This drops some of the previous description.  Is it no longer  
correct?
  > >
  > > The text has moved and been reorganized a bit, that's all.
  >
  > It looked to me as if not all of the old text was elsewhere.
  > Apologies.

No worries.

I committed the series.
I forgot a NEWS entry, bleah.
Let me know if you want something reworded.
  

Comments

Eli Zaretskii March 16, 2016, 3:36 a.m. UTC | #1
> Date: Tue, 15 Mar 2016 21:58:35 +0000
> From: Doug Evans <dje@google.com>
> Cc: gdb-patches@sourceware.org, cole945@gmail.com
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,9 @@
>    *** Changes since GDB 7.11
> 
> +* GDB now supports multibit bitfields and enums in target register
> +  descriptions.
> +
>   * New Python-based convenience function $_as_string(val), which returns
>     the textual representation of a value.  This function is especially
>     useful to obtain the text label of an enum value.

OK.
  

Patch

diff --git a/gdb/NEWS b/gdb/NEWS
index 928f70c..34c5a8d 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -3,6 +3,9 @@ 
   *** Changes since GDB 7.11

+* GDB now supports multibit bitfields and enums in target register
+  descriptions.
+
  * New Python-based convenience function $_as_string(val), which returns
    the textual representation of a value.  This function is especially
    useful to obtain the text label of an enum value.