From patchwork Thu Oct 6 16:36:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Love X-Patchwork-Id: 55189 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 144D738650D0 for ; Thu, 6 Oct 2022 16:37:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 144D738650D0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1665074249; bh=OBUbzTvjiUbGZA/bnyZHWA3dQsQLvSL+BiHnD8o57zM=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=CBXP73rOxtQ9kudu/Onxys20LFkVyS5UA0dceKHgzU1+PXwJwfSjUf3bYFxQoudDb Wfk7BB4cQgwdkRec7I9jCE3ecXDjPGqaxW4ffzn1hMrVyMIXtzM49S+6M9LKTCq4Z4 C4/5+gyGeQGASdwIO1Ym6ECqskwxgQDBkLKWB878= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id F3D173858D32 for ; Thu, 6 Oct 2022 16:37:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F3D173858D32 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 296GWhRu001243 for ; Thu, 6 Oct 2022 16:37:04 GMT Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3k22mtg4he-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 06 Oct 2022 16:37:03 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 296GZgnn015306 for ; Thu, 6 Oct 2022 16:37:03 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma02dal.us.ibm.com with ESMTP id 3jxd6amc6h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 06 Oct 2022 16:37:03 +0000 Received: from smtpav05.wdc07v.mail.ibm.com ([9.208.128.117]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 296Gb1DL17498650 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 6 Oct 2022 16:37:02 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 85E9658043; Thu, 6 Oct 2022 16:37:01 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A382C58059; Thu, 6 Oct 2022 16:37:00 +0000 (GMT) Received: from sig-9-65-248-8.ibm.com (unknown [9.65.248.8]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 6 Oct 2022 16:37:00 +0000 (GMT) Message-ID: Subject: [PATCH 0/2] PowerPC, fix support for printing the function return value for non-trivial values. To: Ulrich Weigand , "gdb-patches@sourceware.org" Date: Thu, 06 Oct 2022 09:36:59 -0700 In-Reply-To: <5405a79ecd6ed34646ad77eed0779063ee222d37.camel@de.ibm.com> References: <28ce795ca489f69829207b2a7a535cf7f77f6dd8.camel@us.ibm.com> <87a6dslkip.fsf@tromey.com> <49c0eb4ef5a984b42f3a9e89faa8001a87ecb3ba.camel@de.ibm.com> <6ca2276426343756e103995e07ff951d6e26837b.camel@us.ibm.com> <939797b94ab71f3f7356747d84a1515939cb3dcc.camel@de.ibm.com> <1edb818bd2873a3fa5278f28131089d228a0a4f6.camel@de.ibm.com> <7c884a865d06890cb325225c65d7a52fdfbd20d2.camel@us.ibm.com> <846ca96309d2732d3db0e4c323a81105c098fa5f.camel@de.ibm.com> <5a858dd7b957ecf45cf5b00ffc140a839c8ef023.camel@us.ibm.com> <25f2380ced176f58a8e3ea9b70c7e7786988d650.camel@us.ibm.com> <2b0481466e9ecc33d52c74c3a3b4babb05435f47.camel@de.ibm.com> <71370ce02bd57827d3b7958772b1594d3591bd16.camel@de.ibm.com> <148d8d3efcc8d110119e566027bfd0c65dd02525.camel@de.ibm.com> <8decd662134d57e8caf43960a1cdc47723e2bfe3.camel@us.ibm.com> <79d82ed277308ed5ce312bff398e770ab234390a.camel@us.ibm.com> <63f21a897f452d81a73fb386cb99110a359ef0b7.camel@de.ibm.com> <97275f61ef101a12cde8e5a45008ed8e479424eb.camel@us.ibm.com> <191f5826b228a7614c084c9704b086851d418c78.camel@us.ibm.com> <5405a79ecd6ed34646ad77eed0779063ee222d37.camel@de.ibm.com> X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: JBfTmdaTguOR2yduyYZaAKdUag2mEqjd X-Proofpoint-ORIG-GUID: JBfTmdaTguOR2yduyYZaAKdUag2mEqjd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-10-06_04,2022-10-06_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 impostorscore=0 spamscore=0 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=876 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210060095 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Carl Love via Gdb-patches From: Carl Love Reply-To: Carl Love Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" GDB maintainers: This patch set addresses the five test failures in gdb.cp/non-trivial- retval.exp on PowerPC. The failures started with commit b1718fcdd1d2a5c514f8ee504ba07fb3f42b8608 Author: Andrew Burgess Date: Mon Dec 13 16:56:16 2021 +0000 gdb: on x86-64 non-trivial C++ objects are returned in memory Fixes PR gdb/28681. It was observed that after using the `finish` command an incorrect value was displayed in some cases. Specifically, this behaviour was observed on an x86-64 target. The return value from the function is not correct due to multiple problems. The PowerPC specific code does not return the correct return value convention. This is fixed by the first patach. However due to the PowerPC ABI, GDB is still not able to reliably determine the function return value. The second patch addresses the issue of not being able to reliably determine the return buffer address on PowerPC. The patch adds a new GDB ABI to use the DW_OP_entryvalue for the DWARF entries to reliably obtain the return buffer address stored in register r3 on entry to the function. These two patches fix the five testsuite failures in gdb.cp/non- trivial-retval.exp on PowerPC. Carl Love